Repository navigation
feat: Store attestations in archiver - #12699
Merged
Merged
Conversation
spalladino
force-pushed
the
palla/store-attestations-in-archiver
branch
from
March 12, 2025 20:22
4adab55 to
a5faba6
Compare
spalladino
enabled auto-merge (squash)
March 12, 2025 20:36
Maddiaa0
reviewed
Mar 13, 2025
Maddiaa0
reviewed
Mar 13, 2025
Maddiaa0
reviewed
Mar 13, 2025
Downloads attestor signatures from L1 and stores them along with blocks. These are pushed into the attestation pool when new blocks are seen, to guarantee that all attestations are visible in the pool (in case some were missed via p2p). Introduces a new `PublishedL2Block` type (that replaces the `L1Published` wrapper type), and adds a `getPublishedBlocks` method to both archiver and node. Eventually we could merge this method with `getBlocks`, but I did not want to change every single client of `getBlocks` at this stage.
spalladino
force-pushed
the
palla/store-attestations-in-archiver
branch
from
March 13, 2025 17:41
a5faba6 to
2c3f666
Compare
Contributor
Author
|
@Maddiaa0 thanks for the review, I've addressed comments, rebased, and (hopefully) fixed tests |
Maddiaa0
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downloads attestor signatures from L1 and stores them along with blocks. These are pushed into the attestation pool when new blocks are seen, to guarantee that all attestations are visible in the pool (in case some were missed via p2p).
Introduces a new
PublishedL2Blocktype (that replaces theL1Publishedwrapper type), and adds agetPublishedBlocksmethod to both archiver and node. Eventually we could merge this method withgetBlocks, but I did not want to change every single client ofgetBlocksat this stage.