Repository navigation
feat: make shplemini proof constant - #8826
Merged
Merged
Conversation
added 30 commits
September 18, 2024 10:48
…something still makes proof not verify
added 2 commits
September 26, 2024 14:46
Contributor
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
iakovenkos
reviewed
Sep 26, 2024
| // Get evaluations a_i, i = 0,...,m-1 from transcript | ||
| const std::vector<Fr> evaluations = get_gemini_evaluations(num_variables, transcript); | ||
| // Compute evaluation A₀(r) | ||
| // Compute evaluation of A₀(r) |
Contributor
There was a problem hiding this comment.
without of, cause r is the eval point
iakovenkos
reviewed
Sep 26, 2024
| // Get uₗ₋₁ | ||
| const Fr& u = evaluation_point[l - 1]; | ||
| const Fr& eval_neg = evals[l - 1]; | ||
| // Fr batched_eval_round_acc = batched_eval_accumulator; |
iakovenkos
reviewed
Sep 26, 2024
| Commitment::one(&builder), | ||
| stdlib_verifier_transcript); | ||
| auto vk = std::make_shared<VerifierCommitmentKey<NativeCurve>>(); | ||
| EXPECT_EQ(vk->pairing_check(pairing_points[0].get_value(), pairing_points[1].get_value()), true); |
Contributor
There was a problem hiding this comment.
great that you extended this test to capture the constant size
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make Shplemini proofs constant using the same approach as in other places, add relevant github issues for handling the dummy rounds properly, make the shplemini recursion test do full verification and ensure recursive shplemini verifiers actually stay constant.