diff --git a/.circleci/config.yml b/.circleci/config.yml index a5ca27789aec..f3a1c176fd3a 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -247,7 +247,7 @@ jobs: command: cond_spot_run_test barretenberg-x86_64-linux-clang-assert 32 ./scripts/run_tests 1 proof_system_tests aztec_manifest_key: barretenberg-x86_64-linux-clang-assert - barretenberg-stdlib-recursion-ultra-tests: + barretenberg-stdlib-plonk-recursion-ultra-tests: docker: - image: aztecprotocol/alpine-build-image resource_class: small @@ -259,6 +259,18 @@ jobs: command: cond_spot_run_test barretenberg-x86_64-linux-clang-assert 32 ./scripts/run_tests 3 stdlib_plonk_recursion_tests --gtest_filter=-*turbo* aztec_manifest_key: barretenberg-x86_64-linux-clang-assert + barretenberg-stdlib-honk-recursion-ultra-tests: + docker: + - image: aztecprotocol/alpine-build-image + resource_class: small + steps: + - *checkout + - *setup_env + - run: + name: "Test" + command: cond_spot_run_test barretenberg-x86_64-linux-clang-assert 32 ./scripts/run_tests 3 stdlib_honk_recursion_tests + aztec_manifest_key: barretenberg-x86_64-linux-clang-assert + bb-js: machine: image: default @@ -1304,7 +1316,8 @@ workflows: - barretenberg-dsl-tests: *bb_test - barretenberg-tests: *bb_test - barretenberg-stdlib-tests: *bb_test - - barretenberg-stdlib-recursion-ultra-tests: *bb_test + - barretenberg-stdlib-plonk-recursion-ultra-tests: *bb_test + - barretenberg-stdlib-honk-recursion-ultra-tests: *bb_test - barretenberg-acir-tests-bb: *bb_acir_tests - barretenberg-acir-tests-bb-sol: requires: @@ -1443,7 +1456,8 @@ workflows: - barretenberg-dsl-tests - barretenberg-tests - barretenberg-stdlib-tests - - barretenberg-stdlib-recursion-ultra-tests + - barretenberg-stdlib-plonk-recursion-ultra-tests + - barretenberg-stdlib-honk-recursion-ultra-tests - barretenberg-acir-tests-bb - barretenberg-acir-tests-bb-sol - barretenberg-docs diff --git a/barretenberg/cpp/src/barretenberg/commitment_schemes/zeromorph/zeromorph.hpp b/barretenberg/cpp/src/barretenberg/commitment_schemes/zeromorph/zeromorph.hpp index 5f444c877920..f7f6089020f1 100644 --- a/barretenberg/cpp/src/barretenberg/commitment_schemes/zeromorph/zeromorph.hpp +++ b/barretenberg/cpp/src/barretenberg/commitment_schemes/zeromorph/zeromorph.hpp @@ -704,8 +704,16 @@ template class ZeroMorphVerifier_ { C_zeta_Z = C_zeta_x + C_Z_x * z_challenge; } + // Define the evaluation (always zero by construction in this case) for the PCS opening + FF evaluation{ 0 }; + if constexpr (Curve::is_stdlib_type) { // add builder if in circuit context + auto builder = z_challenge.get_context(); + evaluation = FF(builder, 0); + } + return PCS::reduce_verify( - { .opening_pair = { .challenge = x_challenge, .evaluation = FF(0) }, .commitment = C_zeta_Z }, transcript); + { .opening_pair = { .challenge = x_challenge, .evaluation = evaluation }, .commitment = C_zeta_Z }, + transcript); } };