From 08f07426238e40c393e2f64488434046fffa1d5b Mon Sep 17 00:00:00 2001 From: CodeDead Date: Fri, 16 Dec 2022 06:56:06 +0100 Subject: [PATCH 1/2] Fixed number parsing causing weird issues when comparing numbers and strings --- src/routes/Home/index.jsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/routes/Home/index.jsx b/src/routes/Home/index.jsx index 859f403..b6c92e1 100644 --- a/src/routes/Home/index.jsx +++ b/src/routes/Home/index.jsx @@ -121,7 +121,7 @@ const Home = () => { value={min} error={min > max} fullWidth - onChange={(e) => d2(setPasswordLengthMin(e.target.value))} + onChange={(e) => d2(setPasswordLengthMin(parseInt(e.target.value, 10)))} /> @@ -131,7 +131,7 @@ const Home = () => { value={max} error={max < min} fullWidth - onChange={(e) => d2(setPasswordLengthMax(e.target.value))} + onChange={(e) => d2(setPasswordLengthMax(parseInt(e.target.value, 10)))} /> From d9a39826cdb5a847546f0951a68e867f0641d356 Mon Sep 17 00:00:00 2001 From: CodeDead Date: Fri, 16 Dec 2022 07:07:12 +0100 Subject: [PATCH 2/2] Removed autocomplete from min, max and amount and fixed an issue with amount values --- src/routes/Home/index.jsx | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/routes/Home/index.jsx b/src/routes/Home/index.jsx index b6c92e1..bb3ea13 100644 --- a/src/routes/Home/index.jsx +++ b/src/routes/Home/index.jsx @@ -118,6 +118,7 @@ const Home = () => { max} fullWidth @@ -128,6 +129,7 @@ const Home = () => { { d2(setPasswordAmount(e.target.value))} + error={amount.length === 0 || amount < 1} + onChange={(e) => { + if (e.target.value && e.target.value.length > 0) { + d2(setPasswordAmount(parseInt(e.target.value, 10))); + } + }} fullWidth />