London | 26-ITP-May | Chun Yan Wong | Sprint 2 | Wireframe by cywong-dev · Pull Request #1376 · CodeYourFuture/Module-Onboarding

cywong-dev · 2026-05-30T15:43:42Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I completed the changed based on the requirement

netlify · 2026-05-30T15:43:46Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`5d620ad`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a2311c5b6c7ab0008698968
😎 Deploy Preview	https://deploy-preview-1376--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

cjyuan

According to https://validator.w3.org/, there are errors in your code. Can you fix them?
To better match the layout in the wireframe, can you make the title and the "Read More" links in articles 2 and 3 fully aligned horizontally?

Note: If you have not yet enabled "Format on save" on VS Code, consider following this guide to enable VS Code's
"Format on Save" option or to use its "Format Document" command to ensure your code is always consistently formatted.

Changed the html file with <nav> for better display Changed the css file to the footer control with relative position instead of fixed position

cjyuan

According to https://validator.w3.org/, there are errors in your code. Can you fix them?
The footer now no longer fixed at the bottom of the page. Can you address this issue so that the implementation meets all the requirement?
Your code is well formatted. In case you haven't yet enabled "Format on save" in VS Code, please consider to do so.

replace the <br> with css margin correct the space in the href fixed the footer so that it can be displayed at the bottom of the page

cjyuan

The footer is now fixed at the bottom of the page. Can you also ensure:

The footer content is centered
The footer content and the article content won't overlap

cywong-dev · 2026-06-05T16:35:36Z

The comments -
the footer content is not centered
the footer content and the article content overlap
has been fixed

- The footer is not centered - The footer and article content overlapped

cjyuan · 2026-06-05T17:01:59Z

The footer content is not always centered; its placement changes depending on the browser window width.
The footer and the article content can still overlap (see pic), depending on the browser window size.

Can you try another way to address the issue?

Update the css stylesheet to center the footer

cywong-dev · 2026-06-05T17:28:15Z

Updated the css stylesheet to center the footer

cjyuan · 2026-06-05T17:50:00Z

Now the footer no longer "fixed at the bottom of the viewport".

Can you find a way to ensure that all of these three conditions are satisfied simultaneously?

The footer is fixed at the bottom of the viewport (to meet a requirement)
The footer content is centered, (to match the wireframe)
The footer text content should not overlap the article content (to be user friendly)

To clear the problem by satisfying all conditions

cywong-dev · 2026-06-05T18:14:03Z

I misunderstood the problem.
Please kindly check it again.
Thanks

cjyuan · 2026-06-05T18:38:59Z

All good now. well done.

initial draft

a152651

Added the graphics files and revised the html file for it on 30 May 2026

624b988

cywong-dev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026

cjyuan reviewed May 30, 2026

View reviewed changes

Comment thread Wireframe/index.html Outdated

Comment thread Wireframe/index.html

Comment thread Wireframe/index.html Outdated

Comment thread Wireframe/style.css

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 30, 2026

cywong-dev added the Module-Onboarding The name of the module. label Jun 3, 2026

Changed the index.html file and style.css file for the comments

94bd6ab

Changed the html file with <nav> for better display Changed the css file to the footer control with relative position instead of fixed position

cywong-dev added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 3, 2026

cjyuan reviewed Jun 3, 2026

View reviewed changes

Comment thread Wireframe/index.html Outdated

Comment thread Wireframe/index.html Outdated

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 3, 2026

cjyuan reviewed Jun 3, 2026

View reviewed changes

Comment thread Wireframe/index.html Outdated

Fixed the issues by following the recommendation

f8f7b15

replace the <br> with css margin correct the space in the href fixed the footer so that it can be displayed at the bottom of the page

cywong-dev added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 4, 2026

cjyuan reviewed Jun 4, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 4, 2026

Change margin in css to follow the recommendation

d6a97fd

- The footer is not centered - The footer and article content overlapped

cywong-dev added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 5, 2026

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 5, 2026

Solve the footer center problem

e6815b0

Update the css stylesheet to center the footer

cywong-dev added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 5, 2026

Revised for fine-tuning the footer overlap problem

e9ec79e

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 5, 2026

Update the css stylesheet

5d620ad

To clear the problem by satisfying all conditions

cywong-dev added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 5, 2026

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 5, 2026

cywong-dev mentioned this pull request Jun 5, 2026

London | 26-ITP-May | Onboarding | Chun Yan Wong cywong-dev/My-Coursework-Planner#10

Open

Uh oh!

Conversation

cywong-dev commented May 30, 2026

Learners, PR Template

Changelist

Uh oh!

netlify Bot commented May 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cywong-dev commented Jun 5, 2026

Uh oh!

cjyuan commented Jun 5, 2026

Uh oh!

cywong-dev commented Jun 5, 2026

Uh oh!

cjyuan commented Jun 5, 2026

Uh oh!

cywong-dev commented Jun 5, 2026

Uh oh!

cjyuan commented Jun 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify Bot commented May 30, 2026 •

edited

Loading