Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Update Python.org.xml#5109

Merged
J0WI merged 15 commits into
EFForg:masterfrom
davidabian:patch-15
Apr 28, 2017
Merged

Update Python.org.xml#5109
J0WI merged 15 commits into
EFForg:masterfrom
davidabian:patch-15

Conversation

@davidabian

Copy link
Copy Markdown
Contributor

No description provided.

@J0WI

J0WI commented Jun 21, 2016

Copy link
Copy Markdown
Contributor

WFM:
pypi.python.org
planet.python.org

@davidabian

Copy link
Copy Markdown
Contributor Author

@J0WI: It seems that pypi is already here.
Should we join both files together?

@J0WI

J0WI commented Jun 21, 2016

Copy link
Copy Markdown
Contributor

Yes, could you do that?

@J0WI

J0WI commented Sep 8, 2016

Copy link
Copy Markdown
Contributor

@davidabian would be great to have this fixed :)

@jeremyn

jeremyn commented Nov 28, 2016

Copy link
Copy Markdown
Contributor

@davidabian Are you still interested in working on this one?

@jeremyn

jeremyn commented Dec 3, 2016

Copy link
Copy Markdown
Contributor

pypi.python.org is already in a different ruleset, Pypi.xml. It looks like that ruleset is included in the updates in this pull request, so you can delete that ruleset in this pull request.

@jeremyn jeremyn self-assigned this Dec 3, 2016
@jeremyn

jeremyn commented Dec 18, 2016

Copy link
Copy Markdown
Contributor

Please:

Remove from top comment:

Mark as Invalid certificate, and add (Incomplete certificate chain) next to it in the comment if noted:

Mark as No working URL known:

Mark as Refused:

Mark as Secure connection failed:

Remove due to being HSTS preloaded (see #5109 (comment)):

Add target:

Also:

@jeremyn

jeremyn commented Jan 25, 2017

Copy link
Copy Markdown
Contributor

@davidabian I'm checking in on this pull request. Are you planning on making the changes I requested?

@davidabian

Copy link
Copy Markdown
Contributor Author

@jeremyn Yes, I am.

@jeremyn

jeremyn commented Jan 26, 2017

Copy link
Copy Markdown
Contributor

I've updated the checklist through c9b696a.

For the securecookie, you added:

<securecookie host="^(?:[^@:/]+\.)python\.org$" name=".*" />

Looking at the style guide, I think a better fit with the same effect is:

<securecookie host="^[\w.-]+\.python\.org$" name=".+" />

but please double-check that. I originally had something more explicit like this in mind, and that would be okay too.

For the merge conflicts, that was caused by #8128 which removed docs.python.org and hg.python.org. So, just remove those two subdomains and then merge or rebase.

Because of all the commits, is it all right with you if I remove the commit messages when I squash-and-merge at the end?

@davidabian

Copy link
Copy Markdown
Contributor Author

Thanks, @jeremyn. Yes, please, feel free to remove these commit messages.

@jeremyn

jeremyn commented Jan 26, 2017

Copy link
Copy Markdown
Contributor

Thanks, looks good. Can you fix the conflict yourself? The problem is that if I do it for you, then I'm supposed to get another reviewer to look at my changes, and that might take a while.

Also, can you please move the openbadges.es target between lists.es and jobs? The goal is to have the subdomains grouped together in sub-subdomain order. You can also combine the es subdomains in the securecookie like (hs|lists|openbadges)\.es .

@davidabian

Copy link
Copy Markdown
Contributor Author

Some certificates have expired since this pull request was opened. Should we wait until they are renewed?

@Hainish

Hainish commented Jan 27, 2017

Copy link
Copy Markdown
Member

It looks like this PR contains some domains that are HSTS preloaded: https://chromium.googlesource.com/chromium/src/net/+/refs/heads/master/http/transport_security_state_static.json
Looking now: wiki.python.org, www.python.org, pypi.python.org, doc.python.org, and console.python.org

Since these are rewritten to HTTPS by the browser itself, there is no need to include them in this ruleset. Removing them will cause the preload test to pass.

Thanks for contributing this! It's a big improvement.

@jeremyn

jeremyn commented Jan 27, 2017

Copy link
Copy Markdown
Contributor

@davidabian I updated the checklist through 13eaa5f and emailed the Python.org webmaster about their certificate. Let's give them a few days on that problem.

EDIT: I also added some new items to the checklist, sorry.

@jeremyn

jeremyn commented Jan 27, 2017

Copy link
Copy Markdown
Contributor

I've also added the HSTS preloaded domains that were mentioned in #5109 (comment) to the checklist.

@jeremyn

jeremyn commented Jan 27, 2017

Copy link
Copy Markdown
Contributor

The Python.org team has renewed their certificate for https://svn.python.org, so that's not a problem anymore.

@jeremyn

jeremyn commented Apr 25, 2017

Copy link
Copy Markdown
Contributor

@gloomy-ghost @J0WI Can one of you please review the small changes I made and then merge this?

@jeremyn jeremyn removed their assignment Apr 25, 2017
@J0WI J0WI merged commit e0a30c9 into EFForg:master Apr 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants