From dd99fd3997a779c66492bbdfb0a8f7432fb95a87 Mon Sep 17 00:00:00 2001 From: Jasper Huang Date: Mon, 10 Jul 2023 13:02:03 -0700 Subject: [PATCH 1/6] ensure task title page focuses is at the end on dev --- src/pages/tasks/TaskTitlePage.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/pages/tasks/TaskTitlePage.js b/src/pages/tasks/TaskTitlePage.js index 17857f0032e3..b365e0f568fc 100644 --- a/src/pages/tasks/TaskTitlePage.js +++ b/src/pages/tasks/TaskTitlePage.js @@ -13,6 +13,7 @@ import styles from '../../styles/styles'; import reportPropTypes from '../reportPropTypes'; import compose from '../../libs/compose'; import * as Task from '../../libs/actions/Task'; +import focusAndUpdateMultilineInputRange from '../../libs/focusAndUpdateMultilineInputRange'; const propTypes = { /** The report currently being looked at */ @@ -62,7 +63,7 @@ function TaskTitlePage(props) { return ( inputRef.current && inputRef.current.focus()} + onEntryTransitionEnd={() => focusAndUpdateMultilineInputRange(inputRef.current)} >
Date: Mon, 10 Jul 2023 14:30:20 -0700 Subject: [PATCH 2/6] ensure task title input occupies multiple lines --- src/pages/tasks/NewTaskDetailsPage.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/pages/tasks/NewTaskDetailsPage.js b/src/pages/tasks/NewTaskDetailsPage.js index 5e576c42174c..a5a4f2619046 100644 --- a/src/pages/tasks/NewTaskDetailsPage.js +++ b/src/pages/tasks/NewTaskDetailsPage.js @@ -96,6 +96,9 @@ function NewTaskPage(props) { label={props.translate('task.title')} value={taskTitle} onValueChange={(value) => setTaskTitle(value)} + autoGrowHeight + textAlignVertical="top" + containerStyles={[styles.autoGrowHeightMultilineInput]} /> From 60deb7907246204e96d16e999c9d93f1ff9d3934 Mon Sep 17 00:00:00 2001 From: Jasper Huang Date: Mon, 10 Jul 2023 14:30:31 -0700 Subject: [PATCH 3/6] don't open task assignee selector modal when clicking task headers --- src/pages/home/HeaderView.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/home/HeaderView.js b/src/pages/home/HeaderView.js index bf616870fc48..ccb87a749532 100644 --- a/src/pages/home/HeaderView.js +++ b/src/pages/home/HeaderView.js @@ -162,7 +162,7 @@ function HeaderView(props) { {Boolean(props.report && title) && ( (isTaskReport ? Navigation.navigate(ROUTES.getTaskReportAssigneeRoute(props.report.reportID)) : ReportUtils.navigateToDetailsPage(props.report))} + onPress={() => !isTaskReport && ReportUtils.navigateToDetailsPage(props.report)} style={[styles.flexRow, styles.alignItemsCenter, styles.flex1]} disabled={isTaskReport && !ReportUtils.isOpenTaskReport(props.report)} accessibilityLabel={title} From 7ad293ec8c16649e3ff36b4098089e82fe1103d6 Mon Sep 17 00:00:00 2001 From: Jasper Huang Date: Tue, 11 Jul 2023 11:50:33 -0700 Subject: [PATCH 4/6] use default language for title --- ios/Podfile.lock | 4 ++-- src/components/ReportActionItem/TaskView.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ios/Podfile.lock b/ios/Podfile.lock index 9765bc89e635..6075ab1ef4c6 100644 --- a/ios/Podfile.lock +++ b/ios/Podfile.lock @@ -1024,7 +1024,7 @@ EXTERNAL SOURCES: SPEC CHECKSUMS: Airship: c70eed50e429f97f5adb285423c7291fb7a032ae AirshipFrameworkProxy: 7bc4130c668c6c98e2d4c60fe4c9eb61a999be99 - boost: 57d2868c099736d80fcd648bf211b4431e51a558 + boost: a7c83b31436843459a1961bfd74b96033dc77234 CocoaAsyncSocket: 065fd1e645c7abab64f7a6a2007a48038fdc6a99 DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54 FBLazyVector: ff54429f0110d3c722630a98096ba689c39f6d5f @@ -1067,7 +1067,7 @@ SPEC CHECKSUMS: Permission-LocationWhenInUse: 3ba99e45c852763f730eabecec2870c2382b7bd4 Plaid: 7d340abeadb46c7aa1a91f896c5b22395a31fcf2 PromisesObjC: 09985d6d70fbe7878040aa746d78236e6946d2ef - RCT-Folly: 424b8c9a7a0b9ab2886ffe9c3b041ef628fd4fb1 + RCT-Folly: 0080d0a6ebf2577475bda044aa59e2ca1f909cda RCTRequired: e9e7b8b45aa9bedb2fdad71740adf07a7265b9be RCTTypeSafety: 9ae0e9206625e995f0df4d5b9ddc94411929fb30 React: a71c8e1380f07e01de721ccd52bcf9c03e81867d diff --git a/src/components/ReportActionItem/TaskView.js b/src/components/ReportActionItem/TaskView.js index 6e6afe1591e7..25132e20c098 100644 --- a/src/components/ReportActionItem/TaskView.js +++ b/src/components/ReportActionItem/TaskView.js @@ -65,7 +65,7 @@ function TaskView(props) { > {({hovered, pressed}) => ( <> - Title + {props.translate('task.title')} (isCompleted ? Task.reopenTask(props.report.reportID, taskTitle) : Task.completeTask(props.report.reportID, taskTitle))} From 76704c4c83e1da841d64d65f8acb225be094e872 Mon Sep 17 00:00:00 2001 From: Jasper Huang Date: Tue, 11 Jul 2023 11:51:12 -0700 Subject: [PATCH 5/6] remove unused --- ios/Podfile.lock | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ios/Podfile.lock b/ios/Podfile.lock index 6075ab1ef4c6..9765bc89e635 100644 --- a/ios/Podfile.lock +++ b/ios/Podfile.lock @@ -1024,7 +1024,7 @@ EXTERNAL SOURCES: SPEC CHECKSUMS: Airship: c70eed50e429f97f5adb285423c7291fb7a032ae AirshipFrameworkProxy: 7bc4130c668c6c98e2d4c60fe4c9eb61a999be99 - boost: a7c83b31436843459a1961bfd74b96033dc77234 + boost: 57d2868c099736d80fcd648bf211b4431e51a558 CocoaAsyncSocket: 065fd1e645c7abab64f7a6a2007a48038fdc6a99 DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54 FBLazyVector: ff54429f0110d3c722630a98096ba689c39f6d5f @@ -1067,7 +1067,7 @@ SPEC CHECKSUMS: Permission-LocationWhenInUse: 3ba99e45c852763f730eabecec2870c2382b7bd4 Plaid: 7d340abeadb46c7aa1a91f896c5b22395a31fcf2 PromisesObjC: 09985d6d70fbe7878040aa746d78236e6946d2ef - RCT-Folly: 0080d0a6ebf2577475bda044aa59e2ca1f909cda + RCT-Folly: 424b8c9a7a0b9ab2886ffe9c3b041ef628fd4fb1 RCTRequired: e9e7b8b45aa9bedb2fdad71740adf07a7265b9be RCTTypeSafety: 9ae0e9206625e995f0df4d5b9ddc94411929fb30 React: a71c8e1380f07e01de721ccd52bcf9c03e81867d From 1bd5f0d8d42856d33a88400ee1615815dab11f64 Mon Sep 17 00:00:00 2001 From: Jasper Huang Date: Tue, 11 Jul 2023 13:19:02 -0700 Subject: [PATCH 6/6] Navigate to details page for task reports upon clicking header --- src/pages/home/HeaderView.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/home/HeaderView.js b/src/pages/home/HeaderView.js index ccb87a749532..e405073c7476 100644 --- a/src/pages/home/HeaderView.js +++ b/src/pages/home/HeaderView.js @@ -162,7 +162,7 @@ function HeaderView(props) { {Boolean(props.report && title) && ( !isTaskReport && ReportUtils.navigateToDetailsPage(props.report)} + onPress={() => ReportUtils.navigateToDetailsPage(props.report)} style={[styles.flexRow, styles.alignItemsCenter, styles.flex1]} disabled={isTaskReport && !ReportUtils.isOpenTaskReport(props.report)} accessibilityLabel={title}