From f28552fad29fd772a72f8ad6337edcd8781bf112 Mon Sep 17 00:00:00 2001 From: "David E. Gelhar" Date: Tue, 27 May 2025 18:26:47 -0400 Subject: [PATCH 01/19] fix tooltip display problem in spanish --- src/components/ProductTrainingContext/index.tsx | 1 - src/components/Tooltip/BaseGenericTooltip/index.tsx | 2 ++ src/components/Tooltip/BaseGenericTooltip/types.ts | 3 +++ src/components/Tooltip/GenericTooltip.tsx | 4 +++- src/components/Tooltip/types.ts | 7 +++++++ src/languages/es.ts | 2 +- src/pages/iou/request/step/IOURequestStepScan/index.tsx | 1 + src/styles/utils/generators/TooltipStyleUtils/index.ts | 2 ++ src/styles/variables.ts | 1 + 9 files changed, 20 insertions(+), 3 deletions(-) diff --git a/src/components/ProductTrainingContext/index.tsx b/src/components/ProductTrainingContext/index.tsx index 1d09204447f9..821825e3207d 100644 --- a/src/components/ProductTrainingContext/index.tsx +++ b/src/components/ProductTrainingContext/index.tsx @@ -274,7 +274,6 @@ const useProductTrainingContext = (tooltipName: ProductTrainingTooltipName, shou styles.alignItemsCenter, styles.flexRow, tooltip?.shouldRenderActionButtons ? styles.justifyContentStart : styles.justifyContentCenter, - styles.flexWrap, styles.textAlignCenter, styles.gap3, styles.pv2, diff --git a/src/components/Tooltip/BaseGenericTooltip/index.tsx b/src/components/Tooltip/BaseGenericTooltip/index.tsx index bfa84cd1830d..43470c63ae57 100644 --- a/src/components/Tooltip/BaseGenericTooltip/index.tsx +++ b/src/components/Tooltip/BaseGenericTooltip/index.tsx @@ -42,6 +42,7 @@ function BaseGenericTooltip({ shouldUseOverlay = false, onHideTooltip = () => {}, isEducationTooltip = false, + ignoreGutter = false, onTooltipPress = () => {}, }: BaseGenericTooltipProps) { // The width of tooltip's inner content. Has to be undefined in the beginning @@ -97,6 +98,7 @@ function BaseGenericTooltip({ anchorAlignment, wrapperStyle, isEducationTooltip, + ignoreGutter }), [ StyleUtils, diff --git a/src/components/Tooltip/BaseGenericTooltip/types.ts b/src/components/Tooltip/BaseGenericTooltip/types.ts index bfd38cf73190..21bd8c242121 100644 --- a/src/components/Tooltip/BaseGenericTooltip/types.ts +++ b/src/components/Tooltip/BaseGenericTooltip/types.ts @@ -36,6 +36,9 @@ type BaseGenericTooltipProps = { /** Whether it is education tooltip */ isEducationTooltip?: boolean; + + /** Whether the tooltip is allowed to extend into the gutters */ + ignoreGutter?: boolean; } & Pick< SharedTooltipProps, 'renderTooltipContent' | 'maxWidth' | 'numberOfLines' | 'text' | 'shouldForceRenderingBelow' | 'wrapperStyle' | 'anchorAlignment' | 'shouldUseOverlay' | 'onTooltipPress' diff --git a/src/components/Tooltip/GenericTooltip.tsx b/src/components/Tooltip/GenericTooltip.tsx index 811360cc8228..7310d5245356 100644 --- a/src/components/Tooltip/GenericTooltip.tsx +++ b/src/components/Tooltip/GenericTooltip.tsx @@ -20,7 +20,7 @@ import type {GenericTooltipProps} from './types'; function GenericTooltip({ children, numberOfLines = CONST.TOOLTIP_MAX_LINES, - maxWidth = variables.sideBarWidth, + maxWidth = variables.tooltipWidth, text = '', renderTooltipContent, renderTooltipContentKey = [], @@ -38,6 +38,7 @@ function GenericTooltip({ shouldRender = true, isEducationTooltip = false, onTooltipPress = () => {}, + ignoreGutter = false, }: GenericTooltipProps) { const {preferredLocale} = useLocalize(); const {windowWidth} = useWindowDimensions(); @@ -189,6 +190,7 @@ function GenericTooltip({ shouldTeleportPortalToModalLayer={shouldTeleportPortalToModalLayer} onHideTooltip={onPressOverlay} onTooltipPress={onTooltipPress} + ignoreGutter={ignoreGutter} /> )} {/* eslint-disable-next-line react-compiler/react-compiler */} diff --git a/src/components/Tooltip/types.ts b/src/components/Tooltip/types.ts index c34e86b528b3..a0369f95db85 100644 --- a/src/components/Tooltip/types.ts +++ b/src/components/Tooltip/types.ts @@ -72,6 +72,10 @@ type GenericTooltipProps = SharedTooltipProps & { /** Whether it is education tooltip */ isEducationTooltip?: boolean; + + /** Whether the tooltip is allowed to extend into the gutters */ + ignoreGutter?: boolean; + }; type TooltipProps = ChildrenProps & @@ -81,6 +85,9 @@ type TooltipProps = ChildrenProps & /** Whether the current screen or component is actively focused via navigation */ isFocused?: boolean; + + /** Whether the tooltip is allowed to extend into the gutters */ + ignoreGutter?: boolean; }; type EducationalTooltipProps = ChildrenProps & diff --git a/src/languages/es.ts b/src/languages/es.ts index 0e48eee26d1b..d48d94bc04c2 100644 --- a/src/languages/es.ts +++ b/src/languages/es.ts @@ -6854,7 +6854,7 @@ const translations = { }, scanTestTooltip: { part1: '¿Quieres ver cómo funciona Escanear?', - part2: '¡Prueba con un recibo de prueba!', + part2: ' ¡Prueba con un recibo de prueba!', part3: '¡Elige a', part4: ' nuestro gerente', part5: ' de prueba para probarlo!', diff --git a/src/pages/iou/request/step/IOURequestStepScan/index.tsx b/src/pages/iou/request/step/IOURequestStepScan/index.tsx index 09b550c23a92..d9ca40cb04c6 100644 --- a/src/pages/iou/request/step/IOURequestStepScan/index.tsx +++ b/src/pages/iou/request/step/IOURequestStepScan/index.tsx @@ -925,6 +925,7 @@ function IOURequestStepScan({ }} wrapperStyle={styles.productTrainingTooltipWrapper} shiftVertical={-elementTop} + ignoreGutter > {!(isDraggingOver ?? isDraggingOverWrapper) && (isMobile() ? mobileCameraView() : desktopUploadView())} diff --git a/src/styles/utils/generators/TooltipStyleUtils/index.ts b/src/styles/utils/generators/TooltipStyleUtils/index.ts index afd7cffeba76..1d44d77c5662 100644 --- a/src/styles/utils/generators/TooltipStyleUtils/index.ts +++ b/src/styles/utils/generators/TooltipStyleUtils/index.ts @@ -51,6 +51,7 @@ type TooltipParams = { anchorAlignment?: TooltipAnchorAlignment; shouldAddHorizontalPadding?: boolean; isEducationTooltip?: boolean; + ignoreGutter?: boolean; }; type TooltipAnimationProps = { @@ -106,6 +107,7 @@ const createTooltipStyleUtils: StyleUtilGenerator = ( }, wrapperStyle = {}, isEducationTooltip = false, + ignoreGutter = false, }) => { const pointerWidth = isEducationTooltip ? EDUCATION_POINTER_WIDTH : POINTER_WIDTH; const pointerHeight = isEducationTooltip ? EDUCATION_POINTER_HEIGHT : POINTER_HEIGHT; diff --git a/src/styles/variables.ts b/src/styles/variables.ts index 3a0495d37c7b..ccc3a1592300 100644 --- a/src/styles/variables.ts +++ b/src/styles/variables.ts @@ -98,6 +98,7 @@ export default { iosSafeAreaInsetsPercentage: 0.7, androidSafeAreaInsetsPercentage: 1, sideBarWidth: 375, + tooltipWidth: 331, sideBarWithLHBWidth: 320, navigationTabBarSize: 72, pdfPageMaxWidth: 992, From 2ffa18ebc0a5f27a221fda69d4236bf79ec0bfbd Mon Sep 17 00:00:00 2001 From: "David E. Gelhar" Date: Tue, 27 May 2025 18:30:31 -0400 Subject: [PATCH 02/19] don't need 'ignoreGutter' prop if width is limited --- src/components/Tooltip/BaseGenericTooltip/index.tsx | 2 -- src/components/Tooltip/BaseGenericTooltip/types.ts | 3 --- src/components/Tooltip/GenericTooltip.tsx | 2 -- src/components/Tooltip/types.ts | 7 ------- src/pages/iou/request/step/IOURequestStepScan/index.tsx | 1 - src/styles/utils/generators/TooltipStyleUtils/index.ts | 2 -- 6 files changed, 17 deletions(-) diff --git a/src/components/Tooltip/BaseGenericTooltip/index.tsx b/src/components/Tooltip/BaseGenericTooltip/index.tsx index 43470c63ae57..bfa84cd1830d 100644 --- a/src/components/Tooltip/BaseGenericTooltip/index.tsx +++ b/src/components/Tooltip/BaseGenericTooltip/index.tsx @@ -42,7 +42,6 @@ function BaseGenericTooltip({ shouldUseOverlay = false, onHideTooltip = () => {}, isEducationTooltip = false, - ignoreGutter = false, onTooltipPress = () => {}, }: BaseGenericTooltipProps) { // The width of tooltip's inner content. Has to be undefined in the beginning @@ -98,7 +97,6 @@ function BaseGenericTooltip({ anchorAlignment, wrapperStyle, isEducationTooltip, - ignoreGutter }), [ StyleUtils, diff --git a/src/components/Tooltip/BaseGenericTooltip/types.ts b/src/components/Tooltip/BaseGenericTooltip/types.ts index 21bd8c242121..bfd38cf73190 100644 --- a/src/components/Tooltip/BaseGenericTooltip/types.ts +++ b/src/components/Tooltip/BaseGenericTooltip/types.ts @@ -36,9 +36,6 @@ type BaseGenericTooltipProps = { /** Whether it is education tooltip */ isEducationTooltip?: boolean; - - /** Whether the tooltip is allowed to extend into the gutters */ - ignoreGutter?: boolean; } & Pick< SharedTooltipProps, 'renderTooltipContent' | 'maxWidth' | 'numberOfLines' | 'text' | 'shouldForceRenderingBelow' | 'wrapperStyle' | 'anchorAlignment' | 'shouldUseOverlay' | 'onTooltipPress' diff --git a/src/components/Tooltip/GenericTooltip.tsx b/src/components/Tooltip/GenericTooltip.tsx index 7310d5245356..5f64f27d621a 100644 --- a/src/components/Tooltip/GenericTooltip.tsx +++ b/src/components/Tooltip/GenericTooltip.tsx @@ -38,7 +38,6 @@ function GenericTooltip({ shouldRender = true, isEducationTooltip = false, onTooltipPress = () => {}, - ignoreGutter = false, }: GenericTooltipProps) { const {preferredLocale} = useLocalize(); const {windowWidth} = useWindowDimensions(); @@ -190,7 +189,6 @@ function GenericTooltip({ shouldTeleportPortalToModalLayer={shouldTeleportPortalToModalLayer} onHideTooltip={onPressOverlay} onTooltipPress={onTooltipPress} - ignoreGutter={ignoreGutter} /> )} {/* eslint-disable-next-line react-compiler/react-compiler */} diff --git a/src/components/Tooltip/types.ts b/src/components/Tooltip/types.ts index a0369f95db85..c34e86b528b3 100644 --- a/src/components/Tooltip/types.ts +++ b/src/components/Tooltip/types.ts @@ -72,10 +72,6 @@ type GenericTooltipProps = SharedTooltipProps & { /** Whether it is education tooltip */ isEducationTooltip?: boolean; - - /** Whether the tooltip is allowed to extend into the gutters */ - ignoreGutter?: boolean; - }; type TooltipProps = ChildrenProps & @@ -85,9 +81,6 @@ type TooltipProps = ChildrenProps & /** Whether the current screen or component is actively focused via navigation */ isFocused?: boolean; - - /** Whether the tooltip is allowed to extend into the gutters */ - ignoreGutter?: boolean; }; type EducationalTooltipProps = ChildrenProps & diff --git a/src/pages/iou/request/step/IOURequestStepScan/index.tsx b/src/pages/iou/request/step/IOURequestStepScan/index.tsx index d9ca40cb04c6..09b550c23a92 100644 --- a/src/pages/iou/request/step/IOURequestStepScan/index.tsx +++ b/src/pages/iou/request/step/IOURequestStepScan/index.tsx @@ -925,7 +925,6 @@ function IOURequestStepScan({ }} wrapperStyle={styles.productTrainingTooltipWrapper} shiftVertical={-elementTop} - ignoreGutter > {!(isDraggingOver ?? isDraggingOverWrapper) && (isMobile() ? mobileCameraView() : desktopUploadView())} diff --git a/src/styles/utils/generators/TooltipStyleUtils/index.ts b/src/styles/utils/generators/TooltipStyleUtils/index.ts index 1d44d77c5662..afd7cffeba76 100644 --- a/src/styles/utils/generators/TooltipStyleUtils/index.ts +++ b/src/styles/utils/generators/TooltipStyleUtils/index.ts @@ -51,7 +51,6 @@ type TooltipParams = { anchorAlignment?: TooltipAnchorAlignment; shouldAddHorizontalPadding?: boolean; isEducationTooltip?: boolean; - ignoreGutter?: boolean; }; type TooltipAnimationProps = { @@ -107,7 +106,6 @@ const createTooltipStyleUtils: StyleUtilGenerator = ( }, wrapperStyle = {}, isEducationTooltip = false, - ignoreGutter = false, }) => { const pointerWidth = isEducationTooltip ? EDUCATION_POINTER_WIDTH : POINTER_WIDTH; const pointerHeight = isEducationTooltip ? EDUCATION_POINTER_HEIGHT : POINTER_HEIGHT; From e60c5fc40d9fcc359b927bdc8c99675884c20d62 Mon Sep 17 00:00:00 2001 From: "David E. Gelhar" Date: Thu, 29 May 2025 20:20:20 -0400 Subject: [PATCH 03/19] dependency cleanup for esLint --- src/components/ProductTrainingContext/index.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/src/components/ProductTrainingContext/index.tsx b/src/components/ProductTrainingContext/index.tsx index 821825e3207d..9a8f9cc38094 100644 --- a/src/components/ProductTrainingContext/index.tsx +++ b/src/components/ProductTrainingContext/index.tsx @@ -353,7 +353,6 @@ const useProductTrainingContext = (tooltipName: ProductTrainingTooltipName, shou styles.flexRow, styles.justifyContentStart, styles.justifyContentCenter, - styles.flexWrap, styles.textAlignCenter, styles.gap3, styles.pv2, From 14531476ce3b07bb3361d8400fbf648b5c0f7730 Mon Sep 17 00:00:00 2001 From: "David E. Gelhar" Date: Fri, 30 May 2025 17:53:13 -0400 Subject: [PATCH 04/19] fix wrapping problem --- src/components/ProductTrainingContext/index.tsx | 2 +- src/styles/utils/sizing.ts | 4 ++++ src/styles/variables.ts | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/components/ProductTrainingContext/index.tsx b/src/components/ProductTrainingContext/index.tsx index 9a8f9cc38094..aaf315c94595 100644 --- a/src/components/ProductTrainingContext/index.tsx +++ b/src/components/ProductTrainingContext/index.tsx @@ -285,7 +285,7 @@ const useProductTrainingContext = (tooltipName: ProductTrainingTooltipName, shou fill={theme.tooltipHighlightText} medium /> - + {tooltip.content.map(({text, isBold}) => { const translatedText = translate(text); return ( diff --git a/src/styles/utils/sizing.ts b/src/styles/utils/sizing.ts index a73667951a5c..daa2a841af9e 100644 --- a/src/styles/utils/sizing.ts +++ b/src/styles/utils/sizing.ts @@ -135,6 +135,10 @@ export default { maxWidth: '75%', }, + mw95: { + maxWidth: '95%', + }, + mw100: { maxWidth: '100%', }, diff --git a/src/styles/variables.ts b/src/styles/variables.ts index ccc3a1592300..952402051da9 100644 --- a/src/styles/variables.ts +++ b/src/styles/variables.ts @@ -98,7 +98,7 @@ export default { iosSafeAreaInsetsPercentage: 0.7, androidSafeAreaInsetsPercentage: 1, sideBarWidth: 375, - tooltipWidth: 331, + tooltipWidth: 334, sideBarWithLHBWidth: 320, navigationTabBarSize: 72, pdfPageMaxWidth: 992, From d85c21872968d52d3de088fbfca2671dbedf9d21 Mon Sep 17 00:00:00 2001 From: "David E. Gelhar" Date: Fri, 30 May 2025 18:17:07 -0400 Subject: [PATCH 05/19] fix dependency for esLint --- src/components/ProductTrainingContext/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/ProductTrainingContext/index.tsx b/src/components/ProductTrainingContext/index.tsx index aaf315c94595..6e1ad7c02963 100644 --- a/src/components/ProductTrainingContext/index.tsx +++ b/src/components/ProductTrainingContext/index.tsx @@ -359,7 +359,7 @@ const useProductTrainingContext = (tooltipName: ProductTrainingTooltipName, shou styles.ph1, styles.productTrainingTooltipText, styles.textWrap, - styles.mw100, + styles.mw95, styles.flex1, styles.justifyContentBetween, styles.ph2, From 4774ccc8872c45437b3014524aef0a2fb58ebf70 Mon Sep 17 00:00:00 2001 From: "David E. Gelhar" Date: Sun, 1 Jun 2025 19:37:03 -0400 Subject: [PATCH 06/19] define a var for tooltipMargin --- src/components/Tooltip/GenericTooltip.tsx | 2 +- src/styles/variables.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/Tooltip/GenericTooltip.tsx b/src/components/Tooltip/GenericTooltip.tsx index 5f64f27d621a..d64752a53fa7 100644 --- a/src/components/Tooltip/GenericTooltip.tsx +++ b/src/components/Tooltip/GenericTooltip.tsx @@ -20,7 +20,7 @@ import type {GenericTooltipProps} from './types'; function GenericTooltip({ children, numberOfLines = CONST.TOOLTIP_MAX_LINES, - maxWidth = variables.tooltipWidth, + maxWidth = variables.sideBarWidth - 2*variables.tooltipMargin, text = '', renderTooltipContent, renderTooltipContentKey = [], diff --git a/src/styles/variables.ts b/src/styles/variables.ts index 952402051da9..a8ba2798f61e 100644 --- a/src/styles/variables.ts +++ b/src/styles/variables.ts @@ -98,7 +98,7 @@ export default { iosSafeAreaInsetsPercentage: 0.7, androidSafeAreaInsetsPercentage: 1, sideBarWidth: 375, - tooltipWidth: 334, + tooltipMargin: 20, sideBarWithLHBWidth: 320, navigationTabBarSize: 72, pdfPageMaxWidth: 992, From 89105b6392a52d420067ebc1da49e0bd5d46f67a Mon Sep 17 00:00:00 2001 From: "David E. Gelhar" Date: Sun, 1 Jun 2025 20:28:58 -0400 Subject: [PATCH 07/19] set margin for productTrainingTooltipText --- src/components/ProductTrainingContext/index.tsx | 4 ++-- src/styles/index.ts | 1 + src/styles/utils/sizing.ts | 4 ---- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/components/ProductTrainingContext/index.tsx b/src/components/ProductTrainingContext/index.tsx index 6e1ad7c02963..9a8f9cc38094 100644 --- a/src/components/ProductTrainingContext/index.tsx +++ b/src/components/ProductTrainingContext/index.tsx @@ -285,7 +285,7 @@ const useProductTrainingContext = (tooltipName: ProductTrainingTooltipName, shou fill={theme.tooltipHighlightText} medium /> - + {tooltip.content.map(({text, isBold}) => { const translatedText = translate(text); return ( @@ -359,7 +359,7 @@ const useProductTrainingContext = (tooltipName: ProductTrainingTooltipName, shou styles.ph1, styles.productTrainingTooltipText, styles.textWrap, - styles.mw95, + styles.mw100, styles.flex1, styles.justifyContentBetween, styles.ph2, diff --git a/src/styles/index.ts b/src/styles/index.ts index 546276a20006..a55cd42b72f8 100644 --- a/src/styles/index.ts +++ b/src/styles/index.ts @@ -4201,6 +4201,7 @@ const styles = (theme: ThemeColors) => fontSize: variables.fontSizeLabel, color: theme.textReversed, lineHeight: variables.lineHeightLarge, + marginRight: 20 }, quickReactionsContainer: { diff --git a/src/styles/utils/sizing.ts b/src/styles/utils/sizing.ts index daa2a841af9e..a73667951a5c 100644 --- a/src/styles/utils/sizing.ts +++ b/src/styles/utils/sizing.ts @@ -135,10 +135,6 @@ export default { maxWidth: '75%', }, - mw95: { - maxWidth: '95%', - }, - mw100: { maxWidth: '100%', }, From e2d91708b379c9549bcc311cc5518a8e96b6b1d2 Mon Sep 17 00:00:00 2001 From: David Gelhar Date: Mon, 2 Jun 2025 15:30:52 -0400 Subject: [PATCH 08/19] whitespace in expression Co-authored-by: Eugene Voloshchak --- src/components/Tooltip/GenericTooltip.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/Tooltip/GenericTooltip.tsx b/src/components/Tooltip/GenericTooltip.tsx index d64752a53fa7..63e9d0b52dce 100644 --- a/src/components/Tooltip/GenericTooltip.tsx +++ b/src/components/Tooltip/GenericTooltip.tsx @@ -20,7 +20,7 @@ import type {GenericTooltipProps} from './types'; function GenericTooltip({ children, numberOfLines = CONST.TOOLTIP_MAX_LINES, - maxWidth = variables.sideBarWidth - 2*variables.tooltipMargin, + maxWidth = variables.sideBarWidth - 2 * variables.tooltipMargin, text = '', renderTooltipContent, renderTooltipContentKey = [], From bde9faf126d1d9bdd022891ee3ff5e04013b29d5 Mon Sep 17 00:00:00 2001 From: "David E. Gelhar" Date: Mon, 2 Jun 2025 15:33:25 -0400 Subject: [PATCH 09/19] use variables.tooltipMargin instead of magic number --- src/styles/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/styles/index.ts b/src/styles/index.ts index a55cd42b72f8..a159f9e54b25 100644 --- a/src/styles/index.ts +++ b/src/styles/index.ts @@ -4201,7 +4201,7 @@ const styles = (theme: ThemeColors) => fontSize: variables.fontSizeLabel, color: theme.textReversed, lineHeight: variables.lineHeightLarge, - marginRight: 20 + marginRight: variables.tooltipMargin }, quickReactionsContainer: { From bae21e7f03cd42177c50f044903383b9b8258dd8 Mon Sep 17 00:00:00 2001 From: "David E. Gelhar" Date: Mon, 2 Jun 2025 15:35:36 -0400 Subject: [PATCH 10/19] prettier --- src/styles/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/styles/index.ts b/src/styles/index.ts index a159f9e54b25..b1b84311c8f5 100644 --- a/src/styles/index.ts +++ b/src/styles/index.ts @@ -4201,7 +4201,7 @@ const styles = (theme: ThemeColors) => fontSize: variables.fontSizeLabel, color: theme.textReversed, lineHeight: variables.lineHeightLarge, - marginRight: variables.tooltipMargin + marginRight: variables.tooltipMargin, }, quickReactionsContainer: { From 81be9d1a5a5e9d71dd7debdf08dccfd97b13287b Mon Sep 17 00:00:00 2001 From: "David E. Gelhar" Date: Tue, 10 Jun 2025 07:09:24 -0400 Subject: [PATCH 11/19] use flexShrink to keep tooltip text within parent container --- src/styles/index.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/styles/index.ts b/src/styles/index.ts index b1b84311c8f5..f19d3b7e8847 100644 --- a/src/styles/index.ts +++ b/src/styles/index.ts @@ -4201,9 +4201,9 @@ const styles = (theme: ThemeColors) => fontSize: variables.fontSizeLabel, color: theme.textReversed, lineHeight: variables.lineHeightLarge, - marginRight: variables.tooltipMargin, + flexShrink: 1, }, - + quickReactionsContainer: { gap: 12, flexDirection: 'row', From 01634ae3446c85eb32de5a025406ddec4bb6354e Mon Sep 17 00:00:00 2001 From: "David E. Gelhar" Date: Tue, 10 Jun 2025 07:13:49 -0400 Subject: [PATCH 12/19] prettier --- src/styles/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/styles/index.ts b/src/styles/index.ts index f19d3b7e8847..a65302ca965e 100644 --- a/src/styles/index.ts +++ b/src/styles/index.ts @@ -4203,7 +4203,7 @@ const styles = (theme: ThemeColors) => lineHeight: variables.lineHeightLarge, flexShrink: 1, }, - + quickReactionsContainer: { gap: 12, flexDirection: 'row', From 16db907a915bad3946a7e57df9a0f397cdd30289 Mon Sep 17 00:00:00 2001 From: "David E. Gelhar" Date: Tue, 10 Jun 2025 13:21:19 -0400 Subject: [PATCH 13/19] make button padding match text --- src/components/ProductTrainingContext/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/ProductTrainingContext/index.tsx b/src/components/ProductTrainingContext/index.tsx index 9a8f9cc38094..a0c2d0a8ba72 100644 --- a/src/components/ProductTrainingContext/index.tsx +++ b/src/components/ProductTrainingContext/index.tsx @@ -331,7 +331,7 @@ const useProductTrainingContext = (tooltipName: ProductTrainingTooltipName, shou )} {!!tooltip?.shouldRenderActionButtons && ( - +