From e0e9418b15b7cff8ab8c9971aab468d838118418 Mon Sep 17 00:00:00 2001 From: apeyada Date: Tue, 18 Nov 2025 09:31:45 +0100 Subject: [PATCH 01/13] remove imports --- src/components/Icon/Expensicons.ts | 46 ------------------------------ 1 file changed, 46 deletions(-) diff --git a/src/components/Icon/Expensicons.ts b/src/components/Icon/Expensicons.ts index 1a885a21901c..54f4b8148c5a 100644 --- a/src/components/Icon/Expensicons.ts +++ b/src/components/Icon/Expensicons.ts @@ -1,23 +1,6 @@ -import AddReaction from '@assets/images/add-reaction.svg'; -import All from '@assets/images/all.svg'; import Android from '@assets/images/android.svg'; import Apple from '@assets/images/apple.svg'; -import ArrowCircleClockwise from '@assets/images/arrow-circle-clockwise.svg'; -import ArrowCollapse from '@assets/images/arrow-collapse.svg'; -import ArrowDownLong from '@assets/images/arrow-down-long.svg'; -import ArrowRightLong from '@assets/images/arrow-right-long.svg'; -import ArrowRight from '@assets/images/arrow-right.svg'; -import ArrowSplit from '@assets/images/arrow-split.svg'; -import ArrowUpLong from '@assets/images/arrow-up-long.svg'; -import UpArrow from '@assets/images/arrow-up.svg'; -import ArrowsLeftRight from '@assets/images/arrows-leftright.svg'; import AttachmentNotFound from '@assets/images/attachment-not-found.svg'; -import ConciergeAvatar from '@assets/images/avatars/concierge-avatar.svg'; -import FallbackAvatar from '@assets/images/avatars/fallback-avatar.svg'; -import FallbackWorkspaceAvatar from '@assets/images/avatars/fallback-workspace-avatar.svg'; -import NotificationsAvatar from '@assets/images/avatars/notifications-avatar.svg'; -import ActiveRoomAvatar from '@assets/images/avatars/room.svg'; -import BackArrow from '@assets/images/back-left.svg'; import Bank from '@assets/images/bank.svg'; import Bed from '@assets/images/bed.svg'; import Bell from '@assets/images/bell.svg'; @@ -35,7 +18,6 @@ import Calendar from '@assets/images/calendar.svg'; import Camera from '@assets/images/camera.svg'; import CarWithKey from '@assets/images/car-with-key.svg'; import Car from '@assets/images/car.svg'; -import CaretUpDown from '@assets/images/caret-up-down.svg'; import Cash from '@assets/images/cash.svg'; import ChatBubbleCounter from '@assets/images/chatbubble-counter.svg'; import ChatBubbleReply from '@assets/images/chatbubble-reply.svg'; @@ -47,11 +29,9 @@ import CheckSquare from '@assets/images/check-square.svg'; import Checkbox from '@assets/images/checkbox.svg'; import CheckmarkCircle from '@assets/images/checkmark-circle.svg'; import Checkmark from '@assets/images/checkmark.svg'; -import CircularArrowBackwards from '@assets/images/circular-arrow-backwards.svg'; import Close from '@assets/images/close.svg'; import ClosedSign from '@assets/images/closed-sign.svg'; import Coins from '@assets/images/coins.svg'; -import Collapse from '@assets/images/collapse.svg'; import CommentBubbles from '@assets/images/comment-bubbles.svg'; import Concierge from '@assets/images/concierge.svg'; import Connect from '@assets/images/connect.svg'; @@ -65,7 +45,6 @@ import DocumentMerge from '@assets/images/document-merge.svg'; import Document from '@assets/images/document.svg'; import DotIndicatorUnfilled from '@assets/images/dot-indicator-unfilled.svg'; import DotIndicator from '@assets/images/dot-indicator.svg'; -import DownArrow from '@assets/images/down.svg'; import Download from '@assets/images/download.svg'; import DragAndDrop from '@assets/images/drag-and-drop.svg'; import DragHandles from '@assets/images/drag-handles.svg'; @@ -76,7 +55,6 @@ import EmptyStateSpyPigeon from '@assets/images/emptystate__spy-pigeon.svg'; import EReceiptIcon from '@assets/images/eReceiptIcon.svg'; import Exclamation from '@assets/images/exclamation.svg'; import Exit from '@assets/images/exit.svg'; -import Expand from '@assets/images/expand.svg'; import ExpensifyAppIcon from '@assets/images/expensify-app-icon.svg'; import ExpensifyCard from '@assets/images/expensify-card-icon.svg'; import ExpensifyFooterLogoVertical from '@assets/images/expensify-footer-logo-vertical.svg'; @@ -201,7 +179,6 @@ import Table from '@assets/images/table.svg'; import Tag from '@assets/images/tag.svg'; import Task from '@assets/images/task.svg'; import Thread from '@assets/images/thread.svg'; -import ThreeDots from '@assets/images/three-dots.svg'; import ThumbsDown from '@assets/images/thumbs-down.svg'; import ThumbsUp from '@assets/images/thumbs-up.svg'; import Train from '@assets/images/train.svg'; @@ -228,23 +205,11 @@ import Zoom from '@assets/images/zoom.svg'; export { ReceiptBody, - ActiveRoomAvatar, - AddReaction, - All, Android, Apple, AppleLogo, - ArrowSplit, - ArrowCollapse, - ArrowRight, - ArrowRightLong, - ArrowsLeftRight, - ArrowUpLong, - ArrowDownLong, AttachmentNotFound, - BackArrow, Bank, - CircularArrowBackwards, Bill, Bell, Binoculars, @@ -263,10 +228,8 @@ export { Checkmark, Close, ClosedSign, - Collapse, CommentBubbles, Concierge, - ConciergeAvatar, Connect, Crosshair, ConnectionComplete, @@ -279,7 +242,6 @@ export { DocumentMerge, DotIndicator, DotIndicatorUnfilled, - DownArrow, Download, DragAndDrop, DragHandles, @@ -293,12 +255,9 @@ export { ExpensifyWordmark, ExpensifyFooterLogo, ExpensifyFooterLogoVertical, - Expand, Export, Eye, EyeDisabled, - FallbackAvatar, - FallbackWorkspaceAvatar, Flag, FlagLevelOne, FlagLevelTwo, @@ -349,7 +308,6 @@ export { ExpensifyLogoNew, NewWindow, NewWorkspace, - NotificationsAvatar, Offline, OfflineCloud, Paperclip, @@ -384,12 +342,10 @@ export { Sync, Task, ThumbsUp, - ThreeDots, Transfer, Trashcan, Uber, Unlock, - UpArrow, Upload, UploadAlt, User, @@ -430,7 +386,6 @@ export { CalendarSolid, Filter, UserEye, - CaretUpDown, UserPlus, Feed, Table, @@ -452,6 +407,5 @@ export { QBOExport, SageIntacctExport, XeroExport, - ArrowCircleClockwise, PlusCircle, }; From cf4393c424c648ee58622857a907fc2ed0a50f67 Mon Sep 17 00:00:00 2001 From: apeyada Date: Tue, 18 Nov 2025 12:30:26 +0100 Subject: [PATCH 02/13] useMemoizedLazyExpensifyIcons --- src/components/AccountSwitcher.tsx | 4 ++- src/components/AnimatedCollapsible/index.tsx | 5 +-- src/components/ApprovalWorkflowSection.tsx | 4 ++- .../AttachmentCarousel/CarouselButtons.tsx | 7 ++-- .../Attachments/AttachmentView/index.tsx | 7 ++-- src/components/Avatar.tsx | 11 +++--- src/components/AvatarButtonWithIcon.tsx | 6 ++-- src/components/AvatarWithImagePicker.tsx | 6 ++-- src/components/AvatarWithIndicator.tsx | 7 ++-- src/components/BigNumberPad.tsx | 5 +-- src/components/Button/index.tsx | 9 ++--- .../ButtonWithDropdownMenu/index.tsx | 7 ++-- src/components/CaretWrapper.tsx | 5 +-- src/components/CollapsibleSection/index.tsx | 5 +-- .../DatePicker/CalendarPicker/ArrowIcon.tsx | 5 +-- src/components/Domain/DomainMenuItem.tsx | 4 ++- .../EmojiPicker/EmojiPickerButtonDropdown.tsx | 4 ++- .../HTMLRenderers/DeletedActionRenderer.tsx | 5 ++- src/components/HeaderWithBackButton/index.tsx | 4 ++- src/components/MenuItem.tsx | 14 ++++---- src/components/MoneyReportHeader.tsx | 16 ++++----- src/components/MoneyRequestHeader.tsx | 6 ++-- src/components/NumberWithSymbolForm.tsx | 6 ++-- src/components/Picker/BasePicker.tsx | 5 +-- src/components/PopoverMenu.tsx | 5 +-- src/components/PrevNextButtons.tsx | 7 ++-- .../Reactions/AddReactionBubble.tsx | 5 +-- .../Reactions/MiniQuickEmojiReactions.tsx | 5 +-- .../MoneyRequestReportPreviewContent.tsx | 6 ++-- .../ReportActionItem/TaskPreview.tsx | 7 ++-- src/components/ReportActionItem/TaskView.tsx | 5 +-- .../ReportActionItem/TripDetailsView.tsx | 5 +-- src/components/ReportHeaderSkeletonView.tsx | 6 ++-- src/components/RoomHeaderAvatars.tsx | 7 ++-- .../SelectionList/ListItem/UserListItem.tsx | 4 ++- .../BaseListItem.tsx | 4 ++- .../ListItemRightCaretWithLabel.tsx | 5 +-- .../Search/CardListItemHeader.tsx | 6 ++-- .../Search/MemberListItemHeader.tsx | 5 +-- .../Search/ReportListItemHeader.tsx | 5 +-- .../Search/TaskListItemRow.tsx | 5 ++- .../Search/UserInfoCellsWithArrow.tsx | 6 ++-- .../Search/WithdrawalIDListItemHeader.tsx | 6 ++-- .../SortableHeaderText.tsx | 5 +-- .../SplitListItem.tsx | 5 +-- .../UserListItem.tsx | 4 ++- .../SidePanel/HelpComponents/HelpHeader.tsx | 4 ++- src/components/SymbolButton.tsx | 6 ++-- src/components/TransactionItemRow/index.tsx | 5 +-- .../VideoPlayer/VideoPlayerControls/index.tsx | 5 ++- src/components/VideoPlayerPreview/index.tsx | 5 +-- src/hooks/useSelectedTransactionsActions.ts | 7 ++-- src/hooks/useWorkspaceConfirmationAvatar.tsx | 7 ++-- src/hooks/useWorkspaceList.ts | 8 +++-- src/pages/NewReportWorkspaceSelectionPage.tsx | 7 ++-- .../BaseOnboardingWorkspaces.tsx | 7 ++-- src/pages/Search/SearchPage.tsx | 8 +++-- src/pages/ShareCodePage.tsx | 4 ++- src/pages/Travel/CarTripDetails.tsx | 5 +-- src/pages/Travel/FlightTripDetails.tsx | 4 ++- src/pages/Travel/HotelTripDetails.tsx | 5 +-- src/pages/Travel/TrainTripDetails.tsx | 5 +-- .../home/report/FloatingMessageCounter.tsx | 5 +-- .../AttachmentPickerWithMenuItems.tsx | 6 ++-- .../ReportActionCompose/SuggestionMention.tsx | 5 ++- src/pages/iou/SplitExpensePage.tsx | 4 ++- .../step/IOURequestStepPerDiemWorkspace.tsx | 7 ++-- .../ReceiptPreviews/index.tsx | 5 +-- .../request/step/IOURequestStepSendFrom.tsx | 7 ++-- src/pages/settings/AboutPage/ConsolePage.tsx | 6 ++-- .../Profile/CustomStatus/StatusPage.tsx | 4 ++- .../CustomStatus/VacationDelegatePage.tsx | 5 +-- .../Security/SecuritySettingsPage.tsx | 4 ++- .../workspace/WorkspaceOverviewSharePage.tsx | 4 ++- src/pages/workspace/WorkspacesListPage.tsx | 8 +++-- src/pages/workspace/WorkspacesListRow.tsx | 4 ++- .../accounting/PolicyAccountingPage.tsx | 34 +++++++++++++------ .../WorkspaceCompanyCardsListRow.tsx | 5 +-- .../companyCards/assignCard/AssigneeStep.tsx | 4 ++- .../expensifyCard/WorkspaceCardListRow.tsx | 4 ++- .../expensifyCard/issueNew/AssigneeStep.tsx | 7 ++-- .../ChangeReceiptBillingAccountPage.tsx | 7 ++-- .../EditInviteReceiptPartnerPolicyPage.tsx | 4 ++- .../InviteReceiptPartnerPolicyPage.tsx | 7 ++-- ...orkflowsConnectExistingBankAccountPage.tsx | 5 +-- 85 files changed, 331 insertions(+), 187 deletions(-) diff --git a/src/components/AccountSwitcher.tsx b/src/components/AccountSwitcher.tsx index a22fb01ca7d5..61c93e4e93a4 100644 --- a/src/components/AccountSwitcher.tsx +++ b/src/components/AccountSwitcher.tsx @@ -3,6 +3,7 @@ import {Str} from 'expensify-common'; import React, {useRef, useState} from 'react'; import {View} from 'react-native'; import useCurrentUserPersonalDetails from '@hooks/useCurrentUserPersonalDetails'; +import {useMemoizedLazyExpensifyIcons} from '@hooks/useLazyAsset'; import useLocalize from '@hooks/useLocalize'; import useNetwork from '@hooks/useNetwork'; import useOnyx from '@hooks/useOnyx'; @@ -55,6 +56,7 @@ function AccountSwitcher({isScreenFocused}: AccountSwitcherProps) { const buttonRef = useRef(null); const {windowHeight} = useWindowDimensions(); + const expensifyIcons = useMemoizedLazyExpensifyIcons(['CaretUpDown'] as const); const [shouldShowDelegatorMenu, setShouldShowDelegatorMenu] = useState(false); const [shouldShowOfflineModal, setShouldShowOfflineModal] = useState(false); @@ -219,7 +221,7 @@ function AccountSwitcher({isScreenFocused}: AccountSwitcherProps) { diff --git a/src/components/AnimatedCollapsible/index.tsx b/src/components/AnimatedCollapsible/index.tsx index 83290d66ac5e..5ccad9e54a31 100644 --- a/src/components/AnimatedCollapsible/index.tsx +++ b/src/components/AnimatedCollapsible/index.tsx @@ -5,9 +5,9 @@ import type {StyleProp, ViewStyle} from 'react-native'; import Animated, {useAnimatedStyle, useDerivedValue, useSharedValue, withTiming} from 'react-native-reanimated'; import {scheduleOnRN} from 'react-native-worklets'; import Icon from '@components/Icon'; -import * as Expensicons from '@components/Icon/Expensicons'; import {easing} from '@components/Modal/ReanimatedModal/utils'; import {PressableWithFeedback} from '@components/Pressable'; +import {useMemoizedLazyExpensifyIcons} from '@hooks/useLazyAsset'; import useTheme from '@hooks/useTheme'; import useThemeStyles from '@hooks/useThemeStyles'; import CONST from '@src/CONST'; @@ -69,6 +69,7 @@ function AnimatedCollapsible({ const contentHeight = useSharedValue(0); const hasExpanded = useSharedValue(isExpanded); const [isRendered, setIsRendered] = React.useState(isExpanded); + const expensifyIcons = useMemoizedLazyExpensifyIcons(['DownArrow', 'UpArrow'] as const); useEffect(() => { hasExpanded.set(isExpanded); @@ -121,7 +122,7 @@ function AnimatedCollapsible({ > {({hovered}) => ( @@ -104,7 +106,7 @@ function ApprovalWorkflowSection({approvalWorkflow, onPress}: ApprovalWorkflowSe ))} diff --git a/src/components/Attachments/AttachmentCarousel/CarouselButtons.tsx b/src/components/Attachments/AttachmentCarousel/CarouselButtons.tsx index 04fd1163af44..e8a685f9f280 100644 --- a/src/components/Attachments/AttachmentCarousel/CarouselButtons.tsx +++ b/src/components/Attachments/AttachmentCarousel/CarouselButtons.tsx @@ -2,8 +2,8 @@ import React from 'react'; import {View} from 'react-native'; import type {Attachment} from '@components/Attachments/types'; import Button from '@components/Button'; -import * as Expensicons from '@components/Icon/Expensicons'; import Tooltip from '@components/Tooltip'; +import {useMemoizedLazyExpensifyIcons} from '@hooks/useLazyAsset'; import useLocalize from '@hooks/useLocalize'; import useResponsiveLayout from '@hooks/useResponsiveLayout'; import useTheme from '@hooks/useTheme'; @@ -39,6 +39,7 @@ function CarouselButtons({page, attachments, shouldShowArrows, onBack, onForward const isForwardDisabled = page === attachments.length - 1; const {translate} = useLocalize(); const {shouldUseNarrowLayout} = useResponsiveLayout(); + const expensifyIcons = useMemoizedLazyExpensifyIcons(['ArrowRight'] as const); return shouldShowArrows ? ( <> @@ -48,7 +49,7 @@ function CarouselButtons({page, attachments, shouldShowArrows, onBack, onForward