diff --git a/src/libs/CardUtils.ts b/src/libs/CardUtils.ts index 8cfa1b36d7dc..192243ad5373 100644 --- a/src/libs/CardUtils.ts +++ b/src/libs/CardUtils.ts @@ -1458,16 +1458,18 @@ function getDisplayableExpensifyCards(cardList: CardList | undefined): Card[] { } const activeCards = filterAllInactiveCards(cardList); - const activeExpensifyCards = Object.values(activeCards).filter((card) => isExpensifyCard(card) && !isExpiredCard(card) && card.cardName !== CONST.COMPANY_CARDS.CARD_NAME.CASH); + const activeExpensifyCards = Object.values(activeCards).filter( + (card) => isExpensifyCard(card) && !isExpiredCard(card) && card.cardName !== CONST.COMPANY_CARDS.CARD_NAME.CASH && !isTravelCard(card), + ); const sortedCards = lodashSortBy(activeExpensifyCards, getAssignedCardSortKey); const seenDomains = new Set(); return sortedCards.filter((card) => { const isAdminIssuedVirtualCard = !!card.nameValuePairs?.issuedBy && !!card.nameValuePairs?.isVirtual; - const isComboCard = !!card.domainName && !isAdminIssuedVirtualCard && !isTravelCard(card); + const isComboCard = !!card.domainName && !isAdminIssuedVirtualCard; - // Always show non-combo cards (admin-issued virtual, travel cards, or cards without domain) + // Always show non-combo cards (admin-issued virtual or cards without domain) if (!isComboCard) { return true; } diff --git a/tests/unit/CardUtilsTest.ts b/tests/unit/CardUtilsTest.ts index 6504908c1ff4..f7b5750484fa 100644 --- a/tests/unit/CardUtilsTest.ts +++ b/tests/unit/CardUtilsTest.ts @@ -2466,7 +2466,7 @@ describe('CardUtils', () => { expect(result).toHaveLength(2); // Both cards shown (admin-issued virtual is not grouped) }); - it('should show travel cards separately', () => { + it('should exclude travel cards', () => { const cardList = { 1: { accountID: 10160771, @@ -2503,7 +2503,8 @@ describe('CardUtils', () => { }, } as unknown as CardList; const result = getDisplayableExpensifyCards(cardList); - expect(result).toHaveLength(2); // Both cards shown (travel card is not grouped) + expect(result).toHaveLength(1); + expect(result.at(0)?.cardID).toBe(18468850); }); it('should show cards from different domains separately', () => {