Skip to content

feat: land shared rules, modern desktop UI and offline Windows baseline - #55

Merged
HemSoft merged 6 commits into
mainfrom
chore/mission-baseline-20260927
Sep 27, 2026
Merged

HemSoft merged 6 commits into
mainfrom
chore/mission-baseline-20260927

Conversation

@HemSoft

@HemSoft HemSoft commented Sep 27, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Land the previously requested desktop/web redesign, shared scoring updates, and portable offline Windows edition. This establishes the shared-engine baseline needed by #40 while preserving the existing online clients. It does not implement or release the iOS app.

Acceptance criteria

  • Shared desktop/web setup, play and results with responsive scorecards, held-die states, themes and local licensed fonts.
  • Full Straight scores 50, larger-game bonus thresholds are gentler, score suggestions prefer made combinations, and combination display order matches the agreed rules.
  • Portable Windows edition shares the engine, saves completed results locally, handles failed writes without rerolling or duplicating completion, and makes no network requests.
  • Online authorization, revisions, expiry and verified-result handling remain server-side. Native mobile behavior is unchanged.
  • Preserve earlier work deliberately and qualify it on the current dependency baseline.

Definition of done

This is the inherited baseline integration from #40, not completion of that issue. Public iOS identity, native configuration, durable mobile resume, device qualification, and App Store approval remain open in #38 and its children. No signing, deployment, release upload or legal declaration is part of this PR.

Validation

Head 5babbc506717a19dffcaf5871b85a5065142e2f2, Windows, Node 24.12.0 and declared Bun 1.4.2 through npx --package bun@1.4.2.

  • Frozen install, bun run typecheck, bun run lint, bun run test and bun run security pass. 184 tests, 976 assertions.
  • bun run quality:measure passes, including existing web, Electron and mobile-web-adapter journeys plus desktop/responsive design assertions. These are not native iOS tests.
  • bun run mutation:probe rejects the weakened assertion at the unchanged 95% gate. Full mutation qualification passes at 97.5207%. Its command now includes the new suggestion/offline tests; the initial omission produced a real 91.74% failure that was fixed rather than waived.
  • bun run package:offline and bun run test:offline pass. The actual portable EXE launches from a path with spaces, completes six/eight/ten-dice games with networking disabled, restarts with scores retained, and supports play-again and quit.
  • Current-head screenshots below come from tests/clients/design.spec.ts and the portable EXE smoke test. A recording captures the shared responsive design journey, not a native iOS device.

Setup, light appearance, 1440 by 1000:

Setup

Compact desktop, 944 by 685, six dice and two players. Grand total remains visible:

Compact desktop

Responsive web, dark appearance, 390-pixel viewport. Held states and full scorecard remain reachable:

Narrow dark web

Twenty dice and four players. This expanded scorecard intentionally scrolls:

Twenty dice

Portable EXE setup and saved results:

Offline setup

Offline results

video.webm

Hosted Windows initially exposed a real 655-pixel usable-height overflow. The new regression fails before the fix and passes afterward. Both setup, including recent names, and active gameplay now have explicit 934-by-655 regressions. Compact panel/header and setup-form spacing now fits without shrinking score buttons or hiding overflow. The complete client, packaging, portable EXE and recording checks were repeated on this head.

Risks and deferred work

The Windows EXE is unsigned and may trigger SmartScreen. Windows closing/quitting abandons an active game; only completed results persist. Native mobile resume is separate work in #41. The existing game name is not cleared for public distribution; #39 remains a release blocker. The MIT license does not grant third-party trademark rights. No claim of App Store readiness is made.

Scoring-version compatibility

Verified historical totals stay in their original partition. New sessions/results use rules version 2, and ranking, top-ten eviction and history queries partition before applying limits. Historical results remain accessible with the explicit version-1 selector. The additive schema requires no data rewrite. Old active sessions reject without writes and ask the player to start again. See deployment and rollback guidance. No production data was changed or deployment performed. Regression tests cover separate history/rankings, preserved historical rows, versioned results and pre-upgrade session rejection.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-27T20:19:26.114885Z 5babbc5 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@HemSoft

HemSoft commented Sep 27, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: d794715c9c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@HemSoft

HemSoft commented Sep 27, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 3cbe587382

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@HemSoft

HemSoft commented Sep 27, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

https://github.com/HemSoft/yahtzee/blob/d9074e02cbd9ec0bbe4dec2121d7ed8b19c3aae7/packages/game-engine/src/scoring.ts#L227-L231
P1 Badge Version leaderboards when changing scoring rules

When this is deployed over existing Convex data, verified highScores.score and gameLogs.players.score remain totals calculated under the old rules, while new results use the lower bonus thresholds and 50-point Full Straight. Since highScores.top ranks all verified rows solely by dice count and score, old and new games will compete on different point scales and history averages will also mix incompatible totals. Migrate/recalculate stored results where possible, or add a rules version and partition rankings/history by it before enabling these scoring changes.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@HemSoft

HemSoft commented Sep 27, 2026

Copy link
Copy Markdown
Collaborator Author

Addressed the persisted-score finding on e5fd65d. Additive version fields and indexes isolate historical rankings/history and prevent new top-ten eviction from deleting old-rule results. Old active sessions reject without writes rather than silently mixing rules. Backend regressions, full quality measurement, refreshed local Convex bindings and portable qualification pass. No production migration or deployment was run. Current-head screenshots and recording were recaptured and replaced in Validation.

@HemSoft

HemSoft commented Sep 27, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: e5fd65d574

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@HemSoft
HemSoft force-pushed the chore/mission-baseline-20260927 branch from e5fd65d to 5babbc5 Compare September 27, 2026 20:12
@HemSoft

HemSoft commented Sep 27, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 5babbc5067

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@HemSoft
HemSoft merged commit 6f62024 into main Sep 27, 2026
6 checks passed
@HemSoft
HemSoft deleted the chore/mission-baseline-20260927 branch September 27, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant