From ff792d4a415a9c2afe5f4104c93f14d834399b5d Mon Sep 17 00:00:00 2001 From: Tim van der Lippe Date: Wed, 29 Oct 2025 12:03:36 +0100 Subject: [PATCH 1/4] Beheer: voeg extra testcase toe voor servers die missen We hadden die al wel, maar dat was een testcase waar de array empty is. Nu is er ook een testcase wanneer die volledig mist. Part of #208 --- .../servers-empty/expected-output.txt | 5 ++ linter/testcases/servers-empty/openapi.json | 76 +++++++++++++++++++ .../servers-missing/expected-output.txt | 2 +- linter/testcases/servers-missing/openapi.json | 1 - 4 files changed, 82 insertions(+), 2 deletions(-) create mode 100644 linter/testcases/servers-empty/expected-output.txt create mode 100644 linter/testcases/servers-empty/openapi.json diff --git a/linter/testcases/servers-empty/expected-output.txt b/linter/testcases/servers-empty/expected-output.txt new file mode 100644 index 00000000..fa5944d5 --- /dev/null +++ b/linter/testcases/servers-empty/expected-output.txt @@ -0,0 +1,5 @@ + +/testcases/servers-missing/openapi.json + 13:15 error oas3-api-servers OpenAPI "servers" must be present and non-empty array. servers + +✖ 1 problem (1 error, 0 warnings, 0 infos, 0 hints) diff --git a/linter/testcases/servers-empty/openapi.json b/linter/testcases/servers-empty/openapi.json new file mode 100644 index 00000000..5616e113 --- /dev/null +++ b/linter/testcases/servers-empty/openapi.json @@ -0,0 +1,76 @@ +{ + "openapi": "3.0.3", + "info": { + "title": "Baseline", + "description": "Deze OpenAPI specification bevat het minimale om aan alle regels te voldoen.", + "contact": { + "name": "Beheerder", + "url": "https://www.example.com", + "email": "mail@example.com" + }, + "version": "1.0.0" + }, + "servers": [], + "security": [ + { + "default": [] + } + ], + "tags": [ + { + "name": "openapi" + } + ], + "paths": { + "/openapi.json": { + "get": { + "tags": [ + "openapi" + ], + "description": "OpenAPI document", + "operationId": "getOpenapiJSON", + "parameters": [], + "responses": { + "200": { + "description": "OK", + "headers": { + "API-Version": { + "description": "De huidige versie van de applicatie", + "style": "simple", + "schema": { + "type": "string" + } + }, + "access-control-allow-origin": { + "description": "Alle origins mogen bij deze resource", + "schema": { + "type": "string" + } + } + } + } + }, + "security": [ + { + "default": [] + } + ] + } + } + }, + "components": { + "schemas": { + }, + "securitySchemes": { + "default": { + "type": "oauth2", + "flows": { + "implicit": { + "authorizationUrl": "https://test.com", + "scopes": {} + } + } + } + } + } +} \ No newline at end of file diff --git a/linter/testcases/servers-missing/expected-output.txt b/linter/testcases/servers-missing/expected-output.txt index 224036f0..f5a3e2cb 100644 --- a/linter/testcases/servers-missing/expected-output.txt +++ b/linter/testcases/servers-missing/expected-output.txt @@ -1,5 +1,5 @@ /testcases/servers-missing/openapi.json - 13:15 error oas3-api-servers OpenAPI "servers" must be present and non-empty array. servers + 12:15 error oas3-api-servers OpenAPI "servers" must be present and non-empty array. servers ✖ 1 problem (1 error, 0 warnings, 0 infos, 0 hints) diff --git a/linter/testcases/servers-missing/openapi.json b/linter/testcases/servers-missing/openapi.json index ed9d662f..5676b64e 100644 --- a/linter/testcases/servers-missing/openapi.json +++ b/linter/testcases/servers-missing/openapi.json @@ -10,7 +10,6 @@ }, "version": "1.0.0" }, - "servers": [], "security": [ { "default": [] From bf33808538f482ead13cf15e0c52401d71ef65e2 Mon Sep 17 00:00:00 2001 From: Tim van der Lippe Date: Wed, 29 Oct 2025 12:05:15 +0100 Subject: [PATCH 2/4] Fix error output --- linter/testcases/servers-empty/expected-output.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linter/testcases/servers-empty/expected-output.txt b/linter/testcases/servers-empty/expected-output.txt index fa5944d5..68a9cf9f 100644 --- a/linter/testcases/servers-empty/expected-output.txt +++ b/linter/testcases/servers-empty/expected-output.txt @@ -1,5 +1,5 @@ -/testcases/servers-missing/openapi.json +/testcases/servers-empty/openapi.json 13:15 error oas3-api-servers OpenAPI "servers" must be present and non-empty array. servers ✖ 1 problem (1 error, 0 warnings, 0 infos, 0 hints) From 09a550510310f0d53ff8104c86580991dbee628a Mon Sep 17 00:00:00 2001 From: Tim van der Lippe Date: Wed, 29 Oct 2025 12:07:18 +0100 Subject: [PATCH 3/4] Fix line endings --- .../servers-empty/expected-output.txt | 10 +- linter/testcases/servers-empty/openapi.json | 150 +++++++++--------- 2 files changed, 80 insertions(+), 80 deletions(-) diff --git a/linter/testcases/servers-empty/expected-output.txt b/linter/testcases/servers-empty/expected-output.txt index 68a9cf9f..866834c1 100644 --- a/linter/testcases/servers-empty/expected-output.txt +++ b/linter/testcases/servers-empty/expected-output.txt @@ -1,5 +1,5 @@ - -/testcases/servers-empty/openapi.json - 13:15 error oas3-api-servers OpenAPI "servers" must be present and non-empty array. servers - -✖ 1 problem (1 error, 0 warnings, 0 infos, 0 hints) + +/testcases/servers-empty/openapi.json + 13:15 error oas3-api-servers OpenAPI "servers" must be present and non-empty array. servers + +✖ 1 problem (1 error, 0 warnings, 0 infos, 0 hints) diff --git a/linter/testcases/servers-empty/openapi.json b/linter/testcases/servers-empty/openapi.json index 5616e113..ed9d662f 100644 --- a/linter/testcases/servers-empty/openapi.json +++ b/linter/testcases/servers-empty/openapi.json @@ -1,76 +1,76 @@ -{ - "openapi": "3.0.3", - "info": { - "title": "Baseline", - "description": "Deze OpenAPI specification bevat het minimale om aan alle regels te voldoen.", - "contact": { - "name": "Beheerder", - "url": "https://www.example.com", - "email": "mail@example.com" - }, - "version": "1.0.0" - }, - "servers": [], - "security": [ - { - "default": [] - } - ], - "tags": [ - { - "name": "openapi" - } - ], - "paths": { - "/openapi.json": { - "get": { - "tags": [ - "openapi" - ], - "description": "OpenAPI document", - "operationId": "getOpenapiJSON", - "parameters": [], - "responses": { - "200": { - "description": "OK", - "headers": { - "API-Version": { - "description": "De huidige versie van de applicatie", - "style": "simple", - "schema": { - "type": "string" - } - }, - "access-control-allow-origin": { - "description": "Alle origins mogen bij deze resource", - "schema": { - "type": "string" - } - } - } - } - }, - "security": [ - { - "default": [] - } - ] - } - } - }, - "components": { - "schemas": { - }, - "securitySchemes": { - "default": { - "type": "oauth2", - "flows": { - "implicit": { - "authorizationUrl": "https://test.com", - "scopes": {} - } - } - } - } - } +{ + "openapi": "3.0.3", + "info": { + "title": "Baseline", + "description": "Deze OpenAPI specification bevat het minimale om aan alle regels te voldoen.", + "contact": { + "name": "Beheerder", + "url": "https://www.example.com", + "email": "mail@example.com" + }, + "version": "1.0.0" + }, + "servers": [], + "security": [ + { + "default": [] + } + ], + "tags": [ + { + "name": "openapi" + } + ], + "paths": { + "/openapi.json": { + "get": { + "tags": [ + "openapi" + ], + "description": "OpenAPI document", + "operationId": "getOpenapiJSON", + "parameters": [], + "responses": { + "200": { + "description": "OK", + "headers": { + "API-Version": { + "description": "De huidige versie van de applicatie", + "style": "simple", + "schema": { + "type": "string" + } + }, + "access-control-allow-origin": { + "description": "Alle origins mogen bij deze resource", + "schema": { + "type": "string" + } + } + } + } + }, + "security": [ + { + "default": [] + } + ] + } + } + }, + "components": { + "schemas": { + }, + "securitySchemes": { + "default": { + "type": "oauth2", + "flows": { + "implicit": { + "authorizationUrl": "https://test.com", + "scopes": {} + } + } + } + } + } } \ No newline at end of file From d893d6555a645ea59677adc4885fb1bd31915b7a Mon Sep 17 00:00:00 2001 From: Tim van der Lippe Date: Wed, 29 Oct 2025 12:09:49 +0100 Subject: [PATCH 4/4] Fix error output --- linter/testcases/servers-missing/expected-output.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linter/testcases/servers-missing/expected-output.txt b/linter/testcases/servers-missing/expected-output.txt index f5a3e2cb..3ffa138d 100644 --- a/linter/testcases/servers-missing/expected-output.txt +++ b/linter/testcases/servers-missing/expected-output.txt @@ -1,5 +1,5 @@ /testcases/servers-missing/openapi.json - 12:15 error oas3-api-servers OpenAPI "servers" must be present and non-empty array. servers + 1:1 error oas3-api-servers OpenAPI "servers" must be present and non-empty array. ✖ 1 problem (1 error, 0 warnings, 0 infos, 0 hints)