From 404ac53648db289145169a75a6ee32b1e6b7c16a Mon Sep 17 00:00:00 2001 From: Satya Patel Date: Fri, 25 Sep 2026 23:28:03 -0700 Subject: [PATCH] A cloud workspace can read its environment's variable names, and a deploy CLI's token can be one An agent in a box could not tell which variables its environment gives it: every environment.secrets procedure sat outside the box credential's allowlist, the CLI hid the whole secrets group in a box, and the next bundle would have hidden `environments` itself, since nothing in a box sets the internal audience. - environment.secrets.list joins SANDBOX_ALLOWED_PROCEDURES; set and remove stay a person's call. - In a box the CLI shows `environments secrets list`; set and delete carry sandbox: false themselves. A box runs with the internal audience. - The reserved prefix narrows from VERCEL_ to VERCEL_SANDBOX_, the only family the provisioner uses, so VERCEL_TOKEN and VERCEL_ORG_ID can be environment variables for the vercel CLI. --- packages/cli/cli.config.ts | 3 ++- .../environments/secrets/delete/command.ts | 1 + .../src/commands/environments/secrets/meta.ts | 1 - .../environments/secrets/set/command.ts | 1 + .../shared/src/environment-secrets.test.ts | 18 ++++++++++++++++++ packages/shared/src/environment-secrets.ts | 2 +- .../trpc/src/lib/sandbox/api-credential.ts | 1 + 7 files changed, 24 insertions(+), 3 deletions(-) create mode 100644 packages/shared/src/environment-secrets.test.ts diff --git a/packages/cli/cli.config.ts b/packages/cli/cli.config.ts index 8ee8b025ab2..d349850eab1 100644 --- a/packages/cli/cli.config.ts +++ b/packages/cli/cli.config.ts @@ -24,7 +24,8 @@ export default defineConfig({ .desc("Use a Superset API key (sk_live_…) instead of OAuth login"), }, audiences: () => - process.env.SUPERSET_CLI_AUDIENCE === "internal" + process.env.SUPERSET_CLI_AUDIENCE === "internal" || + process.env.SUPERSET_SANDBOX_WORKSPACE_ID ? ["internal", "public"] : ["public"], sandbox: () => Boolean(process.env.SUPERSET_SANDBOX_WORKSPACE_ID), diff --git a/packages/cli/src/commands/environments/secrets/delete/command.ts b/packages/cli/src/commands/environments/secrets/delete/command.ts index a65128485de..fba7a90235b 100644 --- a/packages/cli/src/commands/environments/secrets/delete/command.ts +++ b/packages/cli/src/commands/environments/secrets/delete/command.ts @@ -3,6 +3,7 @@ import { command } from "../../../../lib/command"; import { resolveEnvironment } from "../../../../lib/environments"; export default command({ + sandbox: false, description: "Delete a variable from an environment", args: [positional("name").required().desc("Variable name")], options: { diff --git a/packages/cli/src/commands/environments/secrets/meta.ts b/packages/cli/src/commands/environments/secrets/meta.ts index 47fab6c5fb9..8b66dd10c77 100644 --- a/packages/cli/src/commands/environments/secrets/meta.ts +++ b/packages/cli/src/commands/environments/secrets/meta.ts @@ -1,4 +1,3 @@ export default { - sandbox: false, description: "Manage the variables an environment gives its cloud workspaces", }; diff --git a/packages/cli/src/commands/environments/secrets/set/command.ts b/packages/cli/src/commands/environments/secrets/set/command.ts index 3143e92f6f7..4a80415b6f3 100644 --- a/packages/cli/src/commands/environments/secrets/set/command.ts +++ b/packages/cli/src/commands/environments/secrets/set/command.ts @@ -14,6 +14,7 @@ async function readStdin(): Promise { } export default command({ + sandbox: false, description: "Set a variable on an environment, from --body, stdin, or a .env file", args: [ diff --git a/packages/shared/src/environment-secrets.test.ts b/packages/shared/src/environment-secrets.test.ts new file mode 100644 index 00000000000..15114bbefe4 --- /dev/null +++ b/packages/shared/src/environment-secrets.test.ts @@ -0,0 +1,18 @@ +import { describe, expect, test } from "bun:test"; +import { reservedKeyReason } from "./environment-secrets"; + +describe("reservedKeyReason", () => { + test("the provider's own credentials are reserved", () => { + expect(reservedKeyReason("VERCEL_SANDBOX_TOKEN")).toContain( + "VERCEL_SANDBOX_", + ); + expect(reservedKeyReason("SUPERSET_WORKSPACE_ID")).toContain("SUPERSET_"); + expect(reservedKeyReason("path")).toContain("PATH"); + }); + + test("a deploy CLI's token is an ordinary variable", () => { + expect(reservedKeyReason("VERCEL_TOKEN")).toBeNull(); + expect(reservedKeyReason("VERCEL_ORG_ID")).toBeNull(); + expect(reservedKeyReason("EXPO_TOKEN")).toBeNull(); + }); +}); diff --git a/packages/shared/src/environment-secrets.ts b/packages/shared/src/environment-secrets.ts index b16fa8d7d9e..af121684030 100644 --- a/packages/shared/src/environment-secrets.ts +++ b/packages/shared/src/environment-secrets.ts @@ -9,7 +9,7 @@ const RESERVED_PREFIXES: Array<{ prefix: string; reason: string }> = [ reason: "carries the workspace's identity into the sandbox", }, { prefix: "HOST_SERVICE_", reason: "configures the sandbox's own server" }, - { prefix: "VERCEL_", reason: "belongs to the sandbox provider" }, + { prefix: "VERCEL_SANDBOX_", reason: "provisions the box itself" }, ]; const RESERVED_KEYS = new Set([ diff --git a/packages/trpc/src/lib/sandbox/api-credential.ts b/packages/trpc/src/lib/sandbox/api-credential.ts index 7cab7d38223..7f87a582759 100644 --- a/packages/trpc/src/lib/sandbox/api-credential.ts +++ b/packages/trpc/src/lib/sandbox/api-credential.ts @@ -29,6 +29,7 @@ export const SANDBOX_ALLOWED_PROCEDURES: ReadonlySet = new Set([ "cloudWorkspace.access", "cloudWorkspace.hostTicket", "environment.list", + "environment.secrets.list", "page.assets.upload", "page.create", "page.get",