feat: add cloud storage support for session start - #3629
Merged
Conversation
Panaetius
force-pushed
the
feat/rclone-storage-commands
branch
from
September 28, 2023 13:46
1ab5953 to
79d6b3a
Compare
Collaborator
Pull Request Test Coverage Report for Build 7553200191
💛 - Coveralls |
Panaetius
force-pushed
the
feat/rclone-storage-commands
branch
2 times, most recently
from
September 28, 2023 14:13
b37e9e5 to
debdfd6
Compare
Panaetius
force-pushed
the
feat/rclone-storage-commands
branch
from
September 28, 2023 15:08
debdfd6 to
b4f137b
Compare
Panaetius
force-pushed
the
feat/rclone-storage-commands
branch
from
November 8, 2023 16:20
e22bc6d to
deb1302
Compare
Panaetius
force-pushed
the
feat/rclone-storage-commands
branch
from
November 9, 2023 15:13
deb1302 to
23553b6
Compare
Panaetius
marked this pull request as ready for review
November 10, 2023 08:46
Member
|
@Panaetius I started reviewing this. But I also wanted to try it out. So I made a project, added cloud storage and then cloned it locally. Then I ran |
olevski
requested changes
Nov 17, 2023
| ) | ||
|
|
||
| def get_cloudstorage(self): | ||
| """Get cloudstorage configured for the project.""" |
Member
There was a problem hiding this comment.
I did not know where to put this but I think we need a warning in the docker provider that if there is any cloud storage in the project it will not be mounted. We dont have to implement this but we should let people now what the limitations are.
| Raises an exception for invalid storage. | ||
| """ | ||
| self._send_request( | ||
| "/storage_schema/validate", body=storage.configuration, method="POST", expected_response=[204] |
Member
There was a problem hiding this comment.
Is the expected reponse for validate supposed to be really 204?
Member
Author
There was a problem hiding this comment.
yes when given a valid config it just returns an empty 204 and if invalid an appropriate 4xx code
olevski
reviewed
Nov 17, 2023
Panaetius
force-pushed
the
feat/rclone-storage-commands
branch
from
December 6, 2023 09:03
325d93b to
f3dd0d9
Compare
Panaetius
force-pushed
the
feat/rclone-storage-commands
branch
from
December 6, 2023 12:35
090c613 to
f407d5a
Compare
added 2 commits
December 7, 2023 12:04
…ienceCenter/renku-python into feat/rclone-storage-commands
Panaetius
force-pushed
the
feat/rclone-storage-commands
branch
from
December 7, 2023 14:29
8f46103 to
7abb677
Compare
olevski
self-requested a review
December 18, 2023 15:47
olevski
previously approved these changes
Dec 18, 2023
Panaetius
enabled auto-merge (squash)
December 20, 2023 08:33
olevski
previously approved these changes
Jan 17, 2024
olevski
self-requested a review
January 17, 2024 09:09
olevski
approved these changes
Jan 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds
renku storage lsadapted for SwissDataScienceCenter/renku-notebooks#1707 and related features