From 37b3fef72e7de8f39f15be0ac284b7c1335f8b0a Mon Sep 17 00:00:00 2001 From: Roger Oba Date: Sat, 27 Jun 2020 15:39:53 -0300 Subject: [PATCH 1/2] Add `ASImageCacherCompletion` breaking API change. --- ThreeMigrationGuide.md | 25 +++++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/ThreeMigrationGuide.md b/ThreeMigrationGuide.md index afd30d22a..ba3b94b42 100644 --- a/ThreeMigrationGuide.md +++ b/ThreeMigrationGuide.md @@ -1,3 +1,24 @@ -### Texture 3.0 Migration Guide ### +## Texture 3.0 Migration Guide ### + +Got a tip for upgrading? Please open a PR to this document! + + +### Breaking API Changes + +`ASImageCacherCompletion` typedef has a new parameter: `ASImageCacheType cacheType`. Example: + + +```swift +ASPINRemoteImageDownloader.shared().cachedImage(with: url, callbackQueue: .main) { result in + … +} +``` + +Becomes + +```swift +ASPINRemoteImageDownloader.shared().cachedImage(with: url, callbackQueue: .main) { result, cacheType in + … +} +``` -Got a tip for upgrading? Please open a PR to this document! \ No newline at end of file From 5297d9b4523227093ec4a423435a85fcf16deb66 Mon Sep 17 00:00:00 2001 From: Roger Oba Date: Sat, 27 Jun 2020 23:00:29 -0300 Subject: [PATCH 2/2] Remove unnecessary trailing pounds. --- ThreeMigrationGuide.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ThreeMigrationGuide.md b/ThreeMigrationGuide.md index ba3b94b42..eafc3e572 100644 --- a/ThreeMigrationGuide.md +++ b/ThreeMigrationGuide.md @@ -1,4 +1,4 @@ -## Texture 3.0 Migration Guide ### +## Texture 3.0 Migration Guide Got a tip for upgrading? Please open a PR to this document! @@ -21,4 +21,3 @@ ASPINRemoteImageDownloader.shared().cachedImage(with: url, callbackQueue: .main) … } ``` -