From 6370071062be9f304f0fa1829c795683a08a440b Mon Sep 17 00:00:00 2001 From: Jefffrey Date: Fri, 17 Jul 2026 17:02:34 +0900 Subject: [PATCH 1/2] chore: downsize `sql_planner_extended` `logical_plan_bench` sample size to 10 --- datafusion/core/benches/sql_planner_extended.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/datafusion/core/benches/sql_planner_extended.rs b/datafusion/core/benches/sql_planner_extended.rs index b016d758f3bce..af048192812ea 100644 --- a/datafusion/core/benches/sql_planner_extended.rs +++ b/datafusion/core/benches/sql_planner_extended.rs @@ -386,12 +386,16 @@ fn criterion_benchmark(c: &mut Criterion) { let df = build_test_data_frame(&baseline_ctx, &rt); let case_heavy_left_join_df = build_case_heavy_left_join_df(&case_heavy_ctx, &rt); - c.bench_function("logical_plan_optimize", |b| { + // really slow :( + let mut group = c.benchmark_group("sample_size_10"); + group.sample_size(10); + group.bench_function("logical_plan_optimize", |b| { b.iter(|| { let df_clone = df.clone(); black_box(rt.block_on(async { df_clone.into_optimized_plan().unwrap() })); }) }); + group.finish(); c.bench_function("logical_plan_optimize_hotspot_case_heavy_left_join", |b| { b.iter(|| { From a3bfb11cc659fcceae7916c904bfb999eb1c7ed6 Mon Sep 17 00:00:00 2001 From: Jefffrey Date: Fri, 17 Jul 2026 20:39:14 +0900 Subject: [PATCH 2/2] downsize to 5 samples --- datafusion/core/benches/sql_planner_extended.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/datafusion/core/benches/sql_planner_extended.rs b/datafusion/core/benches/sql_planner_extended.rs index af048192812ea..5bea9860c4be7 100644 --- a/datafusion/core/benches/sql_planner_extended.rs +++ b/datafusion/core/benches/sql_planner_extended.rs @@ -387,8 +387,8 @@ fn criterion_benchmark(c: &mut Criterion) { let case_heavy_left_join_df = build_case_heavy_left_join_df(&case_heavy_ctx, &rt); // really slow :( - let mut group = c.benchmark_group("sample_size_10"); - group.sample_size(10); + let mut group = c.benchmark_group("sample_size_5"); + group.sample_size(5); group.bench_function("logical_plan_optimize", |b| { b.iter(|| { let df_clone = df.clone();