Skip to content

refactor: remove unused ConfigurationManager.logCurrentConfiguration - #548

Merged
askpt merged 1 commit into
mainfrom
repo-assist/improve-remove-dead-log-config-92c1411d20ba985a
Aug 18, 2026
Merged

refactor: remove unused ConfigurationManager.logCurrentConfiguration#548
askpt merged 1 commit into
mainfrom
repo-assist/improve-remove-dead-log-config-92c1411d20ba985a

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Summary

🤖 This PR was created by Repo Assist, an automated AI assistant.

Removes ConfigurationManager.logCurrentConfiguration, a debug-logging method that was never called from anywhere in the extension source or test suite. Confirmed via a full-repo grep that the only reference was its own definition.

Rationale

Dead code adds maintenance surface without providing value. This is a minimal, surgical removal with no behavioral change to the rest of the extension.

Trade-offs

None identified — the method had no callers and no tests exercised it.

Test Status

  • npm run compile — passes
  • npm run lint — passes
  • ⚠️ npm test (vscode-test) — could not run in this sandboxed environment due to network restrictions (getaddrinfo EAI_AGAIN update.code.visualstudio.com), an infrastructure limitation unrelated to this change. The change only removes an unused method with no test coverage, so this is low risk.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • releaseassets.githubusercontent.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "releaseassets.githubusercontent.com"

See Network Configuration for more information.

Generated by 🌈 Repo Assist, see workflow run. Learn more.
Comment /repo-assist to run again

Add this agentic workflow to your repo

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@42c2ab5b4e4c9273534c39259b2e0df7f20f07e9

logCurrentConfiguration was never called anywhere in the codebase or
tests. Removing this dead code reduces surface area and keeps
configuration.ts focused on functionality that is actually used.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@askpt askpt changed the title [repo-assist] refactor: remove unused ConfigurationManager.logCurrentConfiguration refactor: remove unused ConfigurationManager.logCurrentConfiguration Aug 18, 2026
@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.07%. Comparing base (5c935a0) to head (3b51dd5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
+ Coverage   82.80%   83.07%   +0.26%     
==========================================
  Files          13       13              
  Lines        4386     4372      -14     
  Branches      455      455              
==========================================
  Hits         3632     3632              
+ Misses        753      739      -14     
  Partials        1        1              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@askpt
askpt marked this pull request as ready for review August 18, 2026 06:49
@askpt
askpt self-requested a review as a code owner August 18, 2026 06:49
Copilot AI balanced review requested due to automatic review settings August 18, 2026 06:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an unused debugging method from configuration management without changing runtime behavior.

Changes:

  • Removed ConfigurationManager.logCurrentConfiguration.
  • Confirmed no remaining references.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@askpt
askpt merged commit 572f97d into main Aug 18, 2026
25 checks passed
@askpt
askpt deleted the repo-assist/improve-remove-dead-log-config-92c1411d20ba985a branch August 18, 2026 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants