diff --git a/AGENTS.md b/AGENTS.md index 38618d9eab..33c42701ec 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -2214,12 +2214,12 @@ Sorting and the rest: - The phone door allows `threads/:id/read` and `threads/:id/unread` (`inbox-devices.ts` ALLOWLIST); the list row's `read_at` and the question's `set_aside_at` are additive. The surface draws no list or thread, so it is unchanged. - Tests: `packages/shared/inbox/store-mark-read.test.ts` (the rules, the note, a replay, a store older than Mark read), `packages/shared/inbox/store-words-only-reply.test.ts` and `packages/core/inbox-reply-sentence.test.ts` (a reply with no answers: the exact agent text, words, annotations, one question, an earlier answer; partial replies unchanged), `packages/core/question-answer-by-reply.test.ts`, `packages/server/inbox-mark-read.test.ts` (the routes and guards, the note through `wait_for_reply`, no decision on a skip, a words-only reply through `wait_for_reply`), the DOM test `packages/inbox/markRead.test.tsx` (the whole window over a real Inbox run by `tests/helpers/inbox-dom-server.ts`; the chip's default with and without a pick; it includes the one-session thread whose words-only Send switched to skip is one reply), and `tests/e2e/inbox-mark-read.spec.ts` on the compiled binary. -**πŸ‘ Looks good** (approval "inbox-acknowledge", 2026-10-15; not in this repo). A silent acknowledgment: "cool, looks good" without waking the agent for a turn. +**πŸ‘ Looks good** (approval "inbox-acknowledge", 2026-10-15, amended 2026-10-16; not in this repo). "Cool, looks good": the thread goes to Quiet, and after the Undo window the πŸ‘ is sent to the agent that wrote the message as one short turn. The amendment, the owner verbatim: "I replied with looks good, but I realized that doesn't send through. I think we just need to send looks good through, honestly." Before it the πŸ‘ was silent (agents saw it only on their next read). - The thread's foot is `[↩ Reply] [πŸ‘ Looks good]` side by side (44 px each on a phone); πŸ‘ is hidden while any question in the thread is open or picked (and while picks or annotations wait to be sent), once the person wrote back (the last message, the Inbox's notes read past, is theirs), on an archived thread, and with no agent message. No new key; the toast's `Z` undoes. - `POST /api/inbox/messages/:id/ack` (`{ serverSession?, ack? }`, `ack: false` takes it back; the window's same-origin and `serverSession` guards) β†’ `InboxStore.ackMessage`: an additive `ack: { label: "Looks good", at, read_seq, made_read, settled_seq, settled_at, seen_at }` snapshot line on the agent's message, plus Mark read (`read_seq` = the Mark read it stands on, `made_read` = the πŸ‘ made it). Undo removes the ack and undoes the Mark read only when the πŸ‘ made it. Move back (`/unread`, `E`) on that Mark read withdraws the ack too, so the agent never sees a πŸ‘ on a thread the person moved back. Refused: `422 ack_not_allowed` (a person's message), `409 ack_stale` (not the thread's latest agent message), `409 ack_after_reply` (a person message, not an Inbox note, follows it: the reply is the answer and keeps its Sent / Delivered state), `409 question_open`, `409 thread_resolved`. A second πŸ‘ writes nothing. In a one-message thread the root is the agent message, so `markRead` re-reads the root after withdrawing. -- Nothing is sent and nothing wakes: no person message, no bridge command (`pendingReplies` is person-only), no push. After the Undo window (`setAsideDelayMs`, the set-aside note's 10 s), the server writes `settled_seq`/`settled_at` (`settleAcks`; swept at start too). Only then do agents see it: `read_thread` carries `ack: { label, at }` (`store.agentThread`), and `wait_for_reply` returns `{ status: "acknowledged", acks: [{ message_id, label, at }], cursor }` for an ack on the caller's latest message in a thread it waits on (replies first; not a person reply). Either one writes `seen_at` (`markAcksSeen`). A wait across every thread the caller asked (no thread id, no cursor) skips an ack already seen, so an old πŸ‘ on a finished thread never answers a later wait; a wait on one named thread keeps answering it. -- The window: the button pressed (`aria-pressed`, success tint; a click takes it back), a pill under the message "πŸ‘ Looks good Β· You,