From 0ea7d0736311ba71f471395cfc6068b505393846 Mon Sep 17 00:00:00 2001 From: Tom Arbesser-Rastburg Date: Mon, 8 Sep 2025 21:46:44 +1000 Subject: [PATCH] Close cURL handle on error in Envoy/H2Proxy executors --- src/Grphp/Client/Strategy/Envoy/RequestExecutor.php | 4 +++- src/Grphp/Client/Strategy/H2Proxy/RequestExecutor.php | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/Grphp/Client/Strategy/Envoy/RequestExecutor.php b/src/Grphp/Client/Strategy/Envoy/RequestExecutor.php index 910e7a2..056555c 100644 --- a/src/Grphp/Client/Strategy/Envoy/RequestExecutor.php +++ b/src/Grphp/Client/Strategy/Envoy/RequestExecutor.php @@ -83,7 +83,9 @@ function ($ch, $header) use ($responseHeaders) { $response = curl_exec($ch); if (curl_errno($ch)) { - throw new RequestException(curl_error($ch), $responseHeaders); + $errorMessage = curl_error($ch); + curl_close($ch); + throw new RequestException($errorMessage, $responseHeaders); } $headerSize = curl_getinfo($ch, CURLINFO_HEADER_SIZE); diff --git a/src/Grphp/Client/Strategy/H2Proxy/RequestExecutor.php b/src/Grphp/Client/Strategy/H2Proxy/RequestExecutor.php index e0567f3..9148b45 100644 --- a/src/Grphp/Client/Strategy/H2Proxy/RequestExecutor.php +++ b/src/Grphp/Client/Strategy/H2Proxy/RequestExecutor.php @@ -82,7 +82,9 @@ function ($ch, $header) use ($responseHeaders) { $response = curl_exec($ch); if (curl_errno($ch)) { - throw new RequestException(curl_error($ch), $responseHeaders); + $errorMessage = curl_error($ch); + curl_close($ch); + throw new RequestException($errorMessage, $responseHeaders); } $headerSize = curl_getinfo($ch, CURLINFO_HEADER_SIZE);