Repository navigation
feat(cli): disabled version option - #162
Merged
Merged
Conversation
MishaSeredenkoPushBased
force-pushed
the
remove-version-option
branch
from
October 26, 2023 07:23
0fa2183 to
142943e
Compare
MishaSeredenkoPushBased
requested review from
BioPhoton,
Tlacenka,
matejchalk and
vmasek
October 26, 2023 07:33
matejchalk
approved these changes
Oct 26, 2023
matejchalk
left a comment
matejchalk
left a comment
Collaborator
There was a problem hiding this comment.
Nothing major, but the convention is to write commit messages in "imperative mood", i.e. feat(cli): disable version option instead of feat(cli): disabled version option (disable instead of disabled - think of it like you're giving instructions).
Tlacenka
approved these changes
Oct 26, 2023
Tlacenka
left a comment
Tlacenka
left a comment
Collaborator
There was a problem hiding this comment.
CLI no longer supports the version option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabled --version option
Closes #124