Repository navigation
feat(core): change to execute all plugins before throwing on failed - #275
Merged
Merged
Conversation
MishaSeredenkoPushBased
requested review from
BioPhoton,
IKatsuba,
Tlacenka,
matejchalk and
vmasek
November 16, 2023 12:24
matejchalk
reviewed
Nov 16, 2023
matejchalk
previously approved these changes
Nov 16, 2023
BioPhoton
requested changes
Nov 16, 2023
BioPhoton
left a comment
BioPhoton
left a comment
Collaborator
There was a problem hiding this comment.
We could use already existing helper logic.
MishaSeredenkoPushBased
added
➕ enhancement
IKatsuba
reviewed
Nov 18, 2023
IKatsuba
reviewed
Nov 18, 2023
BioPhoton
reviewed
Nov 19, 2023
BioPhoton
left a comment
BioPhoton
left a comment
Collaborator
There was a problem hiding this comment.
left comments mostly nit picking
BioPhoton
requested changes
Nov 21, 2023
BioPhoton
left a comment
BioPhoton
left a comment
Collaborator
There was a problem hiding this comment.
Hi! I guess we have a bit of a confusion here with generic vs specific functions and how to reuse generic logic.
Please have a look at my comments
BioPhoton
reviewed
Nov 21, 2023
matejchalk
reviewed
Nov 21, 2023
Contributor
Author
|
The comments are fixed, as well as the code was improved for better readability and support. |
matejchalk
requested changes
Nov 22, 2023
matejchalk
approved these changes
Nov 22, 2023
BioPhoton
approved these changes
Nov 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed executePlugins() logic to run all plugins, even if one or more plugins have failed. Then console.error the failed plugin errors, and throw.
Closes #159