Add support for executemany()#810
Merged
bgunebakan merged 2 commits intoJun 9, 2026
Merged
Conversation
bgunebakan
force-pushed
the
fix/807-executemany-does-not-translate-pyformat-dict-params
branch
from
e6aed17 to
91299e4
Compare
mfussenegger
reviewed
Jun 8, 2026
Comment on lines
+155
to
+156
| and isinstance(bulk_parameters[0], dict) | ||
| and _NAMED_PARAM_RE.search(sql) |
Member
There was a problem hiding this comment.
What happens if there is a mix of dict/non-dict args?
Contributor
Author
There was a problem hiding this comment.
currently we raise an error. Do we have case to use mix of dict/non-dict together? I couldn't find how server handle that. What it should do?
Member
There was a problem hiding this comment.
Raising an error sounds good if it's one that makes it clear that mixing dict/non-dict together isn't supported.
Contributor
Author
There was a problem hiding this comment.
I added edge case here cursor.py:92 so it will raise ProgrammingError and added test for that.
| ): | ||
| cursor = mocked_connection.cursor() | ||
| cursor.executemany( | ||
| "INSERT INTO characters (name, age) VALUES (%(name)s, %(age)s)", |
Member
There was a problem hiding this comment.
Can you also add a case where one named argument is used multiple times and check that it gets the same position number?
mfussenegger
approved these changes
Jun 9, 2026
bgunebakan
deleted the
fix/807-executemany-does-not-translate-pyformat-dict-params
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes / Why this is an improvement
Checklist
executemany()does not translate pyformat dict params #807