feat: mention keep alive in migration guide - #594
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughDocuments migration to explicit WebSocket keep-alive via control messages (sent with send_control) and adds two public control-message types for ListenV1 and AgentV1 in deepgram.extensions.types.sockets; updates migration guide and breaking changes accordingly. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Client
participant Conn as ListenV1 / AgentV1 Connection
participant WS as WebSocket Server
Note over Client,Conn: Client controls keep-alive explicitly via control messages
Client->>Conn: open_connection(headers: additional_headers / extra_headers)
Conn->>WS: WebSocket handshake
WS-->>Conn: connection established
loop periodic keep-alive
Client->>Conn: send_control(KeepAlive: ListenV1ControlMessage / AgentV1ControlMessage)
Conn->>WS: ControlMessage: KeepAlive
WS-->>Conn: ack / keep-alive response (optional)
end
Client->>Conn: close()
Conn->>WS: close frame
WS-->>Conn: closed
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/Migrating-v3-to-v5.md(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: test (3.9)
lukeocodes
approved these changes
Oct 10, 2025
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit