Offer to set default browsers#3792
Merged
Merged
Conversation
Contributor
|
Nice, but we should output the defaults we've written. |
gaearon
reviewed
Jan 14, 2018
| .then(() => | ||
| // We attempt to use the default port but if it is busy, we offer the user to | ||
| // run on a different port. `choosePort()` Promise resolves to the next free port. | ||
| choosePort(HOST, DEFAULT_PORT).then(port => { |
Contributor
There was a problem hiding this comment.
Return this to avoid the extra nesting level?
gaearon
reviewed
Jan 14, 2018
| .then(() => | ||
| // First, read the current file sizes in build directory. | ||
| // This lets us display how much they changed later. | ||
| measureFileSizesBeforeBuild(paths.appBuild) |
Contributor
Author
|
|
gaearon
approved these changes
Jan 14, 2018
Contributor
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
Might be a bit clearer with blocks and explicit return statements
Contributor
Author
|
More explicit it is: 2dc7f9f |
gaearon
pushed a commit
that referenced
this pull request
Jan 14, 2018
* Offer to set browser defaults * Catch error on no * Add ending newlines * Ensure we re-check to prevent defaults from leaking * Reduce nesting * Add defaults message * More explicit
Timer
added a commit
to Timer/create-react-app
that referenced
this pull request
Jan 15, 2018
* Offer to set browser defaults * Catch error on no * Add ending newlines * Ensure we re-check to prevent defaults from leaking * Reduce nesting * Add defaults message * More explicit
akstuhl
pushed a commit
to akstuhl/create-react-app
that referenced
this pull request
Mar 15, 2018
* Offer to set browser defaults * Catch error on no * Add ending newlines * Ensure we re-check to prevent defaults from leaking * Reduce nesting * Add defaults message * More explicit
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this pull request
Sep 30, 2018
* Offer to set browser defaults * Catch error on no * Add ending newlines * Ensure we re-check to prevent defaults from leaking * Reduce nesting * Add defaults message * More explicit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.