Skip to content

Update paths.js, rename shadow path variable#4435

Merged
iansu merged 2 commits into
react:nextfrom
graemecode:patch-1
May 23, 2018
Merged

Update paths.js, rename shadow path variable#4435
iansu merged 2 commits into
react:nextfrom
graemecode:patch-1

Conversation

@graemecode
Copy link
Copy Markdown
Contributor

@graemecode graemecode commented May 10, 2018

This file requires the "path" module and sets it to a variable path. The function ensureSlash also has a variable path that then shadows the path module.

Update paths.js, rename shadow path variable
e842c42 
This file requires the "path" module and sets it to a variable `path`. The function `ensureSlash` also has a variable `path` that then shadows the `path` module.
@facebook-github-bot
Copy link
Copy Markdown

facebook-github-bot commented May 10, 2018

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Copy Markdown

facebook-github-bot commented May 10, 2018

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@iansu
Copy link
Copy Markdown
Contributor

iansu commented May 20, 2018

This seems like a good thing to fix as it could cause bugs or confusion in the future. I'm not sure about the name pathIn though. Can you change it to something else like thePath or inputPath?

@graemecode
Copy link
Copy Markdown
Contributor Author

graemecode commented May 23, 2018

♻️ @iansu

@iansu iansu merged commit 61c864c into react:next May 23, 2018
@iansu iansu added this to the 2.0.0 milestone May 23, 2018
@iansu
Copy link
Copy Markdown
Contributor

iansu commented May 23, 2018

Thanks!

zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
@iansu
Update paths.js, rename shadow path variable (react#4435)
57effe5 
* Update paths.js, rename shadow path variable

This file requires the "path" module and sets it to a variable `path`. The function `ensureSlash` also has a variable `path` that then shadows the `path` module.

* Update paths.js
@lock lock Bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed tag: internal

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@graemecode @facebook-github-bot @iansu