[RN] Move view config registry to shims - #12569
Conversation
58a27c1 to
ecc0422
Compare
|
I don't understand why it's duplicated or what difference being in the shims folder makes. |
|
…and that's probably why you didn't tag me as reviewer. Oops. |
|
Shims is the only thing we have set up that can be standalone files without being bundled. The alternative is building a new bundle that only has this file in it but I think a more likely set up is that we just move this file to RN and keep the mock so it works like all the other external deps. |
|
There's also other reasons to put it in shims. Because we have a bunch of lint rules and stuff set up that means you can't do things like use CommonJS in normal src files. It's quite difficult to not bundle something. |
ecc0422 to
6bc4350
Compare
|
I also moved createReactNativeComponentClass since it's just an alias for the registry. It should really just move back to RN. |
bvaughn
left a comment
bvaughn
left a comment
There was a problem hiding this comment.
This change looks okay to me, but why can't we just remove these from the React repo entirely now? The shims are only useful if they're in place to forward to "SECRET INTERNALS" stuff, right?
| } | ||
| invariant(viewConfig, 'View config not found for name %s', name); | ||
| return viewConfig; | ||
| }; |
There was a problem hiding this comment.
We should just move extractEvents out of ReactNativeBridgeEventPlugin and into this file too so we can get rid of ReactNativeBridgeEventPlugin. 😄
This ensures that both Fabric and RN renderers share the same view config registry since it is stateful. I had to duplicate in the mocks for testing.
6bc4350 to
492d3ad
Compare
Since createReactNativeComponentClass is just an alias for the register there's no need to bundle it. This file should probably just move back to RN too.
492d3ad to
ebde434
Compare
* Move view config registry to shims This ensures that both Fabric and RN renderers share the same view config registry since it is stateful. I had to duplicate in the mocks for testing. * Move createReactNativeComponentClass to shims and delete internal usage Since createReactNativeComponentClass is just an alias for the register there's no need to bundle it. This file should probably just move back to RN too.
* Move view config registry to shims This ensures that both Fabric and RN renderers share the same view config registry since it is stateful. I had to duplicate in the mocks for testing. * Move createReactNativeComponentClass to shims and delete internal usage Since createReactNativeComponentClass is just an alias for the register there's no need to bundle it. This file should probably just move back to RN too.
4 participants
Builds on top of #12556
This ensures that both Fabric and RN renderers share the same view config registry since it is stateful.
I had to duplicate in the mocks for testing.