Fix incorrect calculation of onMouseEnter/Leave component path - #11164
Conversation
This will be easier to follow when we add more code there.
So that I can add a block scoped variable.
This is the actual bugfix.
420b58a to
ef6d6fc
Compare
| while (from && from !== common) { | ||
| const common = from && to ? getLowestCommonAncestor(from, to) : null; | ||
| const pathFrom = []; | ||
| while (true) { |
There was a problem hiding this comment.
We try to avoid while (true) since (at least in older versions) it has been known to deopt.
I appreciate the rewrite for the temp variable and easy of read. But arguably this just make the condition seem a lot more complicated than it really is.
There was a problem hiding this comment.
Didn't it deopt when you have continues rather than break? I don't remember. @trueadm
sebmarkbage
left a comment
sebmarkbage
left a comment
There was a problem hiding this comment.
Nit: I think I prefer the other writing style, even if that includes a temporary variable assignment inline in the condition.
|
Like this? while (from && from !== common && (!from.alternate && from.alternate !== common)) {I'm not sure how else to write it in a single line. I’m finding this really hard to follow, especially because the |
|
Or, rather, while (from && from !== common && (!from.alternate || from.alternate !== common)) {See, I already made a mistake there. 😛 |
|
Do you like this? while (from && (!common || (from !== common && from.alternate !== common))) {If we check for |
|
Meh. I find all of these hard to follow and I don't know if they're correct. |
…#11164) * Add a regression test for react#10906 * Turn while conditions into breaks without changing the logic This will be easier to follow when we add more code there. * var => const/let So that I can add a block scoped variable. * Check alternates when comparing to the common ancestor This is the actual bugfix.
3 participants
Fixes #10906 and #11152.
We forgot to compare alternates so in some cases, the from/to path was calculated incorrectly.
See individual commits. The first one adds a test, the last one fixes the bug. The ones in the middle prepare the code to look readable after the bugfix.
I verified both #10906 and #11152 reproduced before, but no longer reproduce after the bugfix.