Move hydration code out of normal Suspense path - #24532
Merged
Merged
Conversation
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 2c68776...01562b7 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
acdlite
force-pushed
the
move-hydration-code
branch
2 times, most recently
from
May 20, 2022 00:33
3d0367e to
f7c9bf2
Compare
gnoff
approved these changes
May 25, 2022
left a comment
Collaborator
There was a problem hiding this comment.
Makes sense and fixed described in #24578
added 2 commits
May 25, 2022 15:33
Shuffling some code around to make it easier to follow. The logic for updating a dehydrated Suspense boundary is significantly different from the logic for a client-rendered Suspense boundary. Most of it was already lifted out into a separate function; this moves the remaining hydration-specific logic out of updateSuspenseComponent and into updateDehydratedSuspenseComponent instead. No expected changes to program behavior.
Same as previous step but for the complete phase. This is a separate commit to make bisecting easier in case something breaks. The logic is very subtle but mostly all I've done is extract it to another function.
acdlite
force-pushed
the
move-hydration-code
branch
from
May 25, 2022 19:33
f7c9bf2 to
01562b7
Compare
commented
May 25, 2022
Contributor
|
If this fixes something, then there's a change to behavior. What's the change? |
commented
May 25, 2022
Collaborator
|
hydration errors from an inner boundary can be upgraded to recoverable by an outer boundary. This moves the upgrade call to the code path that only runs for the boundary that is being hydrated |
Collaborator
Author
This |
commented
May 25, 2022
Collaborator
Author
This was referenced Mar 4, 2023
This was referenced Feb 10, 2024
This was referenced Nov 10, 2024
This was referenced Nov 10, 2024
This was referenced Nov 10, 2024
This was referenced Nov 11, 2024
This was referenced Nov 11, 2024
This was referenced Nov 12, 2024
This was referenced Nov 12, 2024
This was referenced Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shuffling some code around to make it easier to follow. The logic for updating a dehydrated Suspense boundary is significantly different from the logic for a client-rendered Suspense boundary. Most of it was already lifted out into a separate function; this moves the remaining hydration-specific logic out of updateSuspenseComponent and into updateDehydratedSuspenseComponent instead.
No expected changes to program behavior.