Skip to content

Commit faefa73

Browse files
committed
docs(ladder): request roles via issues in fullsend-ai/org
Triage, Write, and Maintainer role requests are now issues in fullsend-ai/org (triage-request/write-request/maintainer-request templates), approved by adding the requester to the triagers/writers/core teams in peribolos.yaml. Write requests need two maintainers approving by commenting on the request issue before the peribolos.yaml PR is opened, and that PR links the approved issue. Maintainer nominations follow the MAINTAINERS.md process: maintainer consensus, then the core team. That repo's notify-role-request-slack workflow handles Slack notifications, so trim notify-vouch-slack to vouch requests only. Assisted-By: glm-5-3(pi) Signed-off-by: Hector Martinez <hemartin@redhat.com>
1 parent 8c45f41 commit faefa73

5 files changed

Lines changed: 39 additions & 134 deletions

File tree

‎.github/DISCUSSION_TEMPLATE/triage-request.yml‎

Lines changed: 0 additions & 51 deletions
This file was deleted.

‎.github/DISCUSSION_TEMPLATE/write-request.yml‎

Lines changed: 0 additions & 52 deletions
This file was deleted.

‎.github/workflows/notify-vouch-slack.yml‎

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,7 @@ jobs:
2424
if: >-
2525
github.repository_owner == 'fullsend-ai' &&
2626
(github.event_name == 'workflow_dispatch' ||
27-
github.event.discussion.category.slug == 'vouch-request' ||
28-
github.event.discussion.category.slug == 'triage-request' ||
29-
github.event.discussion.category.slug == 'write-request')
27+
github.event.discussion.category.slug == 'vouch-request')
3028
runs-on: ubuntu-24.04
3129
timeout-minutes: 5
3230
steps:
@@ -58,16 +56,6 @@ jobs:
5856
request_emoji="🤝"
5957
request_context="Review the request and comment \`/vouch\` to approve."
6058
;;
61-
triage-request)
62-
request_label="triage request"
63-
request_emoji="🔎"
64-
request_context="Review the request for triage access."
65-
;;
66-
write-request)
67-
request_label="write request"
68-
request_emoji="✍️"
69-
request_context="Review the request for write access."
70-
;;
7159
*)
7260
echo "::error::Invalid discussion category received"
7361
exit 1

‎LADDER.md‎

Lines changed: 34 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -73,14 +73,15 @@ repository.
7373
- Responsive to feedback on your contributions — on changes you drove
7474
and in review discussions you took part in
7575

76-
**How to check:** You are a member of
77-
[@fullsend-ai/triagers](https://github.com/orgs/fullsend-ai/teams/triagers).
76+
**How to check:** Your GitHub username is listed under `triagers`
77+
in the `teams:` section of
78+
[peribolos.yaml](https://github.com/fullsend-ai/org/blob/main/peribolos.yaml)
79+
in the [fullsend-ai/org](https://github.com/fullsend-ai/org) repository.
7880

7981
**How to request:** Open a
80-
[Triage Request](https://github.com/fullsend-ai/fullsend/discussions/new?category=triage-request)
81-
discussion. Link to your substantive reviews or merged PRs, and briefly
82-
describe the work and judgment each one shows (see
83-
[Making your case](#making-your-case)).
82+
[Triage Request](https://github.com/fullsend-ai/org/issues/new?template=triage-request.yml)
83+
issue in [fullsend-ai/org](https://github.com/fullsend-ai/org). A maintainer
84+
approves by adding your username to the `triagers` team in `peribolos.yaml`.
8485

8586
You do not need to be an expert in the codebase or community conventions
8687
to request Triage. If you think your contributions demonstrate
@@ -113,15 +114,21 @@ repository.
113114
PR workflow, review etiquette)
114115
- Trusted not to push directly to protected branches or bypass review
115116

116-
**How to check:** You are a member of
117-
[@fullsend-ai/writers](https://github.com/orgs/fullsend-ai/teams/writers).
117+
**How to check:** Your GitHub username is listed under `writers`
118+
in the `teams:` section of
119+
[peribolos.yaml](https://github.com/fullsend-ai/org/blob/main/peribolos.yaml)
120+
in the [fullsend-ai/org](https://github.com/fullsend-ai/org) repository.
118121

119122
**How to request:** Open a
120-
[Write Request](https://github.com/fullsend-ai/fullsend/discussions/new?category=write-request)
121-
discussion. Link to your contribution history and describe the work
122-
and judgment it demonstrates (see [Making your case](#making-your-case)).
123-
124-
**Who approves:** Two maintainers must approve. A single maintainer
123+
[Write Request](https://github.com/fullsend-ai/org/issues/new?template=write-request.yml)
124+
issue in [fullsend-ai/org](https://github.com/fullsend-ai/org). Two maintainers
125+
must approve by commenting on that issue; only after both approvals should
126+
a `peribolos.yaml` PR be opened. The maintainer opening the PR links the
127+
approved issue in the PR description, and adds your username to the `writers`
128+
team in `peribolos.yaml`.
129+
130+
**Who approves:** Two maintainers must approve on the request issue before
131+
the `peribolos.yaml` PR is opened. A single maintainer
125132
can request more discussion but cannot unilaterally grant write access.
126133

127134
### Maintainer
@@ -140,6 +147,17 @@ project and to help review contributions you are not driving.
140147
**Criteria and process:** See [MAINTAINERS.md](MAINTAINERS.md) for the
141148
full eligibility criteria, nomination process, and time commitment.
142149

150+
**How to check:** Your GitHub username is listed under `maintainers`
151+
of the `core` team in
152+
[peribolos.yaml](https://github.com/fullsend-ai/org/blob/main/peribolos.yaml)
153+
in the [fullsend-ai/org](https://github.com/fullsend-ai/org) repository.
154+
155+
**How to request:** Open a
156+
[Maintainer Nomination](https://github.com/fullsend-ai/org/issues/new?template=maintainer-request.yml)
157+
issue in [fullsend-ai/org](https://github.com/fullsend-ai/org). Existing
158+
maintainers discuss and reach consensus; if approved, your username is
159+
added to the `core` team in `peribolos.yaml`.
160+
143161
## Demonstrating readiness
144162

145163
Advancement is a human assessment of demonstrated trust and readiness.
@@ -237,9 +255,9 @@ Role changes use the following request mechanisms:
237255
| Role | Request mechanism | Approval |
238256
|------|-------------------|----------|
239257
| Vouched | [Vouch Request](https://github.com/fullsend-ai/fullsend/discussions/new?category=vouch-request) | 1 Maintainer |
240-
| Triage | [Triage Request](https://github.com/fullsend-ai/fullsend/discussions/new?category=triage-request) | 1 Maintainer |
241-
| Write | [Write Request](https://github.com/fullsend-ai/fullsend/discussions/new?category=write-request) | 2 Maintainers |
242-
| Maintainer | Issue (see [MAINTAINERS.md](MAINTAINERS.md)) | Maintainer consensus |
258+
| Triage | [Triage Request](https://github.com/fullsend-ai/org/issues/new?template=triage-request.yml) issue in [fullsend-ai/org](https://github.com/fullsend-ai/org) | 1 Maintainer |
259+
| Write | [Write Request](https://github.com/fullsend-ai/org/issues/new?template=write-request.yml) issue in [fullsend-ai/org](https://github.com/fullsend-ai/org) | 2 Maintainers |
260+
| Maintainer | [Maintainer Nomination](https://github.com/fullsend-ai/org/issues/new?template=maintainer-request.yml) issue in [fullsend-ai/org](https://github.com/fullsend-ai/org) (see [MAINTAINERS.md](MAINTAINERS.md)) | Maintainer consensus |
243261

244262
## Revoking access
245263

‎MAINTAINERS.md‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,10 @@ own establish the familiarity needed for a maintainer role.
3333

3434
## Process
3535

36-
1. **File an issue** titled "Maintainer nomination: \<your GitHub
37-
handle\>". In the issue, link to merged PRs you have authored or
36+
1. **File a nomination issue** using the
37+
[Maintainer Nomination](https://github.com/fullsend-ai/org/issues/new?template=maintainer-request.yml)
38+
template in [fullsend-ai/org](https://github.com/fullsend-ai/org).
39+
In the issue, link to merged PRs you have authored or
3840
substantive reviews you have provided that demonstrate your
3941
familiarity with the project.
4042
2. **Current maintainers discuss.** The maintainers will review your

0 commit comments

Comments
 (0)