From c98235d56cd42bd15c4c4a4a9272ee36121d52cb Mon Sep 17 00:00:00 2001 From: Lucas Delvoye Date: Tue, 13 Oct 2026 16:25:53 -0700 Subject: [PATCH] fix(locking): prefix lock release errors with an error code Redis and Valkey file error replies under the first word of the message, so these showed up in errorstats as NO and LOCK. --- src/sentry/scripts/utils/locking/delete_lock.lua | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/sentry/scripts/utils/locking/delete_lock.lua b/src/sentry/scripts/utils/locking/delete_lock.lua index 63f3221b2897..4d9685426d3e 100644 --- a/src/sentry/scripts/utils/locking/delete_lock.lua +++ b/src/sentry/scripts/utils/locking/delete_lock.lua @@ -3,9 +3,9 @@ local uuid = ARGV[1] local value = redis.call('GET', key) if not value then - return redis.error_reply(string.format("No lock at key exists at key: %s", key)) + return redis.error_reply(string.format("NOLOCK No lock at key exists at key: %s", key)) elseif value ~= uuid then - return redis.error_reply(string.format("Lock at %s was set by %s, and cannot be released by %s.", key, value, uuid)) + return redis.error_reply(string.format("LOCKHELD Lock at %s was set by %s, and cannot be released by %s.", key, value, uuid)) else redis.call('DEL', key) return redis.status_reply("OK")