Capitalization of the 2FA OTP request header

[tradej]

Running

from github import Github
user = Github(login_or_token='username', password='password').get_user()
try:                                                                               
    auth = user.create_authorization(scopes=['repo'], note='test')
except GithubException:                                                         
    password = input()                                                             
    auth = user.create_authorization(scopes=['repo'], note='test', onetime_password=password)

yields a TwoFactorException with the following traceback:

Traceback (most recent call last):
  File "./mygithub.py", line 9, in <module>
    auth = user.create_authorization(scopes=['repo'], note='test')
  File "/home/tradej/.local/lib/python3.3/site-packages/github/AuthenticatedUser.py", line 436, in create_authorization
    headers=request_header,
  File "/home/tradej/.local/lib/python3.3/site-packages/github/Requester.py", line 169, in requestJsonAndCheck
    return self.__check(*self.requestJson(verb, url, parameters, headers, input, cnx))
  File "/home/tradej/.local/lib/python3.3/site-packages/github/Requester.py", line 177, in __check
    raise self.__createException(status, responseHeaders, output)
github.GithubException.TwoFactorException: 401 {'documentation_url': 'https://developer.github.com/v3/auth#working-with-two-factor-authentication', 'message': 'Must specify two-factor authentication OTP code.'}

This is caused by the OTP header string being all lowercase. If it is properly uppercased as in this pull request, the authentication process finishes correctly.

[jacquev6]

Thanks!

This is consistent with what I've just done in PyGithub v2 so I'll merge it soon and publish a new version of PyGithub v1.

Side note: HTTP headers are supposed to be case-insensitive.

[tradej]

Thank you too. I know that they should be case insensitive, but honestly, I think GitHub's API is a kind of a mess, and this behaviour does not exactly surprise me. I'll file a bug for it.

[jacquev6]

Merged and published in https://pypi.python.org/pypi/PyGithub/1.25.1

Thanks!

[tradej]

Thank you for merging. I sent a support ticket to GitHub concerning this behaviour and they acknowledged it.