This repository was archived by the owner on May 5, 2026. It is now read-only.
Expose timeout. - #3
Merged
Merged
Conversation
Contributor
Author
|
Thanks Kurt! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose
timeoutonhipchat.methodso that it's safer to use synchronously on a path that shouldn't hang. Leaves current signature/behavior unchanged -- it would probably be a good idea to default the timeout to something reasonable, though.(This is actually a pretty bad interface, but doesn't break existing code and it gets the job done. Ideally you'd specify the timeout once, or make it easier to override the opener, or something, I guess.)