From f6f8cc6d032d6613a2599db39fd163320d505ce0 Mon Sep 17 00:00:00 2001 From: Banks Nussman Date: Mon, 4 Mar 2024 10:03:36 -0500 Subject: [PATCH 1/2] fix trying to mutate the same array --- packages/manager/src/queries/base.ts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/manager/src/queries/base.ts b/packages/manager/src/queries/base.ts index 69cb1a482a0..926f83c418c 100644 --- a/packages/manager/src/queries/base.ts +++ b/packages/manager/src/queries/base.ts @@ -244,12 +244,17 @@ export const updateInPaginatedStore = ( return oldData; } - oldData.data[toUpdateIndex] = { + const updatedDATA = [...oldData.data]; + + updatedDATA[toUpdateIndex] = { ...oldData.data[toUpdateIndex], ...newData, }; - return oldData; + return { + ...oldData, + data: updatedDATA, + }; } ); }; From 62512cb147113726ea62b1be415d08832ad29a4d Mon Sep 17 00:00:00 2001 From: Banks Nussman Date: Mon, 4 Mar 2024 10:13:39 -0500 Subject: [PATCH 2/2] fix variable name --- packages/manager/src/queries/base.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/manager/src/queries/base.ts b/packages/manager/src/queries/base.ts index 926f83c418c..816d296063e 100644 --- a/packages/manager/src/queries/base.ts +++ b/packages/manager/src/queries/base.ts @@ -244,16 +244,16 @@ export const updateInPaginatedStore = ( return oldData; } - const updatedDATA = [...oldData.data]; + const updatedPaginatedData = [...oldData.data]; - updatedDATA[toUpdateIndex] = { + updatedPaginatedData[toUpdateIndex] = { ...oldData.data[toUpdateIndex], ...newData, }; return { ...oldData, - data: updatedDATA, + data: updatedPaginatedData, }; } );