From 40417549ebf1af590964ed472656233eb734eefc Mon Sep 17 00:00:00 2001 From: Alban Bailly Date: Thu, 14 Mar 2024 15:50:35 -0400 Subject: [PATCH 1/3] rerender rebuild drawer if linode ID changes --- .../LinodesDetail/LinodesDetailHeader/LinodeDetailHeader.tsx | 1 + .../src/features/Linodes/LinodesLanding/LinodesLanding.tsx | 1 + 2 files changed, 2 insertions(+) diff --git a/packages/manager/src/features/Linodes/LinodesDetail/LinodesDetailHeader/LinodeDetailHeader.tsx b/packages/manager/src/features/Linodes/LinodesDetail/LinodesDetailHeader/LinodeDetailHeader.tsx index 4c5f210a201..453a2de7c08 100644 --- a/packages/manager/src/features/Linodes/LinodesDetail/LinodesDetailHeader/LinodeDetailHeader.tsx +++ b/packages/manager/src/features/Linodes/LinodesDetail/LinodesDetailHeader/LinodeDetailHeader.tsx @@ -273,6 +273,7 @@ const LinodeDetailHeader = () => { open={resizeDialogOpen} /> { open={this.state.linodeMigrateOpen} /> Date: Thu, 14 Mar 2024 16:19:15 -0400 Subject: [PATCH 2/3] better handling --- .../LinodeRebuild/LinodeRebuildDialog.tsx | 12 ++++++------ .../LinodesDetailHeader/LinodeDetailHeader.tsx | 1 - .../Linodes/LinodesLanding/LinodesLanding.tsx | 1 - 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/packages/manager/src/features/Linodes/LinodesDetail/LinodeRebuild/LinodeRebuildDialog.tsx b/packages/manager/src/features/Linodes/LinodesDetail/LinodeRebuild/LinodeRebuildDialog.tsx index 3f0c92f2133..1a85ffba943 100644 --- a/packages/manager/src/features/Linodes/LinodesDetail/LinodeRebuild/LinodeRebuildDialog.tsx +++ b/packages/manager/src/features/Linodes/LinodesDetail/LinodeRebuild/LinodeRebuildDialog.tsx @@ -56,11 +56,10 @@ export const LinodeRebuildDialog = (props: Props) => { const [mode, setMode] = React.useState('fromImage'); const [rebuildError, setRebuildError] = React.useState(''); - React.useEffect(() => { - if (open) { - setRebuildError(''); - } - }, [open]); + const onExitDrawer = () => { + setRebuildError(''); + setMode('fromImage'); + }; const handleRebuildError = (status: string) => { setRebuildError(status); @@ -68,6 +67,7 @@ export const LinodeRebuildDialog = (props: Props) => { return ( { {hostMaintenance && } {rebuildError && {rebuildError}} If you can’t rescue an existing disk, it’s time to rebuild your Linode. There are a couple of different ways you can do this: diff --git a/packages/manager/src/features/Linodes/LinodesDetail/LinodesDetailHeader/LinodeDetailHeader.tsx b/packages/manager/src/features/Linodes/LinodesDetail/LinodesDetailHeader/LinodeDetailHeader.tsx index 453a2de7c08..4c5f210a201 100644 --- a/packages/manager/src/features/Linodes/LinodesDetail/LinodesDetailHeader/LinodeDetailHeader.tsx +++ b/packages/manager/src/features/Linodes/LinodesDetail/LinodesDetailHeader/LinodeDetailHeader.tsx @@ -273,7 +273,6 @@ const LinodeDetailHeader = () => { open={resizeDialogOpen} /> { open={this.state.linodeMigrateOpen} /> Date: Thu, 14 Mar 2024 16:35:20 -0400 Subject: [PATCH 3/3] Added changeset: Rebuild modal state not being reset properly --- packages/manager/.changeset/pr-10287-fixed-1710448520468.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 packages/manager/.changeset/pr-10287-fixed-1710448520468.md diff --git a/packages/manager/.changeset/pr-10287-fixed-1710448520468.md b/packages/manager/.changeset/pr-10287-fixed-1710448520468.md new file mode 100644 index 00000000000..80b6aee1be9 --- /dev/null +++ b/packages/manager/.changeset/pr-10287-fixed-1710448520468.md @@ -0,0 +1,5 @@ +--- +"@linode/manager": Fixed +--- + +Rebuild modal state not being reset properly ([#10287](https://github.com/linode/manager/pull/10287))