From f9ec118e89b7a44311aeb0b0e2c05e80a605163f Mon Sep 17 00:00:00 2001 From: pmakode-akamai Date: Tue, 2 Jul 2024 00:03:36 +0530 Subject: [PATCH 1/5] change: [M3-7684] - Keep Volumes Create Page Error Notification Position Consistent --- .../src/features/Volumes/VolumeCreate.tsx | 31 ++++++++----------- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/packages/manager/src/features/Volumes/VolumeCreate.tsx b/packages/manager/src/features/Volumes/VolumeCreate.tsx index fc3f21d74e9..1f4fe64c1a5 100644 --- a/packages/manager/src/features/Volumes/VolumeCreate.tsx +++ b/packages/manager/src/features/Volumes/VolumeCreate.tsx @@ -19,6 +19,7 @@ import { TooltipIcon } from 'src/components/TooltipIcon'; import { Typography } from 'src/components/Typography'; import { MAX_VOLUME_SIZE } from 'src/constants'; import { EUAgreementCheckbox } from 'src/features/Account/Agreements/EUAgreementCheckbox'; +import { getRestrictedResourceText } from 'src/features/Account/utils'; import { LinodeSelect } from 'src/features/Linodes/LinodeSelect/LinodeSelect'; import { reportAgreementSigningError, @@ -254,6 +255,18 @@ export const VolumeCreate = () => { }} title="Create" /> + {error && } + {doesNotHavePermission && ( + + )}
@@ -268,24 +281,6 @@ export const VolumeCreate = () => { Select a region to see cost per GB. - {error && ( - - )} - {doesNotHavePermission && ( - - )} Date: Tue, 2 Jul 2024 15:36:46 +0530 Subject: [PATCH 2/5] Added changeset: Position of error notif has been moved from inside the box to outside & used getRestrictedResourceText utility for the Notice --- .../manager/.changeset/pr-10632-changed-1719914806428.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 packages/manager/.changeset/pr-10632-changed-1719914806428.md diff --git a/packages/manager/.changeset/pr-10632-changed-1719914806428.md b/packages/manager/.changeset/pr-10632-changed-1719914806428.md new file mode 100644 index 00000000000..894c50233b7 --- /dev/null +++ b/packages/manager/.changeset/pr-10632-changed-1719914806428.md @@ -0,0 +1,5 @@ +--- +"@linode/manager": Changed +--- + +Position of error notif has been moved from inside the box to outside & used getRestrictedResourceText utility for the Notice ([#10632](https://github.com/linode/manager/pull/10632)) From 1406d0aa17fd7de90d2f472f56c5ff7dcacf10e6 Mon Sep 17 00:00:00 2001 From: pmakode-akamai Date: Tue, 2 Jul 2024 20:01:18 +0530 Subject: [PATCH 3/5] Keep general error inside the paper --- packages/manager/src/features/Volumes/VolumeCreate.tsx | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/manager/src/features/Volumes/VolumeCreate.tsx b/packages/manager/src/features/Volumes/VolumeCreate.tsx index 1f4fe64c1a5..9147c2251c3 100644 --- a/packages/manager/src/features/Volumes/VolumeCreate.tsx +++ b/packages/manager/src/features/Volumes/VolumeCreate.tsx @@ -255,7 +255,6 @@ export const VolumeCreate = () => { }} title="Create" /> - {error && } {doesNotHavePermission && ( { Select a region to see cost per GB. + {error && ( + + )} Date: Tue, 2 Jul 2024 20:06:01 +0530 Subject: [PATCH 4/5] Debugging fix --- packages/manager/src/features/Volumes/VolumeCreate.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/manager/src/features/Volumes/VolumeCreate.tsx b/packages/manager/src/features/Volumes/VolumeCreate.tsx index 9147c2251c3..5c60b9daaf8 100644 --- a/packages/manager/src/features/Volumes/VolumeCreate.tsx +++ b/packages/manager/src/features/Volumes/VolumeCreate.tsx @@ -284,7 +284,7 @@ export const VolumeCreate = () => { )} From f07a8da2a6e0f789b7b7792c01a799f85f6647e6 Mon Sep 17 00:00:00 2001 From: pmakode-akamai Date: Tue, 2 Jul 2024 23:02:17 +0530 Subject: [PATCH 5/5] Update changeset file --- packages/manager/.changeset/pr-10632-changed-1719914806428.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/manager/.changeset/pr-10632-changed-1719914806428.md b/packages/manager/.changeset/pr-10632-changed-1719914806428.md index 894c50233b7..855b27f535a 100644 --- a/packages/manager/.changeset/pr-10632-changed-1719914806428.md +++ b/packages/manager/.changeset/pr-10632-changed-1719914806428.md @@ -2,4 +2,4 @@ "@linode/manager": Changed --- -Position of error notif has been moved from inside the box to outside & used getRestrictedResourceText utility for the Notice ([#10632](https://github.com/linode/manager/pull/10632)) +Use `getRestrictedResourceText` utility and move restrictions Notice to top of Volume Create ([#10632](https://github.com/linode/manager/pull/10632))