From 71f114067743c6673dfb17acec825ebde2e638c4 Mon Sep 17 00:00:00 2001 From: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com> Date: Mon, 30 Sep 2024 09:01:41 -0400 Subject: [PATCH] =?UTF-8?q?Revert=20"fix:=20[M3-8424]=20-=20Fix=20CodeQL?= =?UTF-8?q?=20alerts=20for=20`DOM=20text=20reinterpreted=20as=20HTM?= =?UTF-8?q?=E2=80=A6"?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 8a771ca5481efe90f91b296cdaeabf1836936934. --- packages/manager/.changeset/pr-11008-fixed-1727297819528.md | 5 ----- packages/manager/src/session.ts | 4 +--- .../src/store/authentication/authentication.requests.ts | 6 ++---- 3 files changed, 3 insertions(+), 12 deletions(-) delete mode 100644 packages/manager/.changeset/pr-11008-fixed-1727297819528.md diff --git a/packages/manager/.changeset/pr-11008-fixed-1727297819528.md b/packages/manager/.changeset/pr-11008-fixed-1727297819528.md deleted file mode 100644 index 0f3fbbf721f..00000000000 --- a/packages/manager/.changeset/pr-11008-fixed-1727297819528.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -"@linode/manager": Fixed ---- - -Fix CodeQL alerts for DOM text reinterpreted as HTML ([#11008](https://github.com/linode/manager/pull/11008)) diff --git a/packages/manager/src/session.ts b/packages/manager/src/session.ts index 08f109711ea..d6e41fee236 100644 --- a/packages/manager/src/session.ts +++ b/packages/manager/src/session.ts @@ -32,9 +32,7 @@ export const genOAuthEndpoint = ( const query = { client_id: clientID, - redirect_uri: `${APP_ROOT}/oauth/callback?returnTo=${encodeURIComponent( - redirectUri - )}`, + redirect_uri: `${APP_ROOT}/oauth/callback?returnTo=${redirectUri}`, response_type: 'token', scope, state: nonce, diff --git a/packages/manager/src/store/authentication/authentication.requests.ts b/packages/manager/src/store/authentication/authentication.requests.ts index 01b268b6f56..c8973af25ab 100644 --- a/packages/manager/src/store/authentication/authentication.requests.ts +++ b/packages/manager/src/store/authentication/authentication.requests.ts @@ -1,12 +1,10 @@ import { LOGIN_ROOT } from 'src/constants'; -import { revokeToken } from 'src/session'; +import { RevokeTokenSuccess, revokeToken } from 'src/session'; +import { ThunkActionCreator } from 'src/store/types'; import { getEnvLocalStorageOverrides } from 'src/utilities/storage'; import { handleLogout as _handleLogout } from './authentication.actions'; -import type { RevokeTokenSuccess } from 'src/session'; -import type { ThunkActionCreator } from 'src/store/types'; - /** * Revokes auth token used to make HTTP requests *