diff --git a/packages/manager/.changeset/pr-11825-upcoming-features-1741714373810.md b/packages/manager/.changeset/pr-11825-upcoming-features-1741714373810.md new file mode 100644 index 00000000000..debf42e091d --- /dev/null +++ b/packages/manager/.changeset/pr-11825-upcoming-features-1741714373810.md @@ -0,0 +1,5 @@ +--- +"@linode/manager": Upcoming Features +--- + +Removed `sxEndIcon` prop from Add Metric, Dimension Filter and Notification Channel buttons. ([#11825](https://github.com/linode/manager/pull/11825)) diff --git a/packages/manager/src/features/CloudPulse/Alerts/CreateAlert/Criteria/DimensionFilter.tsx b/packages/manager/src/features/CloudPulse/Alerts/CreateAlert/Criteria/DimensionFilter.tsx index 0992d13374b..75a0343caf6 100644 --- a/packages/manager/src/features/CloudPulse/Alerts/CreateAlert/Criteria/DimensionFilter.tsx +++ b/packages/manager/src/features/CloudPulse/Alerts/CreateAlert/Criteria/DimensionFilter.tsx @@ -33,7 +33,6 @@ export const DimensionFilters = (props: DimensionFilterProps) => { }); const dimensionFilterWatcher = useWatch({ control, name }); - return ( @@ -61,13 +60,11 @@ export const DimensionFilters = (props: DimensionFilterProps) => { value: null, }) } - buttonType="secondary" compactX data-qa-buttons="true" disabled={dimensionFilterWatcher && dimensionFilterWatcher.length === 5} size="small" - sx={{ justifyContent: 'start', width: '150px' }} - sxEndIcon={{ display: 'none' }} + sx={{ justifyContent: 'start', width: '160px' }} tooltipText="You can add up to 5 dimension filters." > Add dimension filter diff --git a/packages/manager/src/features/CloudPulse/Alerts/CreateAlert/Criteria/MetricCriteria.tsx b/packages/manager/src/features/CloudPulse/Alerts/CreateAlert/Criteria/MetricCriteria.tsx index 20b5ae9bdcb..db0e92292ed 100644 --- a/packages/manager/src/features/CloudPulse/Alerts/CreateAlert/Criteria/MetricCriteria.tsx +++ b/packages/manager/src/features/CloudPulse/Alerts/CreateAlert/Criteria/MetricCriteria.tsx @@ -1,4 +1,4 @@ -import { Box, Button, Stack, Typography } from '@linode/ui'; +import { Button, Stack, Typography } from '@linode/ui'; import * as React from 'react'; import { useFieldArray, useFormContext, useWatch } from 'react-hook-form'; @@ -66,16 +66,9 @@ export const MetricCriteriaField = (props: MetricCriteriaProps) => { }); return ( - ({ marginTop: theme.spacing(3) })}> - - 3. Criteria - - ({ marginTop: theme.spacing(3) })}> + + 3. Criteria + {fields !== null && fields.length !== 0 && fields.map((field, index) => { @@ -102,15 +95,16 @@ export const MetricCriteriaField = (props: MetricCriteriaProps) => { threshold: 0, }) } + sx={{ + width: '130px', // added a nice width for the button + }} buttonType="outlined" disabled={metricCriteriaWatcher.length === 5} size="medium" - sx={(theme) => ({ marginTop: theme.spacing(2) })} - sxEndIcon={{ display: 'none' }} tooltipText="You can add up to 5 metrics." > Add metric - + ); }; diff --git a/packages/manager/src/features/CloudPulse/Alerts/CreateAlert/NotificationChannels/AddChannelListing.tsx b/packages/manager/src/features/CloudPulse/Alerts/CreateAlert/NotificationChannels/AddChannelListing.tsx index 7112c065ff6..16569bd8243 100644 --- a/packages/manager/src/features/CloudPulse/Alerts/CreateAlert/NotificationChannels/AddChannelListing.tsx +++ b/packages/manager/src/features/CloudPulse/Alerts/CreateAlert/NotificationChannels/AddChannelListing.tsx @@ -166,9 +166,7 @@ export const AddChannelListing = (props: AddChannelListingProps) => { onClick={handleOpenDrawer} size="medium" sx={(theme) => ({ marginTop: theme.spacing(2) })} - sxEndIcon={{ display: 'none' }} tooltipText="You can add up to 5 notification channels." - type="button" > Add notification channel