From 16c6028aabcdda16f3c9bb10dbf8f0e5763c9fb4 Mon Sep 17 00:00:00 2001 From: pmakode-akamai Date: Tue, 15 Apr 2025 14:32:31 +0530 Subject: [PATCH 1/3] Create a new feature flag for ACLP Integration --- packages/manager/src/dev-tools/FeatureFlagTool.tsx | 1 + packages/manager/src/featureFlags.ts | 9 +++++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/manager/src/dev-tools/FeatureFlagTool.tsx b/packages/manager/src/dev-tools/FeatureFlagTool.tsx index 7ece6fb9ccf..6d0204a39e6 100644 --- a/packages/manager/src/dev-tools/FeatureFlagTool.tsx +++ b/packages/manager/src/dev-tools/FeatureFlagTool.tsx @@ -21,6 +21,7 @@ const MOCK_FEATURE_FLAGS_STORAGE_KEY = 'devTools/mock-feature-flags'; const options: { flag: keyof Flags; label: string }[] = [ { flag: 'aclp', label: 'CloudPulse' }, { flag: 'aclpAlerting', label: 'CloudPulse Alerting' }, + { flag: 'aclpIntegration', label: 'ACLP Integration' }, { flag: 'apl', label: 'Akamai App Platform' }, { flag: 'blockStorageEncryption', label: 'Block Storage Encryption (BSE)' }, { flag: 'disableLargestGbPlans', label: 'Disable Largest GB Plans' }, diff --git a/packages/manager/src/featureFlags.ts b/packages/manager/src/featureFlags.ts index 82db293e987..835b41ec09e 100644 --- a/packages/manager/src/featureFlags.ts +++ b/packages/manager/src/featureFlags.ts @@ -107,12 +107,13 @@ interface LimitsEvolution { export interface Flags { acceleratedPlans: AcceleratedPlansFlag; aclp: AclpFlag; - aclpAlertServiceTypeConfig: AclpAlertServiceTypeConfig[]; aclpAlerting: AclpAlerting; + aclpAlertServiceTypeConfig: AclpAlertServiceTypeConfig[]; + aclpIntegration: boolean; aclpReadEndpoint: string; aclpResourceTypeMap: CloudPulseResourceTypeMapFlag[]; - apiMaintenance: APIMaintenance; apicliButtonCopy: string; + apiMaintenance: APIMaintenance; apl: boolean; blockStorageEncryption: boolean; cloudManagerDesignUpdatesBanner: DesignUpdatesBannerFlag; @@ -136,8 +137,8 @@ export interface Flags { marketplaceAppOverrides: MarketplaceAppOverride[]; metadata: boolean; nodebalancerVpc: boolean; - objMultiCluster: boolean; objectStorageGen2: BaseFeatureFlag; + objMultiCluster: boolean; productInformationBanners: ProductInformationBannerFlag[]; promos: boolean; promotionalOffers: PromotionalOffer[]; @@ -148,8 +149,8 @@ export interface Flags { supportTicketSeverity: boolean; taxBanner: TaxBanner; taxCollectionBanner: TaxCollectionBanner; - taxId: BaseFeatureFlag; taxes: Taxes; + taxId: BaseFeatureFlag; tpaProviders: Provider[]; udp: boolean; vmHostMaintenance: BetaFeatureFlag; From 0e8944b2ff65edf150d39fe50abc4b3fcdebb38b Mon Sep 17 00:00:00 2001 From: pmakode-akamai Date: Tue, 15 Apr 2025 14:53:28 +0530 Subject: [PATCH 2/3] Added changeset: Feature flag for ACLP Integration --- .../.changeset/pr-12026-upcoming-features-1744709007966.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 packages/manager/.changeset/pr-12026-upcoming-features-1744709007966.md diff --git a/packages/manager/.changeset/pr-12026-upcoming-features-1744709007966.md b/packages/manager/.changeset/pr-12026-upcoming-features-1744709007966.md new file mode 100644 index 00000000000..806da08fff2 --- /dev/null +++ b/packages/manager/.changeset/pr-12026-upcoming-features-1744709007966.md @@ -0,0 +1,5 @@ +--- +"@linode/manager": Upcoming Features +--- + +Feature flag for ACLP Integration ([#12026](https://github.com/linode/manager/pull/12026)) From 7e1bacdae390244a57657c484634fe75b3d98a7d Mon Sep 17 00:00:00 2001 From: pmakode-akamai Date: Tue, 15 Apr 2025 15:01:52 +0530 Subject: [PATCH 3/3] Random eslint warning fixes --- packages/manager/src/dev-tools/FeatureFlagTool.tsx | 2 +- packages/manager/src/featureFlags.ts | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/manager/src/dev-tools/FeatureFlagTool.tsx b/packages/manager/src/dev-tools/FeatureFlagTool.tsx index 6d0204a39e6..1326128d12b 100644 --- a/packages/manager/src/dev-tools/FeatureFlagTool.tsx +++ b/packages/manager/src/dev-tools/FeatureFlagTool.tsx @@ -7,7 +7,7 @@ import { useFlags } from 'src/hooks/useFlags'; import { setMockFeatureFlags } from 'src/store/mockFeatureFlags'; import { getStorage, setStorage } from 'src/utilities/storage'; -import type { FlagSet, Flags } from 'src/featureFlags'; +import type { Flags, FlagSet } from 'src/featureFlags'; import type { Dispatch } from 'src/hooks/types'; const MOCK_FEATURE_FLAGS_STORAGE_KEY = 'devTools/mock-feature-flags'; diff --git a/packages/manager/src/featureFlags.ts b/packages/manager/src/featureFlags.ts index 835b41ec09e..cde0e47b85b 100644 --- a/packages/manager/src/featureFlags.ts +++ b/packages/manager/src/featureFlags.ts @@ -165,7 +165,7 @@ interface MarketplaceAppOverride { * * Pass `null` to hide the marketplace app */ - details: Partial | null; + details: null | Partial; /** * The ID of the StackScript that powers this Marketplace app */ @@ -256,8 +256,8 @@ export type ProductInformationBannerLocation = | 'Object Storage' | 'Placement Groups' | 'StackScripts' - | 'VPC' - | 'Volumes'; + | 'Volumes' + | 'VPC'; interface ProductInformationBannerDecoration { important: 'false' | 'true' | boolean;