From 6afb3d324086bd6780f45e456db36b489ceba0d7 Mon Sep 17 00:00:00 2001 From: Hana Xu Date: Tue, 1 Jul 2025 12:50:27 -0400 Subject: [PATCH 1/2] clean up getLinodeXFilter function --- .../LinodeCreate/shared/LinodeSelectTable.test.tsx | 6 +++--- .../Linodes/LinodeCreate/shared/LinodeSelectTable.tsx | 8 +------- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/packages/manager/src/features/Linodes/LinodeCreate/shared/LinodeSelectTable.test.tsx b/packages/manager/src/features/Linodes/LinodeCreate/shared/LinodeSelectTable.test.tsx index edabb972b9a..cb3f3a8986c 100644 --- a/packages/manager/src/features/Linodes/LinodeCreate/shared/LinodeSelectTable.test.tsx +++ b/packages/manager/src/features/Linodes/LinodeCreate/shared/LinodeSelectTable.test.tsx @@ -37,13 +37,13 @@ describe('Linode Select Table', () => { }); it('should filter out Linodes in distributed regions', () => { - const { filter } = getLinodeXFilter(undefined, ''); + const { filter } = getLinodeXFilter(''); expect(filter).toHaveProperty('site_type', 'core'); }); it('should search for label, id, ipv4, tags', () => { - const { filter } = getLinodeXFilter(undefined, '12345678'); + const { filter } = getLinodeXFilter('12345678'); expect(filter).toStrictEqual({ '+or': [ @@ -57,7 +57,7 @@ describe('Linode Select Table', () => { }); it('should return an error if the x-filter is invalid', () => { - const { filterError } = getLinodeXFilter(undefined, '123 456'); + const { filterError } = getLinodeXFilter('123 456'); expect(filterError).toHaveProperty( 'message', diff --git a/packages/manager/src/features/Linodes/LinodeCreate/shared/LinodeSelectTable.tsx b/packages/manager/src/features/Linodes/LinodeCreate/shared/LinodeSelectTable.tsx index da86197fe67..a7ff1dfaa5d 100644 --- a/packages/manager/src/features/Linodes/LinodeCreate/shared/LinodeSelectTable.tsx +++ b/packages/manager/src/features/Linodes/LinodeCreate/shared/LinodeSelectTable.tsx @@ -93,12 +93,7 @@ export const LinodeSelectTable = (props: Props) => { preferenceKey: 'linode-clone-select-table', }); - const { filter, filterError } = getLinodeXFilter( - preselectedLinodeId ? Number(preselectedLinodeId) : undefined, - query, - order, - orderBy - ); + const { filter, filterError } = getLinodeXFilter(query, order, orderBy); const { data, error, isFetching, isLoading } = useLinodesQuery( { @@ -253,7 +248,6 @@ export const LinodeSelectTable = (props: Props) => { }; export const getLinodeXFilter = ( - _preselectedLinodeId: number | undefined, query: string, order?: Order, orderBy?: string From dab7ff8766852e1e30c0d7c5b4735446f36de1e0 Mon Sep 17 00:00:00 2001 From: Hana Xu Date: Tue, 1 Jul 2025 12:55:36 -0400 Subject: [PATCH 2/2] Added changeset: Clean up getLinodeXFilter function --- .../.changeset/pr-12452-tech-stories-1751388936476.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 packages/manager/.changeset/pr-12452-tech-stories-1751388936476.md diff --git a/packages/manager/.changeset/pr-12452-tech-stories-1751388936476.md b/packages/manager/.changeset/pr-12452-tech-stories-1751388936476.md new file mode 100644 index 00000000000..f7d2e9f630f --- /dev/null +++ b/packages/manager/.changeset/pr-12452-tech-stories-1751388936476.md @@ -0,0 +1,5 @@ +--- +"@linode/manager": Tech Stories +--- + +Clean up getLinodeXFilter function ([#12452](https://github.com/linode/manager/pull/12452))