Integrate upstream changes

[joe4dev]

Motivation

The official AWS lambda-runtime-init received some upstream updates (typically merged in big blobs from their internal repository). We should update our customized localstack version to support the latest features (e.g., response streaming) and updates (e.g., the new Golang version). Beyond smaller doc updates, the main updates were:

• Jun 8, 2023 chore(deps): Update to Golang 1.19 (#95) ⇒ Easy deps upgrade to Go 1.19
• Apr 27, 2023 feat: Pull upstream changes 2023/04 (#87) ⇒ Major changes to the init and internal API (6,845 additions and 2,726 deletions)

Background

Internal docs: https://www.notion.so/localstack/Update-RIE-with-upstream-changes-for-response-streaming-18a303b503c54f958cfbee5841ef5402?pvs=4

Changes

Integrates the upstream changes from the AWS lambda-runtime-init repo and adjusts the API accordingly (see documented commit log for details).

👉 Custom LocalStack changes git diff 8b003ee53ffe758979cf64f43f6ae58363efcc2d..integrate-upstream-changes

Testing

Test against the LocalStack test suite.

🧪 The localstack branch integrate-lambda-init-upstream-changes contains some improved tests for the request_id propagation issue. For example: tests.aws.services.lambda_.test_lambda.TestRequestIdHandling.test_request_id_invoke

I tested other categories including:

• tests.aws.services.lambda_.test_lambda.TestLambdaBaseFeatures
• tests.aws.services.lambda_.test_lambda.TestRequestIdHandling

TODO

• Fix failing snapshot test due to uuid not being replaced in the test tests.aws.services.lambda_.test_lambda.TestLambdaFeatures.test_invocation_with_qualifier
• Resolve TODOs (mostly coding out some logs, error handling etc)
• Rebase after merging the permission PR Fix filesystem permission parity #22 => Merged the localstack branch back as a quickfix because rebasing again is terrible with so many conflicts 😢

[dfangl]

It's rather hard to get through everything, but our changes look good. Let's see if the LS tests pass :)

[joe4dev]

Fixed the error reporting to use the new dedicated callback for SendInitErrorResponse

Other issues discovered during testing:

• It appears the test TestLambdaRuntimesCommon.test_introspection_invoke fails for for the runtimes python3_7, java8, java8_al2, java11, java17, go1_x, provided, provided_al2 due the two missing environment variables PWD=/var/task and SHLVL=0. These are part of CustomerEnvironmentVariables but just not available anymore for some runtimes 🙃 I also updated the snapshots but nothing has changed at real AWS.
• go1.x runtime tests fail for me locally but that might be an issue with the ARM build. Both the previous init and these changes yield an error 2023-10-17 21:20:08 time="2023-10-17T19:20:08Z" level=warning msg="Process 19(bootstrap) exited: Runtime exited with error: signal: trace/breakpoint trap" func="go.amzn.com/lambda/core.(*Watchdog).GoWait.func1" file="/home/runner/work/lambda-runtime-init/lambda-runtime-init/lambda/core/watchdog.go:67"
• Several more tests fail on macOS, most of them due to port in use when using multiple Lambda functions. Including: test_lambda_different_iam_keys_environment, test_runtime_introspection_arm (due to different debug env), test_lambda_concurrency_block, test_provisioned_concurrency, test_reserved_concurrency_async_queue, test_lambda_versions_with_code_changes, test_lambda_alias_moving, test_alias_routingconfig

[joe4dev]

It's rather hard to get through everything, but our changes look good. Let's see if the LS tests pass :)

Yeah, I think we just need to release an imperfect "-dev" version to get a good overview from a LocalStack CI run. (we could consider short-lived feature-branch artifacts in the future if velocity becomes a challenge)