Repository navigation
treat .svg files as images - #40
Merged
Merged
Conversation
Owner
|
Agreed, svg files should be enclosed in a img tag |
biati-digital
approved these changes
Dec 4, 2018
biati-digital
approved these changes
Dec 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the way svg files are treated. Before, they were enclosed in an
<iframe>. Now they are treated as other images, enclosed in an<img>tag.Pros:
<img>tag allows loading svg files from arbitrary urls, without SOP restrictions.Cons:
<iframe>allows svg files to be interactive.So, this might or might not be wanted - but it seems we currently don't have a way to override the url based heuristics in
getSourceType()to set desired source type.