Filter --reply based on specified channel index#883
Merged
Conversation
Ensures that automatic replies are sent back on the same channel index the message was received on. Previously, all replies defaulted to the primary channel (0), even if the incoming message arrived on a secondary channel. Additionally it ensures incoming messages match the specified channel index. E.g: meshtastic --ch-index 1 --reply . Modified the `onReceive` handler to extract the `channel` index from received packets. This ensures `interface.sendText` targets the originating channel rather than always defaulting to the primary channel. Added a filter to ensure that only the specified channel index is being replied to.
Contributor
|
Thanks for the pull request! I've merged it and also added a bit of a note to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where automatic replies generated by the
--replyflag were incorrectly routed and unfiltered.Changes
Channel Routing: Responses are now explicitly sent back on the same channel index the message was received on, rather than defaulting to the primary channel (0).
Channel Filtering: The
--replyaction now respects the--ch-indexflag. It will only trigger a response if the incoming message matches the user-specified channel.Behavior Comparison
Command:
meshtastic --ch-index 1 --replyTechnical Implementation
The
onReceivehandler now castsargs.ch_indexto an integer and performs a comparison against thechannelfield in the incoming packet before callinginterface.sendText().