Why isn't my overlay port being built please?

[perdrix52]

I updated the vcpkg-configuration.json in my project folder to read:

{
  "registries": [
    {
      "kind": "artifact",
      "location": "https://github.com/microsoft/vcpkg-ce-catalog/archive/refs/heads/main.zip",
      "name": "microsoft"
    }
  ],
   "overlay-ports": [
    "./vcpkg_overlay_ports"
  ]
}

vcpkg_overlay_ports directory contains a directory called cfitsio which contains:
portfile.cmake:

vcpkg_check_linkage(ONLY_STATIC_LIBRARY)

vcpkg_from_github(
    OUT_SOURCE_PATH SOURCE_PATH
    REPO HEASARC/cfitsio
    REF "${VERSION}"
    SHA512 0  # This is a temporary value. We will modify this value in the next section.
    HEAD_REF main
)

set (options
	"-DBUILD_SHARED_LIBS=OFF"
	"-DUSE_BZIP2=ON"
)
if(WIN32)
	set (options "${options} -DUSE_PTHREADS=OFF")
else()
	set (options "${options} -DUSE_PTHREADS=ON")
endif()

if(APPLE)
	set (options "${options} -DCMAKE_OSX_ARCHITECTURES:STRING=x86_64;arm64")
endif()

vcpkg_cmake_configure(
    SOURCE_PATH "${SOURCE_PATH}"
	OPTIONS "${options}"
)

vcpkg_cmake_install()

file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include")

file(INSTALL "${CMAKE_CURRENT_LIST_DIR}/usage" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}")
vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/licenses/License.txt")

a usage file and a vcpkg.json:

{
  "name": "cfitsio",
  "version": "4.6.2",
  "homepage": "https://heasarc.gsfc.nasa.gov/fitsio/fitsio.html",
  "description": "CFITSIO - A FITS File Subroutine Library.",
  "dependencies": [
    {
      "name" : "vcpkg-cmake",
      "host" : true
    },
    {
      "name" : "vcpkg-cmake-config",
      "host" : true
    },
	"bzip2",
	"zlib"
  ]
}

When I try to use this I get:

[CMake] D:\Github\DSS\./vcpkg_overlay_ports\cfitsio: info: installing overlay port from here
1> [CMake] Downloading https://github.com/HEASARC/cfitsio/archive/4.6.2.tar.gz -> HEASARC-cfitsio-4.6.2.tar.gz
1> [CMake] error: https://github.com/HEASARC/cfitsio/archive/4.6.2.tar.gz: failed: status code 404

What have I got wrong please?

[perdrix52]

A comment that may be relevant - why try to DL a .tar.gz file on a Windows system (which this was running on)? A .zip file would seem to make more sense ,,,

David

[perdrix52]

Problem solved - needed REF cfitsio-${VERSION}