From 7668fa9c8d14d31b3e31154305621202ea1eb499 Mon Sep 17 00:00:00 2001 From: Jannik Stehle Date: Tue, 25 Aug 2026 14:37:10 +0200 Subject: [PATCH] feat: improve shares navigation, checkbox contrast, search drop Slightly improve the visual appearance of the shares navigation, reduce the contrast of checkboxes and input placeholders to be less distracting while still being a11y compliant and align the search drop with other drop menus. --- .../src/components/OcCheckbox/OcCheckbox.vue | 2 +- .../src/components/OcSearchBar/OcSearchBar.vue | 1 + .../src/components/OcSelect/OcSelect.vue | 2 +- .../unit/views/__snapshots__/Spaces.spec.ts.snap | 2 +- .../unit/views/__snapshots__/Users.spec.ts.snap | 8 ++++---- .../src/components/AppBar/SharesNavigation.vue | 14 +++++++++----- .../__snapshots__/SharesNavigation.spec.ts.snap | 16 +++++----------- .../spaces/__snapshots__/Projects.spec.ts.snap | 2 +- .../trash/__snapshots__/Overview.spec.ts.snap | 2 +- .../web-app-search/src/portals/SearchBar.vue | 4 ++-- .../__snapshots__/ResourceTiles.spec.ts.snap | 4 ++-- 11 files changed, 28 insertions(+), 29 deletions(-) diff --git a/packages/design-system/src/components/OcCheckbox/OcCheckbox.vue b/packages/design-system/src/components/OcCheckbox/OcCheckbox.vue index 1ce6086d833..de0057b638f 100644 --- a/packages/design-system/src/components/OcCheckbox/OcCheckbox.vue +++ b/packages/design-system/src/components/OcCheckbox/OcCheckbox.vue @@ -12,7 +12,7 @@ 'align-middle', 'm-0.5', 'border-2', - 'border-role-outline', + 'border-role-outline/80', 'outline-0', 'outline-role-secondary', 'focus-visible:outline', diff --git a/packages/design-system/src/components/OcSearchBar/OcSearchBar.vue b/packages/design-system/src/components/OcSearchBar/OcSearchBar.vue index 480dc196ab0..c19c09e49c8 100644 --- a/packages/design-system/src/components/OcSearchBar/OcSearchBar.vue +++ b/packages/design-system/src/components/OcSearchBar/OcSearchBar.vue @@ -203,6 +203,7 @@ const inputClass = computed(() => { const classes = [ 'oc-search-input', 'oc-input', + 'placeholder:text-role-outline', 'disabled:cursor-not-allowed', 'focus:bg-none', 'focus:outline focus:outline-offset-2 focus:outline-white' diff --git a/packages/design-system/src/components/OcSelect/OcSelect.vue b/packages/design-system/src/components/OcSelect/OcSelect.vue index 366a8e36c5c..592d657fe0e 100644 --- a/packages/design-system/src/components/OcSelect/OcSelect.vue +++ b/packages/design-system/src/components/OcSelect/OcSelect.vue @@ -524,7 +524,7 @@ export default { components: { VueSelect } } } .oc-select .vs__search::placeholder { - color: var(--oc-role-on-surface-variant); + color: var(--oc-role-outline); } .oc-select :is(.vs__dropdown-toggle, .vs__dropdown-menu) { diff --git a/packages/web-app-admin-settings/tests/unit/views/__snapshots__/Spaces.spec.ts.snap b/packages/web-app-admin-settings/tests/unit/views/__snapshots__/Spaces.spec.ts.snap index 2d87df1a928..62bc3ec2538 100644 --- a/packages/web-app-admin-settings/tests/unit/views/__snapshots__/Spaces.spec.ts.snap +++ b/packages/web-app-admin-settings/tests/unit/views/__snapshots__/Spaces.spec.ts.snap @@ -16,7 +16,7 @@ exports[`Spaces view > loading states > should render spaces list after loading