Repository navigation
Benchmark or remove hard-coded pallet weights #192
Description
Multiple pallets do not use correct weights, as discovered in paritytech/substrate#13798:
- Sudo Benchmark pallet
sudosubstrate#13812 - Membership
- Scored pool
- Nicks
- template Use proper weights in the
pallet-templatesubstrate#13761 (This is being worked on)
Options are to either benchmark all these pallets or deprecate/decommission them. I am in favour or the latter, if possible.
Metadata
Metadata
Assignees
Labels
Type
Projects
- Status
- Status
Activity
Ignore hardcoded weight warning
Uniform pallet warnings (#13798)
iTranscend commentedon Apr 11, 2023
Hi @ggwpez. I'd like to pick up this issue.
Please can you assign it to me?
ggwpez commentedon Apr 11, 2023
Yes thanks @iTranscend!
I think the sudo pallet will definitely not be deleted.
As for
Nickswe can probably delete it. And also not sure about theMembershipandscored-pool…Doordashcon commentedon Apr 11, 2023
@iTranscend Just seeing that you are assigned to this, already made a push for
pallet_sudo🫡ggwpez commentedon Apr 11, 2023
Okay @Doordashcon please always report in the issue first to avoid race-conditions like this 😆
@iTranscend the
Membershippallet is still used by a lot of para-chains as TechnicalCommitee, so that would also be a good candidate - even if we eventually move it out of the Substrate repo.iTranscend commentedon Apr 11, 2023
Haha, race-conditions 😆
That's fine. I'll take up the
membershippallet instead.Doordashcon commentedon Apr 11, 2023
Noted with thanks @ggwpez
Uniform pallet warnings (#13798)
Uniform pallet warnings (paritytech#13798)