From e6abe81eda31f70e64f7a55eebb1e21d164a3573 Mon Sep 17 00:00:00 2001
From: none23 <n.anisimov.23@gmail.com>
Date: Sun, 30 Aug 2026 21:39:16 +0400
Subject: [PATCH] fix(mobile): default non-git projects to the current checkout

The new-task composer let a worktree default (from project settings,
t3.json, or the server default) apply to projects that are not git
repos, so drafts and queued tasks could carry a worktree mode and
branch that cannot exist there.

Resolve the workspace selection through one helper that forces
local/no-branch/no-worktree whenever the project is not a repo, apply
it in the flow provider (live selection and queued-task drain) and the
draft screen, and hide the workspace/branch controls for non-git
projects. Repo capability comes from the unfiltered branches query,
which still answers offline; until it loads, the requested mode is
preserved rather than silently rewritten.
---
 .../features/threads/NewTaskDraftScreen.tsx   | 25 ++++++++----
 .../threads/new-task-context-presentation.ts  | 11 ++++++
 .../threads/new-task-flow-provider.tsx        | 39 +++++++++++++++----
 3 files changed, 59 insertions(+), 16 deletions(-)

diff --git a/apps/mobile/src/features/threads/NewTaskDraftScreen.tsx b/apps/mobile/src/features/threads/NewTaskDraftScreen.tsx
index 8f8cf485f6f8..e44a7d229ec1 100644
--- a/apps/mobile/src/features/threads/NewTaskDraftScreen.tsx
+++ b/apps/mobile/src/features/threads/NewTaskDraftScreen.tsx
@@ -91,6 +91,7 @@ import { resolveProjectThreadCreationBranch } from "./projectThreadCreationValid
 import { useCreateProjectThread } from "./use-project-actions";
 import { resolveDraftProjectSelection } from "./new-task-project-selection";
 import {
+  applyNonGitWorkspaceFallback,
   resolveNewTaskBranchLabel,
   resolveNewTaskWorkspaceLabel,
 } from "./new-task-context-presentation";
@@ -866,10 +867,18 @@ export function NewTaskDraftScreen(props: {
         selectedEnvironmentServerConfig,
         draft.modelSelection ?? null,
       ) ?? flow.selectedModel;
-    const workspaceMode = draft.workspaceSelection?.mode ?? flow.workspaceMode;
-    const selectedBranchName = draft.workspaceSelection?.branch ?? flow.selectedBranchName;
-    const selectedWorktreePath =
-      draft.workspaceSelection?.worktreePath ?? flow.selectedWorktreePath;
+    const workspaceSelection = applyNonGitWorkspaceFallback({
+      selection: draft.workspaceSelection,
+      fallback: {
+        mode: flow.workspaceMode,
+        branch: flow.selectedBranchName,
+        worktreePath: flow.selectedWorktreePath,
+      },
+      isGitRepo: flow.isGitRepo,
+    });
+    const workspaceMode = workspaceSelection.mode;
+    const selectedBranchName = workspaceSelection.branch;
+    const selectedWorktreePath = workspaceSelection.worktreePath;
     const startFromOrigin = draft.workspaceSelection?.startFromOrigin ?? flow.startFromOrigin;
     const runtimeMode = draft.runtimeMode ?? flow.runtimeMode;
     const interactionMode = flow.planModeEnabled
@@ -1158,8 +1167,8 @@ export function NewTaskDraftScreen(props: {
     </View>
   );
 
-  const workspaceControls = (
-    <View className="flex-row items-center gap-1 px-2">
+  const workspaceControls = flow.isGitRepo ? (
+    <View className="flex-row items-center gap-1 px-2 pb-1">
       {flow.submitting && environmentConnected && flow.workspaceMode === "worktree" ? (
         <View
           accessible
@@ -1205,7 +1214,7 @@ export function NewTaskDraftScreen(props: {
         </>
       )}
     </View>
-  );
+  ) : null;
 
   const composerDock = (
     <View className="bg-sheet px-[12px] pt-1" style={{ paddingBottom: controlsBottomPadding }}>
@@ -1219,7 +1228,7 @@ export function NewTaskDraftScreen(props: {
           />
         </View>
       ) : null}
-      <View className="pb-1">{workspaceControls}</View>
+      {workspaceControls}
 
       <ComposerSurface
         style={{
diff --git a/apps/mobile/src/features/threads/new-task-context-presentation.ts b/apps/mobile/src/features/threads/new-task-context-presentation.ts
index 99eee3ea48ae..c1966a979a7f 100644
--- a/apps/mobile/src/features/threads/new-task-context-presentation.ts
+++ b/apps/mobile/src/features/threads/new-task-context-presentation.ts
@@ -1,5 +1,16 @@
+import type { ComposerDraftWorkspaceSelection } from "../../state/use-composer-drafts";
+
 type WorkspaceMode = "local" | "worktree";
 
+export function applyNonGitWorkspaceFallback(input: {
+  readonly selection: ComposerDraftWorkspaceSelection | null | undefined;
+  readonly fallback: ComposerDraftWorkspaceSelection;
+  readonly isGitRepo: boolean;
+}): ComposerDraftWorkspaceSelection {
+  const selection = input.selection ?? input.fallback;
+  return input.isGitRepo ? selection : { mode: "local" as const, branch: null, worktreePath: null };
+}
+
 export function resolveNewTaskWorkspaceLabel(input: {
   readonly workspaceMode: WorkspaceMode;
   readonly worktreePath: string | null;
diff --git a/apps/mobile/src/features/threads/new-task-flow-provider.tsx b/apps/mobile/src/features/threads/new-task-flow-provider.tsx
index 792bb143a834..4a8924aa0611 100644
--- a/apps/mobile/src/features/threads/new-task-flow-provider.tsx
+++ b/apps/mobile/src/features/threads/new-task-flow-provider.tsx
@@ -59,7 +59,7 @@ import {
   capturePendingTaskEditorWriteBaseline,
   flushPendingTaskEditorWrite,
 } from "../../state/pending-task-editor-writes";
-import { useDebouncedValue, usePaginatedBranches } from "../../state/queries";
+import { useBranches, useDebouncedValue, usePaginatedBranches } from "../../state/queries";
 import { vcsEnvironment } from "../../state/vcs";
 import {
   flattenQueuedThreadMessages,
@@ -86,6 +86,7 @@ import { useMobileProjectGroupingSettings } from "../../state/project-grouping";
 import { resolvePendingTaskInteractionMode } from "./legacy-plan-mode";
 import { useLegacyPlanModeState } from "./use-legacy-plan-mode-enabled";
 import {
+  applyNonGitWorkspaceFallback,
   resolveNewTaskBranchWorktreePath,
   resolveNewTaskLocalWorkspaceSelection,
 } from "./new-task-context-presentation";
@@ -133,6 +134,7 @@ type NewTaskFlowContextValue = {
   readonly selectedProjectKey: string | null;
   readonly selectedModelKey: string | null;
   readonly workspaceMode: WorkspaceMode;
+  readonly isGitRepo: boolean;
   readonly selectedBranchName: string | null;
   readonly selectedWorktreePath: string | null;
   readonly startFromOrigin: boolean;
@@ -371,6 +373,14 @@ export function NewTaskFlowProvider(props: React.PropsWithChildren) {
   const selectedProjectDraft = useComposerDraft(selectedProjectDraftKey);
   const prompt = selectedProjectDraft.text;
   const attachments = selectedProjectDraft.attachments;
+  // Keep repo capability unfiltered so branch search cannot drop it; unlike
+  // the live status query below, refs also remain available offline.
+  const projectBranches = useBranches({
+    environmentId: selectedProject?.environmentId ?? null,
+    cwd: selectedProject?.workspaceRoot || null,
+  });
+  // Until capability loads, preserve the requested mode rather than silently changing it.
+  const isGitRepo = projectBranches.data?.isRepo ?? true;
   // Default mode until the user picks one explicitly — same resolution web
   // uses for new draft threads: per-project setting, then the repo's
   // checked-in t3.json, then the server's configured default.
@@ -392,6 +402,12 @@ export function NewTaskFlowProvider(props: React.PropsWithChildren) {
     projectFile: t3ProjectFileDefaultMode,
     globalDefault: selectedEnvironmentServerConfig?.settings.defaultThreadEnvMode ?? "local",
   });
+  const resolvedWorkspaceSelection = applyNonGitWorkspaceFallback({
+    selection: selectedProjectDraft.workspaceSelection,
+    fallback: { mode: defaultWorkspaceMode, branch: null, worktreePath: null },
+    isGitRepo,
+  });
+  const workspaceMode = resolvedWorkspaceSelection.mode;
   // While unsettled the resolved default is provisional. Nothing may write
   // it into the draft during that window (the auto-branch effect does), or
   // the frozen interim value beats the t3.json default once it loads.
@@ -400,9 +416,8 @@ export function NewTaskFlowProvider(props: React.PropsWithChildren) {
     projectSetting: selectedProject?.defaultThreadEnvMode,
     projectFilePending: t3ProjectFileQuery.isPending,
   });
-  const workspaceMode = selectedProjectDraft.workspaceSelection?.mode ?? defaultWorkspaceMode;
-  const selectedBranchName = selectedProjectDraft.workspaceSelection?.branch ?? null;
-  const selectedWorktreePath = selectedProjectDraft.workspaceSelection?.worktreePath ?? null;
+  const selectedBranchName = resolvedWorkspaceSelection.branch;
+  const selectedWorktreePath = resolvedWorkspaceSelection.worktreePath;
   // Keep the user's explicit choice separate from the resolved display value:
   // only the explicit flag is ever written back to the draft, so the resolved
   // value keeps tracking the server setting when the config loads late.
@@ -872,7 +887,11 @@ export function NewTaskFlowProvider(props: React.PropsWithChildren) {
       const workspaceSelection = draft.workspaceSelection;
       // Fall back to the resolved mode (server default) so queued tasks drain
       // with the same mode the composer displayed.
-      const mode = workspaceSelection?.mode ?? workspaceMode;
+      const resolvedSelection = applyNonGitWorkspaceFallback({
+        selection: workspaceSelection,
+        fallback: { mode: workspaceMode, branch: null, worktreePath: null },
+        isGitRepo,
+      });
       // When the selection is the stand-in built from the queued snapshot,
       // persist the original (possibly absent) snapshot values — the
       // stand-in's placeholder title/workspaceRoot must never be written back
@@ -903,13 +922,14 @@ export function NewTaskFlowProvider(props: React.PropsWithChildren) {
           projectId: selectedProject.id,
           ...(projectTitle !== undefined ? { projectTitle } : {}),
           ...(projectCwd !== undefined ? { projectCwd } : {}),
-          workspaceMode: mode,
+          workspaceMode: resolvedSelection.mode,
           // Only an explicit picker choice, never the current checkout: a
           // queued local task drains days later against whatever is checked
           // out then, so recording a queue-time guess would pin a stale label
           // to a thread that ran somewhere else.
-          branch: workspaceSelection?.branch ?? null,
-          worktreePath: mode === "worktree" ? null : (workspaceSelection?.worktreePath ?? null),
+          branch: resolvedSelection.branch,
+          worktreePath:
+            resolvedSelection.mode === "worktree" ? null : resolvedSelection.worktreePath,
           // The draft only carries the flag when the user touched it; fall
           // back to the resolved default (server settings) so queued tasks
           // drain with the same origin mode the composer displayed.
@@ -923,6 +943,7 @@ export function NewTaskFlowProvider(props: React.PropsWithChildren) {
     [
       editingPendingProject,
       editingPendingTask,
+      isGitRepo,
       selectedEnvironmentServerConfig,
       selectedModel,
       selectedProject,
@@ -1043,6 +1064,7 @@ export function NewTaskFlowProvider(props: React.PropsWithChildren) {
       selectedProjectKey,
       selectedModelKey,
       workspaceMode,
+      isGitRepo,
       selectedBranchName,
       selectedWorktreePath,
       startFromOrigin,
@@ -1112,6 +1134,7 @@ export function NewTaskFlowProvider(props: React.PropsWithChildren) {
       filteredBranches,
       finishEditingPendingTask,
       interactionMode,
+      isGitRepo,
       planModeEnabled,
       loadBranches,
       loadMoreBranches,