Many places have missing PyErr_NoMemory() call after failing memory allocation

Crash report

remove_unused_consts in Python/flowgraph.c

When PyMem_Malloc(nconsts * sizeof(Py_ssize_t)); fails, we need to set an exception.

Lines 3267 to 3283 in 29a920e

    
           static int 
        
           remove_unused_consts(basicblock *entryblock, PyObject *consts) 
        
           { 
        
               assert(PyList_CheckExact(consts)); 
        
               Py_ssize_t nconsts = PyList_GET_SIZE(consts); 
        
               if (nconsts == 0) { 
        
                   return SUCCESS;  /* nothing to do */ 
        
               } 
        
               Py_ssize_t *index_map = NULL; 
        
               Py_ssize_t *reverse_index_map = NULL; 
        
               int err = ERROR; 
        
               index_map = PyMem_Malloc(nconsts * sizeof(Py_ssize_t)); 
        
               if (index_map == NULL) { 
        
                   goto end; 
        
               }

gethandlelist and getattributelist in _winapi.c

This place misses it:

cpython/Modules/_winapi.c

Lines 1196 to 1198 in 9fdbade

    
           ret = PyMem_Malloc(*size); 
        
           if (ret == NULL) 
        
               goto cleanup;

All other error paths set exceptions, except this if:

cpython/Modules/_winapi.c

Lines 1278 to 1282 in 9fdbade

    
           attribute_list->attribute_list = PyMem_Malloc(attribute_list_size); 
        
           if (attribute_list->attribute_list == NULL) { 
        
               ret = -1; 
        
               goto cleanup; 
        
           }

_channelends_new in Modules/_interpchannelsmodule.c

cpython/Modules/_interpchannelsmodule.c

Lines 920 to 926 in 3ca93ab

    
           static _channelends * 
        
           _channelends_new(void) 
        
           { 
        
               _channelends *ends = GLOBAL_MALLOC(_channelends); 
        
               if (ends== NULL) { 
        
                   return NULL; 
        
               }

Later we check for errors in handle_channel_error, it requires either setting err to non -1 or to set Python exception. Both are false, it fails with the assertion failure.

Linked PRs

[3.15] gh-151126: Add missing `PyErr_NoMemory` in `_winapi` module (G…

pythongh-151126: Add missing `PyErr_NoMemory` in `_winapi` module (py…

gh-151126: Fix missing memory errors in `_interpchannelsmodule.c` (#1…

[3.15] gh-151126: Fix missing memory errors in `_interpchannelsmodule…

[3.13] gh-151126: Fix missing memory errors in `_interpchannelsmodule…

[3.14] gh-151126: Fix missing memory errors in `_interpchannelsmodule…

gh-151126: Fix missing memory error in `os._path_splitroot` (#151339)

[3.13] gh-151126: Fix missing memory error in `os._path_splitroot` (G…

[3.14] gh-151126: Fix missing memory error in `os._path_splitroot` (G…

[3.15] gh-151126: Fix missing memory error in `os._path_splitroot` (G…

gh-151126: Fix crash on unset memory error in `ctypes.get_errno` (#15…

[3.13] gh-151126: Fix crash on unset memory error in `ctypes.get_errn…

[3.14] gh-151126: Fix crash on unset memory error in `ctypes.get_errn…

[3.15] gh-151126: Fix crash on unset memory error in `ctypes.get_errn…

pythongh-151126: Fix missing `PyErr_NoMemory()` in `remove_unused_con…

pythongh-151126: Add missing `PyErr_NoMemory` in `_winapi` module (py…

pythongh-151126: Fix missing memory errors in `_interpchannelsmodule.…

pythongh-151126: Fix missing memory error in `os._path_splitroot` (py…

pythongh-151126: Fix crash on unset memory error in `ctypes.get_errno` (

gh-151126: Fix missing `PyErr_NoMemory` in `getpath.c` (#151590)

gh-151126: Add missing `PyErr_NoMemory()` in `type_from_slots_or_spec` (

[3.13] gh-151126: Add missing `PyErr_NoMemory()` in `type_from_slots_…

[3.14] gh-151126: Add missing `PyErr_NoMemory()` in `type_from_slots_…

[3.15] gh-151126: Add missing `PyErr_NoMemory()` in `type_from_slots_…

gh-151126: Fix missing memory errors in `_interpretersmodule.c` (#151624

[3.14] gh-151126: Fix missing memory errors in `_interpretersmodule.c` (

gh-151126: Fix missing `PyErr_NoMemory` in `testinternalcapi.c` (#152177

[3.13] gh-151126: Fix missing `PyErr_NoMemory` in `testinternalcapi.c` (

[3.14] gh-151126: Fix missing `PyErr_NoMemory` in `testinternalcapi.c` (

[3.15] gh-151126: Fix missing `PyErr_NoMemory` in `testinternalcapi.c` (

[3.15] gh-151126: Fix missing memory errors in `_interpretersmodule.c` (

gh-151126: Add missing `PyErr_NoMemory` in `_winapi.c` (#151588)

[3.13] gh-151126: Add missing `PyErr_NoMemory` in `_winapi.c` (GH-151588

[3.14] gh-151126: Add missing `PyErr_NoMemory` in `_winapi.c` (GH-151588

[3.15] gh-151126: Add missing `PyErr_NoMemory` in `_winapi.c` (GH-151588

gh-151126: Sets missing exceptions in `tkinter` and `socket` modules …

[3.13] gh-151126: Sets missing exceptions in `tkinter` and `socket` m…

[3.14] gh-151126: Sets missing exceptions in `tkinter` and `socket` m…

[3.15] gh-151126: Sets missing exceptions in `tkinter` and `socket` m…

gh-151126: Fix a possible crash during the startup with no memory und…

[3.14] gh-151126: Fix a possible crash during the startup with no mem…

[3.15] gh-151126: Fix a possible crash during the startup with no mem…

Merge branch 'main' into maurycy/bye-abba

pythongh-151126: Fix missing `PyErr_NoMemory` in `getpath.c` (python#…

pythongh-151126: Add missing `PyErr_NoMemory()` in `type_from_slots_o…

gh-151126: Fix `PyErr_NoMemory` errors in `_ctypes.c` (#152720)

[3.13] gh-151126: Fix missing memory errors in `_interpretersmodule.c` (

[3.13] gh-151126: Fix `PyErr_NoMemory` errors in `_ctypes.c` (GH-152720…

pythongh-151126: Set MemoryError on alloc failure in CJK codec macros

pythongh-151126: Check strdup result in readline on_completion

pythongh-151126: Set MemoryError on alloc failure in _PyXIData_InitWi…

[3.15] gh-151126: Fix `PyErr_NoMemory` errors in `_ctypes.c` (GH-152720…

gh-151126: Set `MemoryError` on allocation failure in CJK codec macros (

[3.14] gh-151126: Set `MemoryError` on allocation failure in CJK code…

[3.15] gh-151126: Set `MemoryError` on allocation failure in CJK code…

[3.14] gh-151126: Fix `PyErr_NoMemory` errors in `_ctypes.c` (GH-152720…

Navigation Menu

Repository navigation

Many places have missing `PyErr_NoMemory()` call after failing memory allocation #151126

Crash report

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	static int
	remove_unused_consts(basicblock entryblock, PyObject consts)
	{
	assert(PyList_CheckExact(consts));
	Py_ssize_t nconsts = PyList_GET_SIZE(consts);
	if (nconsts == 0) {
	return SUCCESS; /* nothing to do */
	}

	Py_ssize_t *index_map = NULL;
	Py_ssize_t *reverse_index_map = NULL;
	int err = ERROR;

	index_map = PyMem_Malloc(nconsts * sizeof(Py_ssize_t));
	if (index_map == NULL) {
	goto end;
	}

	attribute_list->attribute_list = PyMem_Malloc(attribute_list_size);
	if (attribute_list->attribute_list == NULL) {
	ret = -1;
	goto cleanup;
	}

	static _channelends *
	_channelends_new(void)
	{
	_channelends *ends = GLOBAL_MALLOC(_channelends);
	if (ends== NULL) {
	return NULL;
	}

Many places have missing PyErr_NoMemory() call after failing memory allocation #151126

Description

Crash report

Linked PRs

Activity

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

Many places have missing `PyErr_NoMemory()` call after failing memory allocation #151126