[3.11] GH-95736: fix IsolatedAsyncioTestCase to initialize Runner bef…#96042
Merged
Conversation
bedevere-bot
added
type-bug
kumaraditya303
force-pushed
the
backport-9d51599-3.11
branch
2 times, most recently
from
e005772 to
e9c7d24
Compare
…er before calling setup functions (pythonGH-95898) (cherry picked from commit 9d51599) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
kumaraditya303
force-pushed
the
backport-9d51599-3.11
branch
from
e9c7d24 to
ab95cf7
Compare
kumaraditya303
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit ab95cf7 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
gvanrossum
approved these changes
Aug 17, 2022
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
I discussed this with @pablogsal and he says it's okay to backport. He will review and approve when he's seen the code.
Member
|
Marked it as do-not-merge just to give @pablogsal a chance to review before it is merged. Pablo, once you agree that this can be merged into 3.11 please remove that label and approve the PR. |
pablogsal
approved these changes
Aug 18, 2022
pablogsal
left a comment
pablogsal
left a comment
Member
There was a problem hiding this comment.
LGTM
Thanks for pinging me! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ore calling setup functions (GH-95898)
(cherry picked from commit 9d51599)
Co-authored-by: Kumar Aditya 59607654+kumaraditya303@users.noreply.github.com
Co-authored-by: Serhiy Storchaka storchaka@gmail.com
IsolatedAsyncioTestCasedoes not callasyncio.set_event_loopbeforesetUpanymore,asyncio.Runner+PidFdChildWatcherleaves zombie processes #95736