Repository navigation
Commit 63e893d
Properly handle Xcode targets with spaces in their names (#42220)
Summary:
Properly handle targets with spaces in their names
Use quotes around the argument to basename path. Ensures this succeeds when the Xcode target name has spaces.
example:
```sh
#!/bin/sh
SOURCEMAP_FILE="ArchiveIntermediates/Jane Doe/IntermediateBuildFilesPath/Jane Doe.build/Release-iphoneos/JaneDoe.build/DerivedSources/main.jsbundle.map"
BN_SOURCEMAP_FILE="$(basename $SOURCEMAP_FILE)"
echo $BN_SOURCEMAP_FILE
```
output:
```
Jane Jane main.jsbundle.map
```
```sh
#!/bin/sh
SOURCEMAP_FILE="ArchiveIntermediates/Jane Doe/IntermediateBuildFilesPath/Jane Doe.build/Release-iphoneos/JaneDoe.build/DerivedSources/main.jsbundle.map"
BN_SOURCEMAP_FILE="$(basename "$SOURCEMAP_FILE")"
echo $BN_SOURCEMAP_FILE
```
output:
```
main.jsbundle.map
```
## Changelog:
[iOS] [Fixed] - Fix support for SOURCEMAP_FILE path containing spaces
## Related
#40937
Pull Request resolved: #42220
Reviewed By: christophpurrer
Differential Revision: D52650491
Pulled By: arushikesarwani94
fbshipit-source-id: e42b8a0d018b37fb558abd53d765fbdd676c51a21 parent 9155e2d commit 63e893d
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
127 | 127 | | |
128 | 128 | | |
129 | 129 | | |
130 | | - | |
| 130 | + | |
131 | 131 | | |
132 | 132 | | |
133 | 133 | | |
| |||
0 commit comments