Make assorted Components Flow strict-local (#57732)

Summary:
Pull Request resolved: #57732

Upgrade assorted components from `flow` to `flow strict-local` with accurate types. `Button` replaces implicit truthiness checks with explicit comparisons that preserve the exact previous runtime behavior (no logic change).

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D113763782

Author: rubennorte

packages/react-native/Libraries/Components/ActivityIndicator/ActivityIndicator.js

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow
+ * @flow strict-local
  * @format
  */
 
@@ -115,7 +115,7 @@ const ActivityIndicator: component(
   style,
   ...restProps
 }: {
-  ref?: any,
+  ref?: React.RefSetter<ActivityIndicatorInstance>,
   ...ActivityIndicatorProps,
 }) => {
   let sizeStyle;

packages/react-native/Libraries/Components/Button.js

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow
+ * @flow strict-local
  * @format
  */
 
@@ -232,7 +232,7 @@ const Button: component(
   } = props;
   const buttonStyles: Array<ViewStyleProp> = [styles.button];
   const textStyles: Array<TextStyleProp> = [styles.text];
-  if (color) {
+  if (Boolean(color)) {
     if (Platform.OS === 'ios') {
       textStyles.push({color: color});
     } else {
@@ -256,7 +256,7 @@ const Button: component(
       ? {..._accessibilityState, disabled}
       : _accessibilityState;
 
-  if (disabled) {
+  if (disabled === true) {
     buttonStyles.push(styles.buttonDisabled);
     textStyles.push(styles.textDisabled);
   }
@@ -279,7 +279,10 @@ const Button: component(
       accessible={accessible}
       accessibilityActions={accessibilityActions}
       onAccessibilityAction={onAccessibilityAction}
-      accessibilityLabel={ariaLabel || accessibilityLabel}
+      accessibilityLabel={
+        // $FlowFixMe[sketchy-null-string]
+        ariaLabel || accessibilityLabel
+      }
       accessibilityHint={accessibilityHint}
       accessibilityLanguage={accessibilityLanguage}
       accessibilityRole="button"

packages/react-native/Libraries/Components/DrawerAndroid/DrawerLayoutAndroid.android.js

@@ -4,10 +4,12 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow
+ * @flow strict-local
  * @format
  */
 
+// flowlint unsafe-getters-setters:off
+
 import type {
   MeasureInWindowOnSuccessCallback,
   MeasureLayoutOnSuccessCallback,
@@ -204,7 +206,7 @@ class DrawerLayoutAndroid
     );
   }
 
-  setNativeProps(nativeProps: Object) {
+  setNativeProps(nativeProps: {...}) {
     nullthrows(this._nativeRef.current).setNativeProps(nativeProps);
   }
 }

packages/react-native/Libraries/Components/DrawerAndroid/DrawerLayoutAndroid.js

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow
+ * @flow strict-local
  * @format
  */
 

packages/react-native/Libraries/Components/DrawerAndroid/DrawerLayoutAndroidTypes.js

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow
+ * @flow strict-local
  * @format
  */
 
@@ -127,7 +127,7 @@ export interface DrawerLayoutAndroidMethods {
     onSuccess: MeasureLayoutOnSuccessCallback,
     onFail?: () => void,
   ): void;
-  setNativeProps(nativeProps: Object): void;
+  setNativeProps(nativeProps: {...}): void;
 }
 
 export type DrawerLayoutAndroidInstance = DrawerLayoutAndroidMethods;

packages/react-native/Libraries/Components/StatusBar/StatusBar.js

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow
+ * @flow strict-local
  * @format
  */
 
@@ -101,13 +101,25 @@ export type StatusBarProps = Readonly<{
 
 type StackProps = {
   barStyle: ?{
-    value: StatusBarProps['barStyle'],
+    value: StatusBarStyle,
     animated: boolean,
   },
   hidden: ?{
     value: boolean,
     animated: boolean,
-    transition: StatusBarProps['showHideTransition'],
+    transition: StatusBarAnimation,
+  },
+};
+
+type ResolvedStackProps = {
+  barStyle: {
+    value: StatusBarStyle,
+    animated: boolean,
+  },
+  hidden: {
+    value: boolean,
+    animated: boolean,
+    transition: StatusBarAnimation,
   },
 };
 
@@ -126,13 +138,16 @@ function getAutoBarStyle(): 'light-content' | 'dark-content' {
  * barStyle to a concrete value.
  */
 function mergePropsStack(
-  propsStack: Array<Object>,
-  defaultValues: Object,
-): Object {
-  const merged: StackProps = propsStack.reduce(
+  propsStack: Array<StackProps>,
+  defaultValues: ResolvedStackProps,
+): ResolvedStackProps {
+  const merged: ResolvedStackProps = propsStack.reduce(
     (prev, cur) => {
       for (const prop in cur) {
+        // $FlowFixMe[invalid-computed-prop] dynamic merge over the known StackProps keys
         if (cur[prop] != null) {
+          // $FlowFixMe[invalid-computed-prop] dynamic merge over the known StackProps keys
+          // $FlowFixMe[prop-missing] dynamic merge over the known StackProps keys
           prev[prop] = cur[prop];
         }
       }
@@ -141,7 +156,7 @@ function mergePropsStack(
     {...defaultValues},
   );
 
-  if (merged.barStyle?.value === 'auto') {
+  if (merged.barStyle.value === 'auto') {
     merged.barStyle = {...merged.barStyle, value: getAutoBarStyle()};
   }
 
@@ -224,18 +239,18 @@ function createStackEntry(props: StatusBarProps): StackProps {
 class StatusBar extends React.Component<StatusBarProps> {
   static _propsStack: Array<StackProps> = [];
 
-  static _defaultProps: any = createStackEntry({
-    barStyle: 'default',
-    hidden: false,
-  });
+  static _defaultProps: ResolvedStackProps = {
+    barStyle: {value: 'default', animated: false},
+    hidden: {value: false, animated: false, transition: 'fade'},
+  };
 
   // Timer for updating the native module values at the end of the frame.
   static _updateImmediate: ?number = null;
 
   // The current merged values from the props stack. `barStyle.value` is stored
   // in its resolved form (never `'auto'`), so diff comparisons reflect what
   // was actually sent to the native module.
-  static _currentValues: ?StackProps = null;
+  static _currentValues: ?ResolvedStackProps = null;
 
   // Number of mounted `StatusBar` instances. Used to lazily subscribe to color
   // scheme changes only while at least one instance is on screen.
@@ -264,10 +279,10 @@ class StatusBar extends React.Component<StatusBarProps> {
    *    changing the status bar hidden property.
    */
   static setHidden(hidden: boolean, animation?: StatusBarAnimation) {
-    animation = animation || 'none';
+    const resolvedAnimation = animation ?? 'none';
     StatusBar._defaultProps.hidden.value = hidden;
     if (Platform.OS === 'ios') {
-      NativeStatusBarManagerIOS.setHidden(hidden, animation);
+      NativeStatusBarManagerIOS.setHidden(hidden, resolvedAnimation);
     } else if (Platform.OS === 'android') {
       NativeStatusBarManagerAndroid.setHidden(hidden);
     }
@@ -279,11 +294,11 @@ class StatusBar extends React.Component<StatusBarProps> {
    * @param animated Animate the style change.
    */
   static setBarStyle(style: StatusBarStyle, animated?: boolean) {
-    animated = animated || false;
+    const resolvedAnimated = animated ?? false;
     StatusBar._defaultProps.barStyle.value = style;
     const resolvedStyle = style === 'auto' ? getAutoBarStyle() : style;
     if (Platform.OS === 'ios') {
-      NativeStatusBarManagerIOS.setStyle(resolvedStyle, animated);
+      NativeStatusBarManagerIOS.setStyle(resolvedStyle, resolvedAnimated);
     } else if (Platform.OS === 'android') {
       NativeStatusBarManagerAndroid.setStyle(resolvedStyle);
     }

packages/react-native/Libraries/Components/Touchable/Touchable.js

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow
+ * @flow strict-local
  * @format
  */
 
@@ -331,7 +331,7 @@ const TouchableMixinImpl = {
    */
   /* $FlowFixMe[missing-this-annot] The 'this' type annotation(s) required by
    * Flow's LTI update could not be added via codemod */
-  touchableHandleResponderTerminationRequest: function (): any {
+  touchableHandleResponderTerminationRequest: function (): boolean {
     return !this.props.rejectResponderTermination;
   },
 
@@ -340,7 +340,7 @@ const TouchableMixinImpl = {
    */
   /* $FlowFixMe[missing-this-annot] The 'this' type annotation(s) required by
    * Flow's LTI update could not be added via codemod */
-  touchableHandleStartShouldSetResponder: function (): any {
+  touchableHandleStartShouldSetResponder: function (): boolean {
     return !this.props.disabled;
   },
 

packages/react-native/ReactNativeApi.d.ts

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<885d6e32c851ff6142ee176fe7adb996>>
+ * @generated SignedSource<<25a1cb3522d4ccc914779c118a0747fe>>
  *
  * This file was generated by scripts/js-api/build-types/index.js.
  */
@@ -1994,7 +1994,7 @@ declare interface DrawerLayoutAndroidMethods {
     onFail?: () => void,
   ): void
   openDrawer(): void
-  setNativeProps(nativeProps: Object): void
+  setNativeProps(nativeProps: {}): void
 }
 declare type DrawerLayoutAndroidProps = Readonly<
   ViewProps & {
@@ -4684,13 +4684,13 @@ declare type StackProps = {
     | undefined
     | {
         animated: boolean
-        value: StatusBarProps["barStyle"]
+        value: StatusBarStyle
       }
   hidden:
     | undefined
     | {
         animated: boolean
-        transition: StatusBarProps["showHideTransition"]
+        transition: StatusBarAnimation
         value: boolean
       }
 }
@@ -5790,8 +5790,8 @@ export {
   DimensionsPayload, // 653bc26c
   DisplayMetrics, // 1dc35cef
   DisplayMetricsAndroid, // 872e62eb
-  DrawerLayoutAndroid, // a1445452
-  DrawerLayoutAndroidInstance, // c0694352
+  DrawerLayoutAndroid, // 10f3ab23
+  DrawerLayoutAndroidInstance, // aa243cbf
   DrawerLayoutAndroidProps, // 8144971b
   DrawerSlideEvent, // c4ab8fba
   DropShadowValue, // e9df2606
@@ -5973,9 +5973,9 @@ export {
   ShareActionSheetIOSOptions, // eff574f5
   ShareContent, // 7c627896
   ShareOptions, // 800c3a4e
-  StatusBar, // f95dbb76
+  StatusBar, // 5748d574
   StatusBarAnimation, // 7fd047e6
-  StatusBarInstance, // 416e9640
+  StatusBarInstance, // de13e4a1
   StatusBarProps, // c2a44d88
   StatusBarStyle, // 78f53eea
   StyleProp, // fa0e9b4a